Skip to content

fix(marketing): prioritize founding engineer and update developer count - #7944

Merged
Kitenite merged 1 commit into
mainfrom
match-founding-pay-6db76f84
Sep 30, 2026
Merged

Kitenite merged 1 commit into
mainfrom
match-founding-pay-6db76f84

Conversation

@Kitenite

@Kitenite Kitenite commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

What & why

Put Founding Engineer first on the join-us page while preserving the order of the remaining WaaS roles. Update the developer count from 50,000+ to 100,000+ and remove the outdated count-verification comment.

How I tested it

  • Verified the local Next.js page in Comet with the real WaaS widget: Founding Engineer appears first after initial load, a cache-bypassing reload, and returning from either job detail. Both roles open the correct details; no browser errors were captured.
  • Verified the page displays 100,000+ developers.
  • bun run lint:fix, bun run lint, and bun run typecheck passed.
  • bun run --cwd apps/marketing test: 149 passed, 0 failed.
  • bun run test stopped on 7 failures in @superset/trpc's deriveSandboxCredentials tests, outside this marketing change.

Verified local join-us page showing 100,000+ developers and Founding Engineer first

Checklist

  • PR title follows conventional commits (type(scope): subject)
  • bun run lint and bun run typecheck pass (CI fails on lint warnings too)
  • "Allow edits from maintainers" is checked on fork PRs — same-repository branch

Summary by cubic

Prioritizes the Founding Engineer role on the join-us page and updates the developer count from 50,000+ to 100,000+.

  • Moves the Founding Engineer job (id 91489) to the top of the WaaS job board while keeping the remaining roles in their original order.
  • Updates the displayed developer count and removes the outdated PostHog verification comment.

Written for commit 32589fa. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Updates
    • The Join Us page now displays a localized developer count of 100,000.
    • Job ID 91489 appears first in the filtered job listings when present; other jobs retain their relative order.

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 6d22cc78-b8bd-45fd-a315-670055826765

📥 Commits

Reviewing files that changed from the base of the PR and between cd320cf and 32589fa.

📒 Files selected for processing (1)
  • apps/marketing/src/app/[lang]/join-us/page.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The Join Us page now displays a developer count of 100,000. It also moves job ID 91489 to the front of the filtered job list when that job appears after the first position.

Changes

Developer count

Layer / File(s) Summary
Displayed developer count
apps/marketing/src/app/[lang]/join-us/page.tsx
The displayed developer count changes from 50,000 to 100,000. The verification comment for the prior count is removed.

Job listing order

Layer / File(s) Summary
Filtered job ordering
apps/marketing/src/app/[lang]/join-us/page.tsx
When job ID 91489 appears after the first position, the page moves it to the front and preserves the relative order of the other jobs. If it is absent or already first, the list is unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 32589

The page will show 100,000+ and prioritize the Founding Engineer role. No concrete merge-blocking issue is established; the displayed count could not be independently verified from the available sources.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 32589

The change does not show a new security exposure. Its main design risk is that the job-ordering customization depends on the external job board’s initialization and state behavior, which has not been established.

Retained concerns

  • Low · architecture · inferred: If the external widget exposes filteredJobs only after the page callback starts, the new dereference throws before the callback installs its observer and polling recovery. Whether the widget guarantees earlier initialization remains unverified.
Security review details

Security Blast Radius

  • inferred — The changed behavior is confined to the public page’s count and client-side job-list presentation. No changed cross-system dependency or protected-data path is identified.

Trust Boundaries and Controls

  • observed — The page already loads the external job-board script and configures its client-side widget. The changed ranges do not replace that script or alter the existing hCaptcha customization.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the two main changes and follows the repository's conventional commit format.
Description check ✅ Passed The description explains what changed, why it changed, how it was tested, includes a screenshot, and completes the checklist. It also documents the unrelated full-test failures.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

@Kitenite
Kitenite merged commit 7919ac6 into main Sep 30, 2026
19 of 20 checks passed
Kitenite added a commit that referenced this pull request Oct 1, 2026
* docs: weekly update for PRs merged 2026-09-23 to 2026-09-30

Source of truth: live Notion SOP "Weekly Docs Update (automation SOP)".
Window: merged:>=2026-09-23 (139 PRs). PRs through the morning of 09-23
were covered by #7771.

Changes
- Pages: no auto-open on publish (#7790); page links and URL links split
  into their own settings (#7916, #7962, #7946); Listening agents menu with
  per-row stop and Add listening agent (#7724, #7820, #7919); globe on the
  Share button (#7766); Report on public pages (#7886); agents offer a page
  (#7759). Files: pages.mdx, cli/cli-reference.mdx.
- Settings moves: Links replaced by Browser and Files & Editor (#7916,
  #7962). Files: editor.mdx, terminal-integration.mdx, customization.mdx.
- Editor: inline rename and drag to move (#7692), Auto Save (#7693, #7916),
  open and save files outside the workspace (#7897, #7982), Copy as Markdown
  (#7591), per-pane error screen (#7983). File: editor.mdx.
- Terminal copy follows Ghostty's whitespace rules (#7868).
  File: terminal-integration.mdx.
- Agents: UFO (#7898); GPT-6 Astra, Sonnet 5.5, retiring GPT-5.5, retired
  GPT-5.4/5.3 Codex (#7783, #7894, #7935). Files: agent-integration.mdx,
  cli/cli-reference.mdx.
- Host: superset start --daemon --auto-update and update-lock permission
  errors (#7735, #7952). Files: cli/host-server.mdx, cli/cli-reference.mdx.
- Removed the mcp CLI section and the Connected Service Plugins section:
  #7776 made plugins/mcp internal, the Plugins page is staff-flagged, and
  apps/docs/AGENTS.md keeps internal commands out. Files: skills.mdx,
  cli/cli-reference.mdx.
- Slack page unfurls and details panel (#7817, #7821, #7914, #7957).
  File: use-with-slack.mdx.
- Workspaces: instant creation with background naming (#7518); recoverable
  project deletion (#7896). File: workspaces.mdx.
- Shortcuts: prev/next workspace includes Pinned and wraps (#7851); ⌘B
  collapses the sidebar to a rail (#7964). File: keyboard-shortcuts.mdx.
- Ship controls and open-in button moved to the right sidebar strip (#7958).
  Files: diff-viewer.mdx, use-with-ide.mdx.

Deliberately skipped
- Cloud workspaces/environments/sandboxes (flag-gated, AGENTS.md rule):
  #7784 #7795 #7824 #7840 #7844 #7845 #7847 #7849 #7850 #7858 #7861 #7863
  #7874 #7911 #7913 #7918 #7922 #7931 #7932 #7937 #7956 #7961 #7969 #7981
  #7637 #7794 #7789 #7838 (its CLI docs already shipped in the PR).
- Staff-only plugins: #7912 Sentry plugin, #7716, #7727, #7955.
- Already documented in their own PRs: #7917, #7921.
- Removed feature never documented: #7796 Google Calendar triggers.
- Agents chip remove/revert/default-off, never documented: #7870 #7871 #7872.
- Billing/backend policy with no docs surface: #7947, #7812, #7786, #7792,
  #7798, #7761, #7948, #7949, #7951, #7827.
- Reverted security trio: #7828 #7829 #7830 (reverted by #7834).
- Fixes restoring expected behavior: #7683 #7696 #7707 #7743 #7751 #7756
  #7764 #7765 #7781 #7788 #7791 #7823 #7825 #7833 #7837 #7852 #7857 #7860
  #7864 #7865 #7869 #7873 #7897-covered #7903 #7938 #7980 #7943 #7964-chrome.
- Mobile (no docs page): #7746 #7747 #7748 #7749 #7750 #7782 #7793 #7810
  #7814 #7816 #7889 #7968.
- Marketing, internal docs, CI, version bumps: #7651 #7744 #7752 #7771 #7774
  #7776-infra #7777 #7785 #7811 #7818 #7822 #7826 #7834 #7884 #7885 #7895
  #7909 #7933 #7934 #7942 #7944 #7965 #7966.

Validation: bun run --cwd apps/docs typecheck, bun run lint:fix,
bun run lint (exit 0), Vale on 13 changed files (0 errors, 0 warnings),
git diff --check.

* chore: log weekly docs update follow-ups

* docs: tighten review findings in the weekly update

Only the page creator can stop or add listening agents. On focus change also
saves on window blur, and Auto Save pauses on conflicts. Taken-down pages do
not unfurl. Model picker coverage matches agent-models.ts.

This branch was previously deployed

1 inactive deployment
preview — 32589fa3 Deployed Sep 29, 2026 by Kitenite via Deploy API #10563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant