Skip to content

fix(web): serve robots.txt so link previews can fetch public pages - #7818

Merged
saddlepaddle merged 1 commit into
mainfrom
saddlepaddle/app-robots-and-og-bots
Sep 24, 2026
Merged

saddlepaddle merged 1 commit into
mainfrom
saddlepaddle/app-robots-and-og-bots

Conversation

@saddlepaddle

@saddlepaddle saddlepaddle commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Why

https://app.superset.sh/robots.txt 307s to /sign-in?redirect=%2Frobots.txt and returns the sign-in HTML. The auth proxy matcher covers .txt, and the public-route list had no entry for it. Link-preview crawlers (Facebook, LinkedIn, Slack) fetch robots.txt before the URL someone pasted, and an HTML login page is at best unparseable and at worst read as a block. This is the most likely reason a public page did not unfurl on Facebook even though the page itself serves full og tags to the Facebook crawler.

What

  • app/robots.ts serves User-agent: * / Allow: /, and /robots.txt joins the proxy's public routes. Public pages already carry noindex, and nothing else on this host is reachable without a session, so indexing behaviour is unchanged.
  • The public page's og:image carries alt.

Verification

  • bun test for proxy-routes and proxy (48 pass, including the new /robots.txt case) and bun run typecheck in apps/web: clean.
  • Not verified live: needs the deploy. After it lands, curl -I https://app.superset.sh/robots.txt should be 200 text/plain, and a Facebook Sharing Debugger rescrape of https://app.superset.sh/page/unfurl-test-page-t8mcl5 should show the card.

Summary by CodeRabbit

  • New Features
    • Added a public robots.txt file that allows search engine crawlers to access the site.
  • Accessibility
    • Added descriptive alt text to page thumbnail images shared through Open Graph and Twitter metadata.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 03af5ee7-d775-4462-8b1e-a72ca87f4bd1

📥 Commits

Reviewing files that changed from the base of the PR and between c5989ca and 92c70b5.

📒 Files selected for processing (4)
  • apps/web/src/app/page/[slug]/page.tsx
  • apps/web/src/app/robots.ts
  • apps/web/src/proxy-routes.test.ts
  • apps/web/src/proxy-routes.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The web app adds the shared page title as thumbnail image alt text. It also adds a robots route that allows all user agents to crawl / and makes /robots.txt a public route.

Changes

Crawler metadata and robots route

Layer / File(s) Summary
Shared-page thumbnail metadata
apps/web/src/app/page/[slug]/page.tsx
Thumbnail image metadata now uses the shared page title as its alt text.
Public robots route
apps/web/src/app/robots.ts, apps/web/src/proxy-routes.ts, apps/web/src/proxy-routes.test.ts
The robots route allows all user agents to crawl /. /robots.txt is included in public routes and in the corresponding route test.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: harshithmullapudi

Merge Risk: ⚪ Minimal · up to 92c70

The public robots route can reach crawlers without a sign-in redirect, and the thumbnail metadata adds alt text. No merge-blocking risk is apparent; normal deployment checks can confirm production routing.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title uses conventional commit format and clearly describes serving robots.txt for public link-preview access.
Description check ✅ Passed The description explains the problem, the implementation, and the verification performed. It omits the template Checklist and uses Why, What, and Verification headings instead of the exact template he…
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@saddlepaddle
saddlepaddle force-pushed the saddlepaddle/app-robots-and-og-bots branch from 221c076 to 0a4526d Compare September 24, 2026 20:25
@saddlepaddle saddlepaddle changed the title fix(web): serve robots.txt and put og tags in the head for more crawlers fix(web): serve robots.txt so link previews can fetch public pages Sep 24, 2026
@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

app.superset.sh/robots.txt redirected to /sign-in because the auth proxy
had no exemption for it, so link-preview crawlers that fetch robots.txt
before a shared URL saw an HTML login page. Serve a permissive robots.txt;
public pages already carry noindex. og:image also gets an alt.
@saddlepaddle
saddlepaddle force-pushed the saddlepaddle/app-robots-and-og-bots branch from 0a4526d to 92c70b5 Compare September 24, 2026 20:28
@saddlepaddle
saddlepaddle merged commit 49c1e60 into main Sep 24, 2026
20 checks passed
Kitenite added a commit that referenced this pull request Oct 1, 2026
* docs: weekly update for PRs merged 2026-09-23 to 2026-09-30

Source of truth: live Notion SOP "Weekly Docs Update (automation SOP)".
Window: merged:>=2026-09-23 (139 PRs). PRs through the morning of 09-23
were covered by #7771.

Changes
- Pages: no auto-open on publish (#7790); page links and URL links split
  into their own settings (#7916, #7962, #7946); Listening agents menu with
  per-row stop and Add listening agent (#7724, #7820, #7919); globe on the
  Share button (#7766); Report on public pages (#7886); agents offer a page
  (#7759). Files: pages.mdx, cli/cli-reference.mdx.
- Settings moves: Links replaced by Browser and Files & Editor (#7916,
  #7962). Files: editor.mdx, terminal-integration.mdx, customization.mdx.
- Editor: inline rename and drag to move (#7692), Auto Save (#7693, #7916),
  open and save files outside the workspace (#7897, #7982), Copy as Markdown
  (#7591), per-pane error screen (#7983). File: editor.mdx.
- Terminal copy follows Ghostty's whitespace rules (#7868).
  File: terminal-integration.mdx.
- Agents: UFO (#7898); GPT-6 Astra, Sonnet 5.5, retiring GPT-5.5, retired
  GPT-5.4/5.3 Codex (#7783, #7894, #7935). Files: agent-integration.mdx,
  cli/cli-reference.mdx.
- Host: superset start --daemon --auto-update and update-lock permission
  errors (#7735, #7952). Files: cli/host-server.mdx, cli/cli-reference.mdx.
- Removed the mcp CLI section and the Connected Service Plugins section:
  #7776 made plugins/mcp internal, the Plugins page is staff-flagged, and
  apps/docs/AGENTS.md keeps internal commands out. Files: skills.mdx,
  cli/cli-reference.mdx.
- Slack page unfurls and details panel (#7817, #7821, #7914, #7957).
  File: use-with-slack.mdx.
- Workspaces: instant creation with background naming (#7518); recoverable
  project deletion (#7896). File: workspaces.mdx.
- Shortcuts: prev/next workspace includes Pinned and wraps (#7851); ⌘B
  collapses the sidebar to a rail (#7964). File: keyboard-shortcuts.mdx.
- Ship controls and open-in button moved to the right sidebar strip (#7958).
  Files: diff-viewer.mdx, use-with-ide.mdx.

Deliberately skipped
- Cloud workspaces/environments/sandboxes (flag-gated, AGENTS.md rule):
  #7784 #7795 #7824 #7840 #7844 #7845 #7847 #7849 #7850 #7858 #7861 #7863
  #7874 #7911 #7913 #7918 #7922 #7931 #7932 #7937 #7956 #7961 #7969 #7981
  #7637 #7794 #7789 #7838 (its CLI docs already shipped in the PR).
- Staff-only plugins: #7912 Sentry plugin, #7716, #7727, #7955.
- Already documented in their own PRs: #7917, #7921.
- Removed feature never documented: #7796 Google Calendar triggers.
- Agents chip remove/revert/default-off, never documented: #7870 #7871 #7872.
- Billing/backend policy with no docs surface: #7947, #7812, #7786, #7792,
  #7798, #7761, #7948, #7949, #7951, #7827.
- Reverted security trio: #7828 #7829 #7830 (reverted by #7834).
- Fixes restoring expected behavior: #7683 #7696 #7707 #7743 #7751 #7756
  #7764 #7765 #7781 #7788 #7791 #7823 #7825 #7833 #7837 #7852 #7857 #7860
  #7864 #7865 #7869 #7873 #7897-covered #7903 #7938 #7980 #7943 #7964-chrome.
- Mobile (no docs page): #7746 #7747 #7748 #7749 #7750 #7782 #7793 #7810
  #7814 #7816 #7889 #7968.
- Marketing, internal docs, CI, version bumps: #7651 #7744 #7752 #7771 #7774
  #7776-infra #7777 #7785 #7811 #7818 #7822 #7826 #7834 #7884 #7885 #7895
  #7909 #7933 #7934 #7942 #7944 #7965 #7966.

Validation: bun run --cwd apps/docs typecheck, bun run lint:fix,
bun run lint (exit 0), Vale on 13 changed files (0 errors, 0 warnings),
git diff --check.

* chore: log weekly docs update follow-ups

* docs: tighten review findings in the weekly update

Only the page creator can stop or add listening agents. On focus change also
saves on window blur, and Auto Save pauses on conflicts. Taken-down pages do
not unfurl. Model picker coverage matches agent-models.ts.

This branch was previously deployed

1 inactive deployment
preview — 92c70b55 Deployed Sep 24, 2026 by saddlepaddle via Deploy Docs #10333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant