Skip to content

fix(desktop): clamp long session names in the sidebar hover card - #7707

Merged
Kitenite merged 1 commit into
ParadevAI:mainfrom
Official-Krish:fix/hover-card-long-session-name
Sep 25, 2026
Merged

Kitenite merged 1 commit into
ParadevAI:mainfrom
Official-Krish:fix/hover-card-long-session-name

Conversation

@Official-Krish

@Official-Krish Official-Krish commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #7706

What & why

Hovering a session with a long unbreakable name (underscores/camelCase, no spaces or hyphens) spilled the name past the hover card's fixed 288px (w-72) border, painting over surrounding UI.

One-line change in DashboardSidebarWorkspaceHoverCardContent.tsx:68, restoring parity with the legacy WorkspaceHoverCard.tsx:81 (classes dropped in the port):

<div className="text-sm font-medium break-words line-clamp-2" title={name}>

break-words wraps unbreakable tokens, line-clamp-2 bounds card height with ellipsis, title keeps the full name reachable. Shared PopoverContent deliberately untouched (would affect every popover). title is a plain attribute outside , so no translation entries change.

How I tested it

  • New co-located DashboardSidebarWorkspaceHoverCardContent.test.tsx: renders with a 170-char unbroken name + different branch (so hasCustomAlias is true), asserts the name node carries break-words + line-clamp-2 and exposes the full name via title — 1 pass (run from apps/desktop/ for the Lingui-macro preload).
  • biome check on the folder — clean. bun run check:i18n — no catalog diff.
  • Manual hover check in the dev desktop app still to do: rename a session to averyveryverylongsessionnamewithoutanyspacesatall, hover its sidebar row, confirm the name clamps to two lines inside the card with ellipsis + tooltip.

Before
Screenshot 2026-09-21 at 1 43 44 PM

After
Screenshot 2026-09-21 at 2 13 37 PM

Checklist

  • PR title follows conventional commits (type(scope): subject)
  • bun run lint and bun run typecheck pass (CI fails on lint warnings too)
  • "Allow edits from maintainers" is checked on fork PRs

Summary by cubic

Fixes long unbreakable session names overflowing the desktop sidebar hover card's fixed width and painting over surrounding UI. Names now wrap and clamp to two lines with an ellipsis, with the full name still reachable via the title tooltip.

  • Adds a test covering an unbroken 170-char session name.

Written for commit 3d097c7. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Bug Fixes

    • Long workspace aliases now wrap across up to two lines instead of being restricted to a single line.
    • Hovering over a truncated alias displays the full workspace name in a tooltip.
  • Tests

    • Added coverage for wrapping, truncation, and tooltip behavior for long workspace aliases.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: e7737470-5935-4cf8-81da-735c602343f2

📥 Commits

Reviewing files that changed from the base of the PR and between fd85637 and 3d097c7.

📒 Files selected for processing (2)
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarWorkspaceHoverCardContent/DashboardSidebarWorkspaceHoverCardContent.test.tsx
  • apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarWorkspaceHoverCardContent/DashboardSidebarWorkspaceHoverCardContent.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The workspace hover card now wraps and clamps long custom aliases. A title tooltip exposes the complete alias. A new test verifies the classes, displayed text, and tooltip value.

Changes

Workspace hover card text containment

Layer / File(s) Summary
Custom alias containment and validation
apps/desktop/src/renderer/routes/_authenticated/_dashboard/components/DashboardSidebar/components/DashboardSidebarWorkspaceItem/components/DashboardSidebarWorkspaceHoverCardContent/*
Custom aliases now use break-words and line-clamp-2, with the full alias in a title tooltip. The test covers long unbreakable names and verifies the rendered classes and tooltip.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: saddlepaddle

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title uses conventional commit format and clearly describes the main change: clamping long session names in the desktop sidebar hover card.
Description check ✅ Passed The description explains the problem, implementation, testing, screenshots, and checklist status. It also identifies that manual hover verification remains pending, but the description is otherwise co…
Linked Issues check ✅ Passed Issue [#7706] requires long session names to remain within the hover card. The change applies break-words and line-clamp-2 to the custom session name and preserves the full value in title. The c…
Out of Scope Changes check ✅ Passed The pull request changes only the session hover-card name rendering and adds a focused co-located test. Both changes directly support issue [#7706]. No unrelated product behavior or shared `PopoverCon…
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Kitenite
Kitenite merged commit 6fda445 into ParadevAI:main Sep 25, 2026
2 checks passed
Kitenite added a commit that referenced this pull request Oct 1, 2026
* docs: weekly update for PRs merged 2026-09-23 to 2026-09-30

Source of truth: live Notion SOP "Weekly Docs Update (automation SOP)".
Window: merged:>=2026-09-23 (139 PRs). PRs through the morning of 09-23
were covered by #7771.

Changes
- Pages: no auto-open on publish (#7790); page links and URL links split
  into their own settings (#7916, #7962, #7946); Listening agents menu with
  per-row stop and Add listening agent (#7724, #7820, #7919); globe on the
  Share button (#7766); Report on public pages (#7886); agents offer a page
  (#7759). Files: pages.mdx, cli/cli-reference.mdx.
- Settings moves: Links replaced by Browser and Files & Editor (#7916,
  #7962). Files: editor.mdx, terminal-integration.mdx, customization.mdx.
- Editor: inline rename and drag to move (#7692), Auto Save (#7693, #7916),
  open and save files outside the workspace (#7897, #7982), Copy as Markdown
  (#7591), per-pane error screen (#7983). File: editor.mdx.
- Terminal copy follows Ghostty's whitespace rules (#7868).
  File: terminal-integration.mdx.
- Agents: UFO (#7898); GPT-6 Astra, Sonnet 5.5, retiring GPT-5.5, retired
  GPT-5.4/5.3 Codex (#7783, #7894, #7935). Files: agent-integration.mdx,
  cli/cli-reference.mdx.
- Host: superset start --daemon --auto-update and update-lock permission
  errors (#7735, #7952). Files: cli/host-server.mdx, cli/cli-reference.mdx.
- Removed the mcp CLI section and the Connected Service Plugins section:
  #7776 made plugins/mcp internal, the Plugins page is staff-flagged, and
  apps/docs/AGENTS.md keeps internal commands out. Files: skills.mdx,
  cli/cli-reference.mdx.
- Slack page unfurls and details panel (#7817, #7821, #7914, #7957).
  File: use-with-slack.mdx.
- Workspaces: instant creation with background naming (#7518); recoverable
  project deletion (#7896). File: workspaces.mdx.
- Shortcuts: prev/next workspace includes Pinned and wraps (#7851); ⌘B
  collapses the sidebar to a rail (#7964). File: keyboard-shortcuts.mdx.
- Ship controls and open-in button moved to the right sidebar strip (#7958).
  Files: diff-viewer.mdx, use-with-ide.mdx.

Deliberately skipped
- Cloud workspaces/environments/sandboxes (flag-gated, AGENTS.md rule):
  #7784 #7795 #7824 #7840 #7844 #7845 #7847 #7849 #7850 #7858 #7861 #7863
  #7874 #7911 #7913 #7918 #7922 #7931 #7932 #7937 #7956 #7961 #7969 #7981
  #7637 #7794 #7789 #7838 (its CLI docs already shipped in the PR).
- Staff-only plugins: #7912 Sentry plugin, #7716, #7727, #7955.
- Already documented in their own PRs: #7917, #7921.
- Removed feature never documented: #7796 Google Calendar triggers.
- Agents chip remove/revert/default-off, never documented: #7870 #7871 #7872.
- Billing/backend policy with no docs surface: #7947, #7812, #7786, #7792,
  #7798, #7761, #7948, #7949, #7951, #7827.
- Reverted security trio: #7828 #7829 #7830 (reverted by #7834).
- Fixes restoring expected behavior: #7683 #7696 #7707 #7743 #7751 #7756
  #7764 #7765 #7781 #7788 #7791 #7823 #7825 #7833 #7837 #7852 #7857 #7860
  #7864 #7865 #7869 #7873 #7897-covered #7903 #7938 #7980 #7943 #7964-chrome.
- Mobile (no docs page): #7746 #7747 #7748 #7749 #7750 #7782 #7793 #7810
  #7814 #7816 #7889 #7968.
- Marketing, internal docs, CI, version bumps: #7651 #7744 #7752 #7771 #7774
  #7776-infra #7777 #7785 #7811 #7818 #7822 #7826 #7834 #7884 #7885 #7895
  #7909 #7933 #7934 #7942 #7944 #7965 #7966.

Validation: bun run --cwd apps/docs typecheck, bun run lint:fix,
bun run lint (exit 0), Vale on 13 changed files (0 errors, 0 warnings),
git diff --check.

* chore: log weekly docs update follow-ups

* docs: tighten review findings in the weekly update

Only the page creator can stop or add listening agents. On focus change also
saves on window blur, and Auto Save pauses on conflicts. Taken-down pages do
not unfurl. Model picker coverage matches agent-models.ts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Long session names overflow outside the session hover card

2 participants