Repository navigation
fix(desktop): copy rendered text instead of Markdown (#7454) - #7591
Merged
Kitenite merged 2 commits intoSep 25, 2026
Merged
Conversation
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (22)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe rendered Markdown view now provides an explicit “Copy as Markdown” action. Regular clipboard copying returns visible plain text outside tables. The action is available for editable and non-editable content, with translations added across locale catalogs. ChangesRendered Markdown copy behavior
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix · Severity of issue fixed: Medium Sequence Diagram(s)sequenceDiagram
participant User
participant SelectionContextMenu
participant TipTapMarkdownRenderer
participant Clipboard
User->>SelectionContextMenu: Selects "Copy as Markdown"
SelectionContextMenu->>TipTapMarkdownRenderer: Requests selected Markdown
TipTapMarkdownRenderer-->>SelectionContextMenu: Returns serialized selection
SelectionContextMenu->>Clipboard: Copies Markdown
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The Markdown copy changes have no unresolved merge-blocking risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 5 files. (17 skipped: 17 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The Radix SelectionContextMenu calls preventDefault on the contextmenu event, which stops Chromium emitting the webContents event that attachEditContextMenu turns into the native edit menu. Wrapping editable views in it traded Paste, Cut, Undo/Redo and spellcheck for the in-page copy actions in the markdown file editor (FileViewerContent, MarkdownPreviewView). Restore the editable early return so editable views stay on the native menu; read-only views keep the in-page menu and its Copy as Markdown. Verified over CDP against the running app: right-click on an editable view now leaves defaultPrevented false and pops the native menu with Cut, Copy and Paste enabled; read-only still shows Copy as Markdown.
Kitenite
added a commit
that referenced
this pull request
Oct 1, 2026
* docs: weekly update for PRs merged 2026-09-23 to 2026-09-30 Source of truth: live Notion SOP "Weekly Docs Update (automation SOP)". Window: merged:>=2026-09-23 (139 PRs). PRs through the morning of 09-23 were covered by #7771. Changes - Pages: no auto-open on publish (#7790); page links and URL links split into their own settings (#7916, #7962, #7946); Listening agents menu with per-row stop and Add listening agent (#7724, #7820, #7919); globe on the Share button (#7766); Report on public pages (#7886); agents offer a page (#7759). Files: pages.mdx, cli/cli-reference.mdx. - Settings moves: Links replaced by Browser and Files & Editor (#7916, #7962). Files: editor.mdx, terminal-integration.mdx, customization.mdx. - Editor: inline rename and drag to move (#7692), Auto Save (#7693, #7916), open and save files outside the workspace (#7897, #7982), Copy as Markdown (#7591), per-pane error screen (#7983). File: editor.mdx. - Terminal copy follows Ghostty's whitespace rules (#7868). File: terminal-integration.mdx. - Agents: UFO (#7898); GPT-6 Astra, Sonnet 5.5, retiring GPT-5.5, retired GPT-5.4/5.3 Codex (#7783, #7894, #7935). Files: agent-integration.mdx, cli/cli-reference.mdx. - Host: superset start --daemon --auto-update and update-lock permission errors (#7735, #7952). Files: cli/host-server.mdx, cli/cli-reference.mdx. - Removed the mcp CLI section and the Connected Service Plugins section: #7776 made plugins/mcp internal, the Plugins page is staff-flagged, and apps/docs/AGENTS.md keeps internal commands out. Files: skills.mdx, cli/cli-reference.mdx. - Slack page unfurls and details panel (#7817, #7821, #7914, #7957). File: use-with-slack.mdx. - Workspaces: instant creation with background naming (#7518); recoverable project deletion (#7896). File: workspaces.mdx. - Shortcuts: prev/next workspace includes Pinned and wraps (#7851); ⌘B collapses the sidebar to a rail (#7964). File: keyboard-shortcuts.mdx. - Ship controls and open-in button moved to the right sidebar strip (#7958). Files: diff-viewer.mdx, use-with-ide.mdx. Deliberately skipped - Cloud workspaces/environments/sandboxes (flag-gated, AGENTS.md rule): #7784 #7795 #7824 #7840 #7844 #7845 #7847 #7849 #7850 #7858 #7861 #7863 #7874 #7911 #7913 #7918 #7922 #7931 #7932 #7937 #7956 #7961 #7969 #7981 #7637 #7794 #7789 #7838 (its CLI docs already shipped in the PR). - Staff-only plugins: #7912 Sentry plugin, #7716, #7727, #7955. - Already documented in their own PRs: #7917, #7921. - Removed feature never documented: #7796 Google Calendar triggers. - Agents chip remove/revert/default-off, never documented: #7870 #7871 #7872. - Billing/backend policy with no docs surface: #7947, #7812, #7786, #7792, #7798, #7761, #7948, #7949, #7951, #7827. - Reverted security trio: #7828 #7829 #7830 (reverted by #7834). - Fixes restoring expected behavior: #7683 #7696 #7707 #7743 #7751 #7756 #7764 #7765 #7781 #7788 #7791 #7823 #7825 #7833 #7837 #7852 #7857 #7860 #7864 #7865 #7869 #7873 #7897-covered #7903 #7938 #7980 #7943 #7964-chrome. - Mobile (no docs page): #7746 #7747 #7748 #7749 #7750 #7782 #7793 #7810 #7814 #7816 #7889 #7968. - Marketing, internal docs, CI, version bumps: #7651 #7744 #7752 #7771 #7774 #7776-infra #7777 #7785 #7811 #7818 #7822 #7826 #7834 #7884 #7885 #7895 #7909 #7933 #7934 #7942 #7944 #7965 #7966. Validation: bun run --cwd apps/docs typecheck, bun run lint:fix, bun run lint (exit 0), Vale on 13 changed files (0 errors, 0 warnings), git diff --check. * chore: log weekly docs update follow-ups * docs: tighten review findings in the weekly update Only the page creator can stop or add listening agents. On focus change also saves on window blur, and Auto Save pauses on conflicts. Taken-down pages do not unfurl. Model picker coverage matches agent-models.ts.
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Fixes #7454
Rendered Markdown used the Markdown serializer for the clipboard
text/plainpayload. As a result, copying inline code or a fenced block into a plain-text destination included backticks and fences.Cmd/Ctrl+C now copies the rendered text instead. Markdown remains available explicitly through Copy as Markdown in the selection context menu, including in editable Markdown views. The TipTap Markdown extension's second copied-text serializer is disabled so it cannot overwrite the plain-text result. Added translations for the new action.
How I tested it
bun test apps/desktop/src/renderer/components/MarkdownRenderer/components/TipTapMarkdownRenderer/serializeMarkdownTable.test.ts— 14 pass. The regression test was RED before the change (**hi**returned) and GREEN after (hi). Existing whole-table GFM and partial-table plain-text cases remain covered.bun run lint— pass (7,919 files).bun run check:i18n— pass for all locales.bun run typecheckcannot complete in this isolated worktree because its package-local dependencies are absent (@superset/typescript/internal-package.json,bun-types). A desktoptsccheck from the available dependency-bearing checkout has existing unrelated errors, but none in the five modified Markdown files.Checklist
type(scope): subject)bun run lintpassesbun run typecheckpasses (blocked by the isolated worktree dependency layout above)Summary by cubic
Fixes copying in rendered Markdown so Cmd/Ctrl+C copies visible text instead of Markdown source (e.g.
**hi**→hi); previously backticks and fences leaked into plain-text destinations. Markdown remains available through a new "Copy as Markdown" item in the selection context menu on read-only views.transformCopiedTextso it can't override the plain-text clipboard payload.Written for commit 250e68c. Summary will update on new commits.
Summary by CodeRabbit
New Features
Localization