Skip to content

mobile: use the desktop sidebar's cloud glyph for the cloud scope - #7861

Merged
saddlepaddle merged 1 commit into
mainfrom
saddlepaddle/mobile-cloud-icon-sync
Sep 25, 2026
Merged

saddlepaddle merged 1 commit into
mainfrom
saddlepaddle/mobile-cloud-icon-sync

Conversation

@saddlepaddle

@saddlepaddle saddlepaddle commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Mobile drew Lucide's cloud for the Cloud scope; the desktop sidebar draws Tabler's. Mobile now draws the same Tabler glyph in the home scope chip, the filter sheet, the scope picker, and the cloud provisioning screen.

react-icons is DOM-only and @tabler/icons-react-native would ship its whole barrel through Metro for one glyph, so the path is built with createLucideIcon and slots into the existing Icon wrapper.

Test plan

  • biome clean on apps/mobile/screens
  • tsc --noEmit reports no errors in the touched files (the remaining errors are pre-existing and unrelated)
  • not simulator-verified; the path is copied verbatim from the react-icons Tabler build desktop imports

🤖 Generated with Claude Code


Summary by cubic

Aligns mobile's cloud scope icon with the Tabler cloud glyph the desktop sidebar draws, so the same workspace reads the same on both surfaces. The new glyph appears in the home scope chip, the filter sheet, the scope picker, and the cloud provisioning screen, replacing Lucide's cloud.

The shared CloudIcon is built with createLucideIcon so it keeps working with the existing Icon wrapper, avoiding @tabler/icons-react-native, which would ship its whole barrel through Metro for a single glyph.

Written for commit fc60777. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Style
    • Standardized the cloud icon across filtering, scope navigation, and workspace provisioning screens.

Mobile used Lucide's cloud while the desktop sidebar draws Tabler's, so the
same workspace read differently on each surface. react-icons is DOM-only, and
pulling in @tabler/icons-react-native would ship its whole barrel through
Metro for one glyph, so the Tabler path is built with createLucideIcon and
keeps working with the Icon wrapper.

Co-Authored-By: Claude <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 0bb54314-189c-4318-854f-059818bcccec

📥 Commits

Reviewing files that changed from the base of the PR and between 2340152 and fc60777.

📒 Files selected for processing (6)
  • apps/mobile/screens/(authenticated)/(home)/filter/FilterScreen.tsx
  • apps/mobile/screens/(authenticated)/(home)/filter/scope/ScopeFilterScreen.tsx
  • apps/mobile/screens/(authenticated)/(home)/home/components/ScopeBar/ScopeBar.tsx
  • apps/mobile/screens/(authenticated)/components/CloudIcon/CloudIcon.tsx
  • apps/mobile/screens/(authenticated)/components/CloudIcon/index.ts
  • apps/mobile/screens/(authenticated)/workspace/[id]/components/CloudWorkspaceProvisioningState/CloudWorkspaceProvisioningState.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The mobile app adds a shared CloudIcon and replaces Lucide Cloud icons in cloud scope filters, the scope bar, and workspace provisioning.

Changes

Shared Cloud Icon

Layer / File(s) Summary
Define and export the shared icon
apps/mobile/screens/(authenticated)/components/CloudIcon/*
Defines CloudIcon with a cloud-shaped path and re-exports it from the components module.
Use the shared icon in authenticated screens
apps/mobile/screens/(authenticated)/(home)/filter/FilterScreen.tsx, apps/mobile/screens/(authenticated)/(home)/filter/scope/ScopeFilterScreen.tsx, apps/mobile/screens/(authenticated)/(home)/home/components/ScopeBar/ScopeBar.tsx, apps/mobile/screens/(authenticated)/workspace/[id]/components/CloudWorkspaceProvisioningState/CloudWorkspaceProvisioningState.tsx
Replaces the Lucide Cloud icon with CloudIcon in the scope accessory, Cloud row, cloud chip, and provisioning frame.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: kitenite

Merge Risk: ⚪ Minimal · up to fc607

The cloud icon change appears ready to merge; no actionable issue remains in the reviewed changes.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 6 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the mobile cloud glyph change and matches the primary purpose of the pull request.
Description check ✅ Passed The description explains the change, its rationale, affected screens, implementation choice, and testing status. It does not include the template's Checklist section or simulator verification, but the…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@expo

expo Bot commented Sep 25, 2026

Copy link
Copy Markdown

No installed development build can load this pull request as an update: its native fingerprint is 63273df0c28c and no development build has it. Add the mobile-build label to build one.

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

  • ✅ Neon database branch

Thank you for your contribution! 🎉

@saddlepaddle
saddlepaddle merged commit 4ddbeba into main Sep 25, 2026
22 checks passed
Kitenite added a commit that referenced this pull request Oct 1, 2026
* docs: weekly update for PRs merged 2026-09-23 to 2026-09-30

Source of truth: live Notion SOP "Weekly Docs Update (automation SOP)".
Window: merged:>=2026-09-23 (139 PRs). PRs through the morning of 09-23
were covered by #7771.

Changes
- Pages: no auto-open on publish (#7790); page links and URL links split
  into their own settings (#7916, #7962, #7946); Listening agents menu with
  per-row stop and Add listening agent (#7724, #7820, #7919); globe on the
  Share button (#7766); Report on public pages (#7886); agents offer a page
  (#7759). Files: pages.mdx, cli/cli-reference.mdx.
- Settings moves: Links replaced by Browser and Files & Editor (#7916,
  #7962). Files: editor.mdx, terminal-integration.mdx, customization.mdx.
- Editor: inline rename and drag to move (#7692), Auto Save (#7693, #7916),
  open and save files outside the workspace (#7897, #7982), Copy as Markdown
  (#7591), per-pane error screen (#7983). File: editor.mdx.
- Terminal copy follows Ghostty's whitespace rules (#7868).
  File: terminal-integration.mdx.
- Agents: UFO (#7898); GPT-6 Astra, Sonnet 5.5, retiring GPT-5.5, retired
  GPT-5.4/5.3 Codex (#7783, #7894, #7935). Files: agent-integration.mdx,
  cli/cli-reference.mdx.
- Host: superset start --daemon --auto-update and update-lock permission
  errors (#7735, #7952). Files: cli/host-server.mdx, cli/cli-reference.mdx.
- Removed the mcp CLI section and the Connected Service Plugins section:
  #7776 made plugins/mcp internal, the Plugins page is staff-flagged, and
  apps/docs/AGENTS.md keeps internal commands out. Files: skills.mdx,
  cli/cli-reference.mdx.
- Slack page unfurls and details panel (#7817, #7821, #7914, #7957).
  File: use-with-slack.mdx.
- Workspaces: instant creation with background naming (#7518); recoverable
  project deletion (#7896). File: workspaces.mdx.
- Shortcuts: prev/next workspace includes Pinned and wraps (#7851); ⌘B
  collapses the sidebar to a rail (#7964). File: keyboard-shortcuts.mdx.
- Ship controls and open-in button moved to the right sidebar strip (#7958).
  Files: diff-viewer.mdx, use-with-ide.mdx.

Deliberately skipped
- Cloud workspaces/environments/sandboxes (flag-gated, AGENTS.md rule):
  #7784 #7795 #7824 #7840 #7844 #7845 #7847 #7849 #7850 #7858 #7861 #7863
  #7874 #7911 #7913 #7918 #7922 #7931 #7932 #7937 #7956 #7961 #7969 #7981
  #7637 #7794 #7789 #7838 (its CLI docs already shipped in the PR).
- Staff-only plugins: #7912 Sentry plugin, #7716, #7727, #7955.
- Already documented in their own PRs: #7917, #7921.
- Removed feature never documented: #7796 Google Calendar triggers.
- Agents chip remove/revert/default-off, never documented: #7870 #7871 #7872.
- Billing/backend policy with no docs surface: #7947, #7812, #7786, #7792,
  #7798, #7761, #7948, #7949, #7951, #7827.
- Reverted security trio: #7828 #7829 #7830 (reverted by #7834).
- Fixes restoring expected behavior: #7683 #7696 #7707 #7743 #7751 #7756
  #7764 #7765 #7781 #7788 #7791 #7823 #7825 #7833 #7837 #7852 #7857 #7860
  #7864 #7865 #7869 #7873 #7897-covered #7903 #7938 #7980 #7943 #7964-chrome.
- Mobile (no docs page): #7746 #7747 #7748 #7749 #7750 #7782 #7793 #7810
  #7814 #7816 #7889 #7968.
- Marketing, internal docs, CI, version bumps: #7651 #7744 #7752 #7771 #7774
  #7776-infra #7777 #7785 #7811 #7818 #7822 #7826 #7834 #7884 #7885 #7895
  #7909 #7933 #7934 #7942 #7944 #7965 #7966.

Validation: bun run --cwd apps/docs typecheck, bun run lint:fix,
bun run lint (exit 0), Vale on 13 changed files (0 errors, 0 warnings),
git diff --check.

* chore: log weekly docs update follow-ups

* docs: tighten review findings in the weekly update

Only the page creator can stop or add listening agents. On focus change also
saves on window blur, and Auto Save pauses on conflicts. Taken-down pages do
not unfurl. Model picker coverage matches agent-models.ts.

This branch was previously deployed

1 inactive deployment
preview — fc607775 Deployed Sep 25, 2026 by saddlepaddle via Deploy Docs #10408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant