[only21mil]

Problem

Changing packages/shared/src/testing/providerEnv.ts skips tests for @t3tools/contracts, @t3tools/oxlint-plugin-t3code, @t3tools/secret-provider-core, @t3tools/task-cache, effect-acp, and effect-codex-app-server, although they load this shared setup file. It should select every package's tests.

Reproduce from the repo root in Bash:

node .github/scripts/ci-changes.cjs --paths /dev/stdin <<< 'packages/shared/src/testing/providerEnv.ts'

Before the fix, test_packages omits those six packages; afterward it is empty, meaning all packages covered by the Test job.

Change

Add providerEnv.ts to the existing run-all pattern beside longTempDir.ts, with a table test covering both setup files. Only the CI classifier and its regression test change.

Scope and approval

No issue or prior discussion. CONTRIBUTING allows: “A very small, focused fix for an obvious bug can be submitted without a prior issue or discussion.” This corrects a reproducible omission in the existing shared-setup rule; the scope is restoring that rule for this setup file.

Verification

• Before: vp test run scripts/check-changed.test.ts -t "shared test setup" — exit 1; providerEnv.ts fails with a partial package list, while longTempDir.ts passes.
• After: vp test run scripts/check-changed.test.ts — exit 0; all 9 tests pass.
• The repro above prints Runs everything: packages/shared/src/testing/providerEnv.ts, test=true, and test_packages=.
• vp run check:changed 15fe2832727893cbdd2214383f9f971474849695 — exit 0; format, lint, both knip passes, typecheck for 39 packages, and 10 tests across 2 files pass.

Not checked:

• CI, full test suites, builds, Rust, native lint, and release smoke; no branch was pushed.
• Unchanged .github/scripts/*.test.cjs suites.
• UI: only a CI script and its test change; no shipped client or server behavior changes, so no screen evidence applies.

Prior PRs

No same-fix PR found. This builds on Maria's (maria-rcks) CI classifier in #19587 and Theo Browne's shared environment setup in #22714.

Generated with Claude Opus 5.5 and GPT-6.1 Sol in T3 Code Nightly

[macroscopeapp]

Approvability

Verdict: Approved at b32bb07

Macroscope's review found this PR approvable — Changes to providerEnv.ts will now trigger all package tests and the existing run-all checks. This broadens verification without changing shipped behavior; the practical impact is additional CI work for that path.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 15fe283
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: dc9f893c-6def-4bcc-a5e2-d3ca048da502

Commits

Reviewing files that changed from the base of the PR and between 15fe283 and b32bb07.

Files selected for processing: 2

• .github/scripts/ci-changes.cjs
• scripts/check-changed.test.ts

Limit details: You’ve used all 10 included reviews currently available.

Walkthrough

The CI change selector now treats providerEnv.ts as an all-jobs change. Tests check that changes to either of two shared testing setup files produce an empty test_packages value.

Changes: Shared testing CI

Layer / File(s)	Summary
Classify shared testing setup changes .github/scripts/ci-changes.cjs, scripts/check-changed.test.ts	The all-jobs match includes providerEnv.ts. Parameterized tests check that changes to longTempDir.ts or providerEnv.ts produce an empty test_packages value.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested labels: bugfix, size:XS

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · up to b32bb

The classifier and covering tests align with the stated behavior, so the change is mergeable after normal checks.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main CI change: updates to providerEnv.ts now run every package's tests.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description check		The description includes all required sections: Problem, Change, Scope and approval, and Verification. It explains the bug, fix, focused tests, observed results, and checks that were not run. It also …

Full details: Description check

Explanation

The description includes all required sections: Problem, Change, Scope and approval, and Verification. It explains the bug, fix, focused tests, observed results, and checks that were not run. It also includes the agent model and harness information.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

re-verified exact head b32bb07f4ab5a73417f8d74b4f47762d622d8aa7 without code changes. this changes ci classification only; no shipped client or provider path invokes this script.

• reproduced the omission on current github/main at 955e2bfbb5c092c54ad795c8d379fec99702a6b5 in a separate worktree after vp i: node .github/scripts/ci-changes.cjs --paths /dev/stdin <<< packages/shared/src/testing/providerEnv.ts selects a partial package list.
• the same command on the exact pr head reports test=true, empty test_packages, and both test_web=true and test_server=true. the composite action passes these outputs to the workflow; empty TEST_PACKAGES runs every package covered by the Test job.
• neighboring paths checked on both revisions: longTempDir.ts and HostProcess.ts select all packages; contracts source remains scoped; docs select no jobs.
• blacksmith: vp i && vp test run scripts/check-changed.test.ts passed all 9 tests. the head has 29 successful checks, zero pending and zero failing.
• ran one dev server at a time. through repo Playwright and system Google Chrome, added the real git repository as a project, created a thread, selected codex gpt-6.1-sol, and submitted a real turn on main and the exact pr head. both returned provider smoke ok. the pr response survived reload and opening a new thread then returning to the completed thread. this is an adjacent app smoke check, not proof of ci selection.

classifier command transcript

Not verified

no synthetic providerEnv-only pr was pushed to trigger a fresh hosted ci matrix. verified the classifier cli and inspected its actual workflow consumer instead. native desktop, ios and android were not exercised on this linux vm. no ui behavior changed. the recording shows returning to the completed turn, not the provider wait. no timing or performance claim is made.