[saphid]

Problem

If you sign commits and have log.showSignature=true in your git config, files the agent commits during a turn drop out of that turn's changed files and diff.

listAuthoredPaths reads git log --format= --name-only -z output as a NUL-separated path list. With log.showSignature on, git prints the verification result before each commit's paths (No signature, or Good "git" signature for ...). The first path of every commit then arrives as "No signature\nkept.txt" rather than kept.txt. isGitImport doesn't find the real path in the authored set, so it treats the committed file as imported and filters it out of the turn.

Change

listPaths already overrides diff.relative for these reads (#28361). It now also passes -c log.showSignature=false. The override has no effect on the helper's git diff calls.

Scope and approval

This is a very small fix for an obvious bug, so it comes without an issue. A user git setting corrupts a path list that T3 parses, and the fix follows the same per-command override that #28361 added to this helper for diff.relative. It doesn't change product behavior or defaults.

Overlap check: no open or closed PR mentions log.showSignature or --no-show-signature for checkpoints. Open PRs #28168, #27370, #25880 and #23299 touch listAuthoredPaths for other reasons and don't change how its output is parsed.

Verification

• I extended the existing listAuthoredPaths tests in CheckpointStore.test.ts with one case. It makes a real commit signed by ssh-keygen between two checkpoint captures with log.showSignature=true. The test environment forces commit.gpgsign=false, so the case signs with commit -S.

  • On base: expected Set{ 'No signature\nkept.txt' } to deeply equal Set{ 'kept.txt' }
  • With the fix: vp test run src/checkpointing/CheckpointStore.test.ts passes 10/10.

• vp run check:changed passes (format, lint, knip, typecheck, 78 tests in 3 files).

• Runtime check with git 2.50.1, running the same arguments listPaths uses against a repo with an SSH-signed commit (\0 shown as |):

  base:      Good "git" signature for t@e.x with ED25519 key SHA256:…\nb.txt|
  candidate: b.txt|
  

Not checked: I didn't capture this in a real client turn. The defect and the fix are entirely in the server-side path query that feeds the turn's changed files. Other git log reads that feed commit and PR text generation have the same exposure to log.showSignature, but the symptom is different, so they're left out of this PR.

Reviewed with sol-loop: 1 round with GPT-6.1 Sol on high. Sol verdict: approved.

Created with Claude Opus 5.5 in Claude Code (T3 Code).

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at 6774e4f

Macroscope's review found this PR approvable — Keeps Git signature-verification text out of internal path lists so signed commits’ files remain visible in turn diffs. The override applies only to read-only commands and does not alter repository settings or signature trust policies.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 30654b3
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 34b73f20-494b-4083-bb57-3ae3d3bdcafe

Commits

Reviewing files that changed from the base of the PR and between 6774e4f and b2d2c7e.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 30654b3
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 341f8032-cfd1-4ed0-a3f4-71160aa1ee9b

Commits

Reviewing files that changed from the base of the PR and between 30654b3 and 6774e4f.

Files selected for processing: 2

• apps/server/src/checkpointing/CheckpointStore.test.ts
• apps/server/src/vcs/GitVcsDriver.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The path-list Git command now disables signature output. A regression test checks that listAuthoredPaths returns kept.txt for an SSH-signed commit when log.showSignature is enabled.

Changes: Signed commit path listing

Layer / File(s)	Summary
Signed commit path collection and regression test apps/server/src/vcs/GitVcsDriver.ts, apps/server/src/checkpointing/CheckpointStore.test.ts	The path-list Git command disables log.showSignature. The test verifies that listAuthoredPaths returns kept.txt for an SSH-signed commit.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: t3dotgg

Merge Risk: Minimal · previous review 6774e

No concrete merge-blocking risk remains; the signed-commit path-listing regression is addressed and covered by a focused test.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly identifies the server-side fix for signed commits when log.showSignature is enabled. It is specific to the main change, although the phrasing is slightly awkward.
Description check		The description includes all required sections: Problem, Change, Scope and approval, and Verification. It explains the failure, the implementation, the approval exemption, test results, runtime valida…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description includes all required sections: Problem, Change, Scope and approval, and Verification. It explains the failure, the implementation, the approval exemption, test results, runtime validation, and remaining limitations.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

verified unchanged head b2d2c7e1fe5cb3f518f7313efc5aefa6d225cc18 on linux using the dev web app, repo Playwright, /usr/bin/google-chrome, and real Codex gpt-6.1-sol turns. projects and files were created through the app and provider, without mocks or fixtures. only one dev server ran at a time.

• main 84537c4dd9: with log.showSignature=true, Codex created a valid SSH-signed commit adding kept.txt. its checkpoint had an empty file list, the reply had no changed-file card, and latest turn showed "No net changes in this selection."
• pr: the same prompt produced a valid SSH-signed commit. the reply showed kept.txt +1, and opening its turn diff rendered +signed checkpoint evidence.
• neighboring flows passed: uncommitted tracked and untracked edits showed both files; an unsigned commit with signature output disabled showed normal.txt; an unsigned commit with signature output enabled showed unsigned.txt.
• reopened the historical turn diffs after restarting with an explicit isolated home. a further real Codex turn confirmed signature output remained enabled, the signed commit verified, and the file contents persisted.
• Blacksmith: cd apps/server && vp test run src/checkpointing/CheckpointStore.test.ts src/checkpointing/CheckpointDiffQuery.test.ts passed 16/16. current GitHub CI checks pass. no code changes or pushes were needed.

before, main:

after, pr:

switching between signed, uncommitted, normal and unsigned turn diffs; animated capture (the original mp4 also passed playback and seeking checks):

short runtime transcript

Not verified

native desktop, iOS/Android, macOS/Windows, other providers, GPG signing, and relay/tunnel connections were not exercised. the real provider and browser checks used local linux and SSH signing.