[fixfon]

Problem

When a thread hits its usage limit, the toast says "Usage limit reached" but shows the blue question-mark icon from the "Input needed" toast (#24253). The thread's sidebar card shows the orange Limited indicator for the same thread, so the two don't match.

In ThreadNotificationCoordinator.tsx the title branch already handles limited, but the leadingIcon ternary only covers completion, approval and failed. limited falls through to the final else, which is MessageCircleQuestionIcon with text-info-foreground.

Change

The leadingIcon ternary gets a limited arm that renders CircleAlertIcon with text-warning. That is the icon and color the sidebar card uses for its Limited indicator (SidebarThreadRow.tsx). CircleAlertIcon was already imported, so the diff is two added lines. Other statuses, the toast copy and the toast behavior are unchanged.

Scope and approval

Fixes #24253. This is a small fix of an obvious visual bug: one missing branch in one component, two added lines in apps/web.

Verification

I checked it in the web dev app with system Chrome (headless, 1440×1000 at 2x), using a fake empty project. To get a limited thread without calling a provider, the page received two thread.updated shell-stream frames: first a running thread, then the same thread failed with lastErrorClass: usage_limit. Both frames were validated against the contracts schema.

• On main the toast icon is lucide-message-circle-question-mark text-info-foreground.
• With this change it is lucide-circle-alert size-4 text-warning, the same icon and color as the card's Limited indicator.

Before:

After:

The sidebar card's Limited indicator in the same session:

Checks:

• vp lint and vp fmt --check on the touched file pass.
• vp run --filter @t3tools/web typecheck exits 0.
• vp run check:changed: format, lint, knip and typecheck pass. Its test step picked up ThreadNotificationCoordinator.badge.browser.test.tsx and could not launch it because the Playwright browser isn't installed on my machine.
• Sidebar.logic.test.ts and ThreadStatusIndicators.test.ts pass (76 tests).

There's no unit test. The change is which glyph renders, and the only coordinator test is a browser test.

Not checked: the server path that produces usage_limit (only the client rendering was exercised), and the mobile app, which doesn't use this component.

Claude Sonnet 5.5 (xhigh) via T3 Code.

[macroscopeapp]

Approvability

Verdict: Approved at 00604b6

Macroscope's review found this PR approvable — This adds the missing Limited-status icon branch in the web toast coordinator, changing only the icon and color shown for usage-limit notifications. Existing notification behavior and all other status paths remain unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 50c1c5d
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 88506bd1-7fa6-40c1-ad22-341788f0d22c

Commits

Reviewing files that changed from the base of the PR and between fc87d7d and a9fef37.

Files selected for processing: 1

• apps/web/src/components/ThreadNotificationCoordinator.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

Walkthrough

The limited status branch in the thread notification coordinator now renders CircleAlertIcon with warning styling.

Changes: Limited-status notification

Layer / File(s)	Summary
Limited-status icon selection apps/web/src/components/ThreadNotificationCoordinator.tsx	The limited status branch now renders a warning-styled CircleAlertIcon before the failed-status branch.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested labels: bugfix

Suggested reviewers: akolenda

Merge Risk: Minimal · up to a9fef

The narrowly scoped icon change matches the existing Limited status presentation and is ready to merge.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title is concise, specific, and accurately describes the main change: fixing the web usage-limit toast icon.
Description check		The description includes all required sections. It explains the problem, implementation, scope and approval basis, verification steps, screenshots, passed checks, and unverified cases.
Linked Issues check		Issue #24253 requires the usage-limit toast to use the Limited status icon. The whole-PR summary reports a limited branch in ThreadNotificationCoordinator.tsx that renders CircleAlertIcon with `…
Out of Scope Changes check		The whole-PR summary reports two added lines in apps/web/src/components/ThreadNotificationCoordinator.tsx. The change affects only the icon selected for limited status and does not change other st…

Full details: Linked Issues check

Explanation

Issue #24253 requires the usage-limit toast to use the Limited status icon. The whole-PR summary reports a limited branch in ThreadNotificationCoordinator.tsx that renders CircleAlertIcon with text-warning, matching the sidebar indicator. The optional Limited label is not a required coding condition.

Full details: Out of Scope Changes check

Explanation

The whole-PR summary reports two added lines in apps/web/src/components/ThreadNotificationCoordinator.tsx. The change affects only the icon selected for limited status and does not change other statuses, toast copy, or toast behavior. The change directly addresses issue #24253.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

merged current main into the original branch, preserving @fixfon's commits. the diff against main remains exactly two added lines: limited toasts use the existing orange CircleAlertIcon. no notification behavior changed, and nothing from the original fix was dropped.

verification:

• github ci is green on 5109e2a2467249881c5e0d38761dadfb05ca64e4, including build/typecheck and web tests; github reports the branch mergeable.
• blacksmith vp run check:changed: format, lint, both knip passes, web/scripts typechecks, and 15 notification tests passed.
• focused sidebar, status indicator, and notification logic tests: 90 passed.
• system chrome against the running dev app: matching shell-stream data reproduces main's blue question mark and confirms the orange limited icon after the fix. the shell frames pass the contracts schema. "open thread" still navigates correctly; failed, approval, and input toasts retain their icons.
• two independent reviews approved 5109e2a2467249881c5e0d38761dadfb05ca64e4 with no findings.
• unverified: a live provider exhausting its allowance and native desktop/mobile execution. desktop shares this web component; mobile does not use it. the automatic bot rereview was rate-limited.

before, current main:

after, this branch:

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

verified the neighboring completion flow on Linux with repo Playwright and /usr/bin/google-chrome, using real Codex gpt-6.1-sol through this VM's local proxy. no mocks, fixtures, replay provider, injected shell events, or synthetic quota responses were used.

• started github/main (7c6446b81a18afdd3898e1359b401d6f9763fffa) in ../main after vp i, with empty isolated state. added a real git project through the app and enabled in-app notifications. real turns completed; the green completion toast appeared while another thread was selected, and "open thread" navigated correctly.
• stopped main's server using its captured startup PID, checked out this PR's exact head 5109e2a2467249881c5e0d38761dadfb05ca64e4, ran vp i, and started one background dev server with isolated state (web 5733, server 13773). created the project and threads through the app again.
• explicitly selected Codex gpt-6.1-sol, submitted git rev-parse --is-inside-work-tree with a request for the reply "provider verification complete", then selected another thread. the completion toast appeared; clicking "open thread" returned to the originating thread and its real provider reply. this checks completion icon selection and toast navigation next to the changed branch.
• blacksmith: 90 focused sidebar, status-indicator and notification logic tests passed. vp run check:changed f88b33a16de988f86782343b348631d11432ddf2 passed format, lint, both knip passes, affected typechecks and 15 tests including Chromium browser tests. the worker needed the PR's shallow parent history fetched and Playwright Chromium installed first.

runtime transcript:

03:19:23.234Z  submitted real Codex GPT-6.1-Sol turn
03:19:39.094Z  observed "Thread completed" on another thread
open thread   returned to the originating thread
reply         provider verification complete

these captures prove the neighboring completion flow, not a usage-limit notification:

Not verified

the changed usage-limit icon remains unverified end to end. real Codex turns succeeded on both main and this head; the proxy returned no quota or rate-limit failure. there is no accessible quota control on this VM. consequently i could not reproduce main's original blue question mark or capture matching before/after limited toasts without manufacturing provider behavior. earlier injected-event screenshots do not fill that gap. this pass is not a verification approval for the central change.

native desktop, iOS/Android, other providers, remote/tunnel connections, and dark-theme limited rendering were not exercised. desktop shares this web component; mobile has separate notification UI.

no source changes or pushes were made. no merge, close, rebase, force-push, or label changes.

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

applied the merge-review correction: the new limited arm in ThreadNotificationCoordinator.tsx now uses className="size-4 text-warning-foreground", matching the sidebar's limited styling. merged current main without conflicts and pushed a9fef37f8d29da026dde7b0783b9dd2108c79859 to the existing contributor branch without force. the diff against main remains two added lines.

blacksmith vp run check:changed 50c1c5dc536493826fc66e220598f38b831d5bde passed format, lint, both knip passes, affected web/scripts typechecks, 15 notification tests including browser coverage, and the focused react compiler check. three additional notification tests passed. two independent scoped reviews approved this exact head without findings. github reports no conflicts; ci is still finishing.

unverified: the actual provider usage-limit notification and matching before/after browser captures. local chrome attempts did not reach a usable paired app, and the available replay scenarios do not produce a usage-limit failure. no substitute screenshots are presented as integration proof. native desktop/mobile and remote/tunnel execution were not exercised. readiness remains waiting on ci and the required runtime evidence.

[fixfon]

Added before/after runtime evidence for the limited-status toast.

To trigger it without burning real quota, I pointed the Claude provider at a local stub that answers every request with a 429 rate_limit_error. The server classifies that as usage_limit, so the thread goes into the limited state and the toast fires. Both runs used an isolated home directory, no build, and the web app in headless Chrome.

Before (main 50c1c5dc53): the toast shows the blue question icon, which doesn't match the orange "Limited" badge in the sidebar.

After (this branch, a9fef37f8d29): the toast shows the orange alert icon, the same one the sidebar badge uses.

The toast text is the same in both runs; only the icon changes. The page behind the toast is different in the two screenshots because they come from separate runs, so you can ignore that part.