[yashranaway]

An existence filter on a wildcard path rejects a nonempty array of objects, such as an issue's labels. The filter discards objects before checking whether anything exists. This small bug fix checks existence before converting values for text comparisons, keeping null and missing values rejected.

The regression failed on main and passes with the fix. All 16 focused webhook filter and template tests pass on Linux, along with targeted lint and formatting checks.

[macroscopeapp]

Approvability

Verdict: Approved at 020ed54

Macroscope's review found this PR approvable — This is a narrowly scoped server bug fix that corrects exists matching for wildcard webhook values while preserving handling of missing and null values. Regression tests cover both the newly accepted object case and rejected null/missing cases.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: f98ff73
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 5c219c37-7cec-49cf-aed9-a6ae07635a96

Commits

Reviewing files that changed from the base of the PR and between 020ed54 and 1ae95d4.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review.

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 3b95e78
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 575ba38b-ea39-4185-9db9-8a8cb8268282

📥 Commits

Reviewing files that changed from the base of the PR and between 3b95e78 and 020ed54.

📒 Files selected for processing: 2

• apps/server/src/scheduledTasks/webhookFilter.test.ts
• apps/server/src/scheduledTasks/webhookFilter.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The wildcard-path exists filter now matches only when at least one resolved array element is neither null nor undefined. Tests cover matching and failing cases.

Changes: Wildcard exists filter

Layer / File(s)	Summary
Update and test wildcard exists behavior apps/server/src/scheduledTasks/webhookFilter.ts, apps/server/src/scheduledTasks/webhookFilter.test.ts	The filter checks wildcard-resolved arrays for a non-null, non-undefined element. Tests cover existing values, empty arrays, and cases where all resolved values are null or missing.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: Minimal · previous review 020ed

The wildcard existence behavior is covered by the reported focused tests, with no merge-blocking risk identified.

Pre-merge checks: 3 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Description check		The description explains the problem, change, and verification results. It does not provide the required scope and approval information or explain why this focused fix qualifies for an exemption.	Add Problem, Change, Scope and approval, and Verification sections. In Scope and approval, link the triaged issue or maintainer approval, or explain why this obvious bug fix qualifies without prior approval.

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the webhook existence-filter fix and follows the repository's conventional commit format.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches: 💡 1

🧪 Generate unit tests (beta)

• Create a new PR

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

merged current main into this branch, preserving yashranaway's implementation and regression coverage exactly. the two-line fix already handles existence before scalar conversion with no extra machinery, so no simplification was needed. the diff against main remains 24 added lines in two files.

scope and approval: this is the focused, obvious server bug fix accepted by contribution triage under policy cb9629e689. this supplies the eligibility context requested by the earlier description warning.

verification:

• reproduced the object-existence regression on main f98ff73a1d2b: 1 failed, 5 passed.
• blacksmith: all 67 filter, template, and webhook service tests passed with the fix.
• blacksmith: vp run check:changed passed formatting, lint, knip, graphql, affected typechecks, and focused tests.
• runtime JSON request checks accepted existing objects and matching scalar values, and rejected missing paths and matching notEquals values.
• two independent reviews approved head 1ae95d41ad8a6196a9983e35f3372dd260cf1b79 with no findings.

all 31 ci checks are green on this head. no unresolved inline findings remain; the latest bot run skipped unchanged implementation files.

unverified: full live http/provider dispatch. no ui change or browser evidence applies.

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

verified as-is at 1ae95d41ad8a6196a9983e35f3372dd260cf1b79 on a disposable linux vm. no code changes or pushes were needed.

installed dependencies and ran one real dev server at a time. used repository Playwright with /usr/bin/google-chrome to create a project pointing to a real git checkout, run Codex gpt-6.1-sol, and configure the webhook task through settings. no mocks, fixtures, or demo provider were used.

on github/main (80a2351fcb), body.issue.labels[] exists incorrectly filtered {"case":"object","issue":{"labels":[{"name":"bug"}]}}. after stopping main and starting the exact pr head, the same filter and payload were accepted, launched a thread, and completed with webhook object received. visible in the client.

neighboring runtime checks passed:

• empty arrays, null-only arrays, and missing paths were filtered.
• body.issue.labels[].name equals bug filtered feature, accepted bug, and completed a real codex turn.
• notEquals bug filtered an array containing both bug and feature.
• body.issues[].labels exists filtered all-null/missing values, accepted an existing empty array, and completed a real codex turn.

short http/provider transcript (all requests went to the running app):

main object:             HTTP 202, x-t3-hook-outcome=filtered; no turn
pr object:               HTTP 202, x-t3-hook-outcome=accepted; webhook object received.
pr empty/null/missing:   HTTP 202, x-t3-hook-outcome=filtered
pr scalar nonmatch:      HTTP 202, x-t3-hook-outcome=filtered
pr scalar match:         HTTP 202, x-t3-hook-outcome=accepted; webhook scalar-match received.
pr notEquals match:      HTTP 202, x-t3-hook-outcome=filtered
pr nested null/missing:  HTTP 202, x-t3-hook-outcome=filtered
pr nested empty array:   HTTP 202, x-t3-hook-outcome=accepted; webhook nested-empty-array received.

blacksmith: all 67 existing filter, template, and webhook service tests passed. the head also has 31 successful ci checks, zero pending, zero failing.

before, main rejects the object:

after, the pr runs the matching delivery:

short recording of delivery history and the completed codex thread; sampled screen capture, not a performance measurement:

Not verified

native ios/android clients, electron shell, macos/windows, other providers, and external webhook senders or T3 Connect relay delivery were not exercised. delivery here used direct local http against the real dev server. no change was needed, so check:changed was not rerun; the focused runtime checks and 67 tests above were run during this verification.