[only21mil]

Problem

Creating themes named 夜 and 朝 assigns both the ID custom-theme. After saving the first, entering the second offers to add a palette to the first theme. Saving drops the second name. Theme JSON without an explicit ID and VS Code imports share this function.

Change

Keep existing ASCII slugs. For a nonempty name whose slug is empty, generate a theme- ID with the existing FNV-1a hash convention, using the trimmed lowercase name. A name that keeps any ASCII letter or digit still uses its slug, so Dark 夜 and Dark 朝 both remain dark; that pre-existing slug limitation is unchanged. Reusing a name keeps its ID stable. Explicit stored IDs, including custom-theme, remain unchanged. No migration or dependency is needed.

Scope and approval

This is a small fix for an obvious collision in the existing naming workflow, under the focused-bug exception. No separate issue exists. The change covers one name-to-ID function and one regression test.

Prior PRs: #14499 by Oliver, flamboh, fixed reserved IDs for Dark+/Light+ imports and was merged. #10412 by Maria, maria-rcks, adds theme CSS and wallpaper and leaves this function unchanged. This PR reuses no code from either. Open/closed-PR searches found no earlier attempt at this same fix.

Verification

Base 05696c636e; candidate 5d2ec7d383. Checks ran on Linux with isolated app state and no provider session.

• The regression checks that 夜 and 朝 get different IDs and that 夜 keeps the ID of 夜. On the base it fails because both IDs equal custom-theme.
• Existing tests already cover the rest: ASCII slugs in vscodeThemeImport.test.ts, and explicit IDs, storage reload and duplicate rejection in themePalette.test.ts.
• vp test run apps/web/src/themePalette.test.ts apps/web/src/vscodeThemeImport.test.ts: 46 tests pass on the candidate.
• vp lint and vp fmt --check on the changed files pass. vp run --filter @t3tools/web typecheck passes.
• On 5056ddb696, which has the same source as the candidate and a longer version of the same test, both revisions build with VITE_HOSTED_APP_CHANNEL=nightly pnpm --filter @t3tools/web exec vp build --configLoader runner, pnpm --filter t3 run build:bundle, and pnpm --filter @t3tools/desktop exec vp pack.
• In production web and Electron on 5056ddb696, save dark theme 夜, then enter 朝. The base disables Dark and offers Add light palette. The candidate offers Create theme and saves both names. Both remain after web reload and Electron restart. Reusing 夜 still offers its missing light palette.

Not checked: macOS/Windows desktop, mobile, provider-backed conversations or a live VS Code import. Mobile has a separate implementation. Not changed: a name that still produces an ASCII slug keeps it, so Tokyo 夜 and Tokyo 朝 both still map to tokyo; changing that would alter IDs for existing accented names.

Web base: entering 朝 after saving 夜 offers Add light palette.

Web candidate: 朝 can be created separately; both themes remain after reload.

Electron base and candidate show the same before/after behavior. Both candidate themes remain after restarting the app.

Output of the ID function on the base and the candidate:

Generated with Claude Opus 5.5 and GPT-6.1 Sol in T3 Code Nightly

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: b5a226e
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: e82a4ee0-07f0-4e7d-89cf-c7ee771946e0

Commits

Reviewing files that changed from the base of the PR and between b5a226e and 5d2ec7d.

Files selected for processing: 2

• apps/web/src/themePalette.test.ts
• apps/web/src/themePalette.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

Walkthrough

The theme ID parser now creates deterministic IDs for nonempty names that produce no ASCII slug. Tests check distinct IDs for non-Latin names and confirm that surrounding whitespace does not change an ID.

Changes: Theme ID generation

Layer / File(s)	Summary
Generate and test theme IDs apps/web/src/themePalette.ts, apps/web/src/themePalette.test.ts	themeIdFromName uses a hash-based ID when a nonempty name produces no ASCII slug. Tests check distinct IDs for non-Latin names and consistent IDs when names have surrounding whitespace.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge, maria-rcks

Merge Risk: Minimal · up to 5d2ec

The change is mergeable with normal checks; no concrete regression remains identified.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: distinct stable IDs for non-Latin theme names. It uses the required conventional commit format.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description check		The description includes all required sections: Problem, Change, Scope and approval, and Verification. It explains the collision, implementation, focused-bug exception, regression coverage, test resul…

Full details: Description check

Explanation

The description includes all required sections: Problem, Change, Scope and approval, and Verification. It explains the collision, implementation, focused-bug exception, regression coverage, test results, build checks, observed web and Electron behavior, limitations, screenshots, and agent attribution.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

[macroscopeapp]

Approvability

Verdict: Approved at 5056ddb

Macroscope's review found this PR approvable — This is a small, self-contained fix for collisions when theme names produce no ASCII slug. Existing ASCII and explicit IDs remain unchanged, and the persistence and duplicate-detection behavior is covered by regression tests.

^{You can add or adjust custom eligibility rules. Learn more.}

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

verified as-is at 5056ddb696f7ab396fe0e0af18e0b93d43ba16fc on a disposable linux boat vm. no source changes or pushes.

• reproduced on github/main (6575ce3250), installed in a separate worktree: save dark theme 夜, then enter 朝. dark is disabled and the action incorrectly becomes Add light palette.
• checked out the exact contributor head, ran vp i, and started vp run dev in the background with isolated empty state. stopped main first. drove the actual web client with repository playwright and /usr/bin/google-chrome.
• the same flow offers Create theme; both names save independently and survive reload. persisted ids are theme-70lml7 and theme-6txfk8.
• neighboring behavior: 夜 finds the existing theme and adds its missing light palette without creating a duplicate. Ocean Night keeps ocean-night. both survive reload.
• pasted actual t3 theme json named 星 and vs code theme json named 月 through Add theme. both import independently and survive reload (theme-7dyujy, theme-3s1sxj).
• created the theme-verification git project through the app. selected codex gpt-6.1-sol and submitted a real turn through the composer. its two commands and final response rendered in the client:

$ pwd
/home/user/pr-23162-state/projects/theme-verification
$ git status --short
(no output)
assistant: theme verification ready.

• ran existing checks through blacksmith-check after installing dependencies in its worker: cd apps/web && vp test run src/themePalette.test.ts src/vscodeThemeImport.test.ts. 2 files, 46 tests passed. the pr head also reports 28 successful ci checks, none failing or pending.

matching editor crops, with 夜 already saved and 朝 entered:

inspected screenshots and played the uploaded 7.6-second recording to completion, including seeking, in the t3 browser.

Not verified

native ios/android, electron shell behavior, macos/windows, relay/tunnel connections, and external community-theme downloads were not exercised on this linux web-client pass. no claims about those paths. mixed ascii/non-latin names still use the existing ascii slug, as the pr explicitly intends. no source changes were needed, so no fix commit or check:changed run was required.