[nibarAhmed]

Fixes #26949

Problem

Since #23467, TalkBack on Android reads the thread composer as Add attachment → Model → Send → message field. Screen reader users reach Send before the field they're meant to type in. This happens in both the one-line and the expanded multi-line composer. Expected order: Add attachment → message field → Model → Send, the way it reads on screen.

To reproduce: turn on TalkBack on Android, open any thread, and swipe right through the composer from Add attachment.

Change

Android orders accessibility siblings by their position on screen, not by their order in the view tree. The compact editor was an absolutely positioned sibling of the whole controls row. The row starts at the left edge and the editor sits to its right, so Android read the entire row (attach, model, Send) before the editor. That's also why the fix proposed in #26949 (render the editor earlier in the tree) didn't change the order on a real device.

The editor now renders inside that row, right after the placeholder slot it is positioned over, so it sorts between the attach button and the trailing controls. Its styles are unchanged, and its new parent has the same size and origin as the old one, so it lays out in the same place. Almost all of the diff is that block moving and being re-indented. React Native's experimental_accessibilityOrder would also fix this, but it is flag-gated off in our React Native version.

One small side effect: when dictation ends, the field now flips back in with the toolbar instead of popping in, as it did before #23467. I couldn't find anything in #23467 suggesting the pop-in was intended; it looks like a side effect of moving the field out of the flipping container. If it was intended, say so and I'll keep it. Starting dictation is unchanged.

Scope and approval

Reported in #26949 (not triaged yet). This is a small, focused fix for an obvious regression: one component (apps/mobile/src/features/threads/ThreadComposer.tsx) and one moved block, which restores the reading order the composer had before #23467. It doesn't change any product behavior beyond the reading order and the side effect above.

Verification

TalkBack on a Samsung phone (Android 17): I swiped through the composer with nightly (before) and with this branch installed as a separate dev app (after).

• Before: Add attachment → Model → Send → field
• After: Add attachment → field → Model → Send

Before (nightly):

after-fix-talkback.mp4

After (this branch):

before-nightly-talkback.mp4

Android emulator (Android 16), accessibility tree order on this branch:

Composer state	Order
Compact, empty	Add attachment → field → Model → Send
Expanded, multi-line draft	field → Add attachment → Model → Send
With an image attached	field → Add attachment → image → Model → Send

Tapping the field opens the keyboard, and the composer sits just above it.

Compact, before tap	Keyboard open	Expanded, multi-line	With an image

Dictation ending (Android emulator, dictation force-enabled locally): dictation only exists on iOS, because Android has no transcriber. To see the animation, I temporarily made Android report a transcriber (not committed). The dev build can't record, so dictation ends on its microphone error; dismissing that error is the same switch back to the field. Recorded on main and on this branch, slowed down 4x:

dictation-end-slowmo.mp4

• Before: the field appears at once, drawn over the error text while the toolbar is still flipping.
• After: the field rotates in with the toolbar.
• Starting dictation looks the same on both: the field disappears at once, then the toolbar flips.

Large text (Android emulator): at font scale 2.0 (the largest Android offers) and 3.2, the buttons keep a fixed size and never overlap the field, on main or on this branch. The composer's pixels are identical on both at 3.2, so taps are unaffected.

vp run check:changed passes.

Not checked:

• iOS / VoiceOver (no iOS device available)
• Real dictation. It hasn't been tested because no iOS device is available; the dictation check above is the Android stand-in.

Done with Claude Opus 5.5 in Claude Code, running in T3 Code.

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at 9a32d19

Macroscope's review found this PR approvable — Moves the mobile message editor before Send in the component hierarchy to improve TalkBack reading order. Message handling and submission safeguards are unchanged, keeping the change limited to presentation.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: d92c437
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 4e983e0a-e751-4748-99b0-20ab2a3b80f0

Commits

Reviewing files that changed from the base of the PR and between 9a32d19 and 2b70791.

Files selected for processing: 1

• apps/mobile/src/features/threads/ThreadComposer.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

Walkthrough

The composer editor moved into the compact composer row before the controls. Its existing draft editing, paste handling, navigation, and submission wiring remain.

Changes: Composer editor ordering

Layer / File(s)	Summary
Place editor before controls apps/mobile/src/features/threads/ThreadComposer.tsx	The editor now renders inside the compact row before the controls and receives the composer’s hidden prop. The former editor placement after the row was removed. Its existing handlers remain.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: juliusmarminge, maria-rcks

Merge Risk: Minimal · up to 2b707

No merge-blocking issue is established for the composer change.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title clearly identifies the mobile accessibility fix and matches the main change: TalkBack now reads the message field before Send.
Description check		The description includes all required sections: Problem, Change, Scope and approval, and Verification. It explains the regression, implementation, scope, Android test results, visual evidence, side ef…
Linked Issues check		[#26949] requires TalkBack order: attach, message field, model, Send. The whole-PR diff (mergeBase d92c437 to head 2b70791) moves the compact ComposerEditor block into the controls row. The block no…
Out of Scope Changes check		The whole-PR diff for apps/mobile/src/features/threads/ThreadComposer.tsx (+137/-134) moves the existing ComposerEditor block. It adds a single explanatory comment about TalkBack sibling ordering.…

Full details: Description check

Explanation

The description includes all required sections: Problem, Change, Scope and approval, and Verification. It explains the regression, implementation, scope, Android test results, visual evidence, side effect, and untested iOS and real-dictation cases.

Full details: Linked Issues check

Explanation

[#26949] requires TalkBack order: attach, message field, model, Send. The whole-PR diff (mergeBase d92c437 to head 2b70791) moves the compact ComposerEditor block into the controls row. The block now follows the placeholder Animated.View and precedes the attachment strip and trailing controls. It sits inside ComposerDictationDraftContent. Its props and compactEditor.editorStyle are unchanged. This placement matches the required reading order. The PR reports TalkBack and emulator accessibility-tree results for compact, expanded, and attachment states, and reports that tapping the field opens the keyboard. I did not reproduce these runtime results. The reported Samsung TalkBack order and emulator tree order are author evidence. The vp run check:changed result is also author evidence. The issue's optional proposed steps (placeholder pointerEvents="none", box-none wrapper) are not in the diff. They are implementation suggestions, not stated requirements, and the required behavior is reported as met. The issue also says the fix should not change visuals. The PR discloses one visual difference: the field now flips in with the toolbar when dictation ends. This is a side effect of the required move and does not block the reading-order requirement. No unmet coding requirement is shown.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff for apps/mobile/src/features/threads/ThreadComposer.tsx (+137/-134) moves the existing ComposerEditor block. It adds a single explanatory comment about TalkBack sibling ordering. The raw summary and PR description both list this as the only changed component. I did not diff other paths separately, because the file list was truncated. No unrelated product logic or unrelated files appear in the evidence. The dictation-end transition change is a disclosed side effect of moving the editor out of the flipping container. It is not an unrelated change. Starting dictation is unchanged, per the PR. The diff does not show an unrelated behavior change.

Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

merged current main (d92c437baa19) into the existing branch without rewriting contributor history. head: 2b70791e5df23ed49efc6c8d325e0f959a9e5f98.

kept the original implementation intact: one editor block moves into the controls row, with its talkback rationale. the editor's props, handlers, and styles match main after ignoring whitespace. no extraction or extra accessibility machinery was needed. the original dictation return-animation side effect remains disclosed in the description.

verification:

• blacksmith vp run check:changed d92c437baa19409f99416a44f748f148f4317c65 passed format, lint, knip, affected typechecks, and react compiler checks.
• existing compactEditorInsets.test.ts: 2 tests passed through blacksmith.
• two independent source reviews approved this exact head with no findings.
• replayed and inspected the original samsung recordings, including playback and seeking after upload. these are contributor evidence from the original revision, not new captures of the merged head.
• fresh native talkback, expanded-editor taps, font scaling, ios/voiceover, and real dictation remain unverified here: device access is disabled. chrome cannot validate android native traversal. no new main/head native screenshots were captured.

original samsung before:

original samsung after:

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

no changed behavior could be verified in this linux vm. this run is unverifiable, not a runtime pass.

inspected the description, discussion, commits, and diff at head 2b70791e5df23ed49efc6c8d325e0f959a9e5f98. the only changed file is the native mobile ThreadComposer.tsx: the editor moves inside the controls row to change android talkback traversal. the pr is open. git.cafe reports 29 successful checks, zero failing, zero pending; those checks do not prove native accessibility behavior.

runtime prerequisite transcript:

adb devices -l
List of devices attached
(no devices)

device_list
Agent device access is turned off for this environment.

Not verified

• original talkback traversal on main and corrected traversal on this head, in compact and expanded composer states.
• native keyboard focus, typing, attachments, model selection, send, and real codex gpt-6.1-sol turns through the changed mobile composer.
• ios voiceover and the dictation return animation.

.agents/skills/test-t3-mobile/SKILL.md requires: "If T3 device tools or the selected device are unavailable, report the blocker and stop verification. Do not install or switch to another automation system."

device access is disabled, so verification stopped at that prerequisite. no main/pr dev servers were started, no app data or provider turns were created, no code was changed, and no fresh screenshots or recordings were captured. browser mobile emulation would exercise a different composer and cannot prove android talkback traversal. completion requires an enabled android device host with talkback, followed by matching main/head runs and the neighboring native interactions above.