Merge main by shuyama1 · Pull Request #8418 · GoogleCloudPlatform/magic-modules

shuyama1 · 2023-07-21T16:26:48Z

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

* Allow property to work for monitoring monitored project * Change display name * Move handling of long form to encoder * Add error retry predicate * Add a pre-read * Retry all 403 errors

* Generate DCL test files to the service packages * Replace function calls

Co-authored-by: Edward Sun <sunedward@google.com>

This reverts commit c6ecf9c.

* Add Update Connetor Support for VPC Access Connectors * fix lint * fix go lint * fix tests

#8310) Co-authored-by: Cameron Thornton <camthornton@google.com>

* adding in enableConfidentialCompute for Hyper disk * added in min_version * Adding in enableConfidentialCompute field for Hyperdisk * Adding in Test

There's no actual validation changes here; this is really just a documentation/testing update.

Signed-off-by: toVersus <toversus2357@gmail.com>

* Update resource_bigtable_instance.go * Update bigtable_instance.html.markdown

Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: Efe Elaiho <efeelaiho@google.com> Co-authored-by: efeelaiho <efeelaiho15@utexas.edu>

Co-authored-by: Edward Sun <sunedward@google.com>

* Normalize name field * Fix import * Support previous import id * Also shorten name in encoder * Add long form test * Add upgrade state function

* add json and parquet option to bq table * fmt * fmt

* Changed order of updates for min_cpu_platform and machine_type Resolved hashicorp/terraform-provider-google#14945 * Added allow_stopping_for_update = true * Added allow_stopping_for_update to ImportStateVerifyIgnore * Added diff suppress and clarified how to 'unset' the field

Resolved hashicorp/terraform-provider-google#14976

…#8337) * Properly handle ABP midnight (hours = 0) * Add ExpectNonEmptyPlan to test * Simplify custom flatten

Also updated information re: response time and linked to helpful guides on the docsite

…/DCL services (#8344) * Add tool to generate services.kt file that contains mmv1 and tpgtools/DCL services * Fix log function call * Correct indentation size in service map output * Call teamcity Make target when generating TPG/TPGB * Add commas to generated map string * test change * update test * remove test file --------- Co-authored-by: Shuya Ma <shuyama@google.com>

* Fixed alloydb cluster and instance sweeping Resolved hashicorp/terraform-provider-google#15215 * Fixed imports in sweeper

…ated root in the whole project. (#8394) * Stop creating new VCS Root, instead use manually-created root made to create original TeamCity/GitHub connection * Remove vcs_root.erb

…se. (#8401)

This reverts commit a3e513f.

Add `tpgresource.DurationDiffSuppress` to min / max backoff Fixes https://github.com/hashicorp/terraform-provider-google/issues/15166x

* Adding Support For resilience_mode field * Adding new field RESILIENCE_MODE_UNSPECIFIED * Added RESILIENCE_MODE_UNSPECIFIED in the docs * Removing the resilience mode test as the API is not yet launched * Adding test for high resilience and adding mapping * Fixing docs and flatten logic * Fixing expand method * Fixing flatten to accept empty Resilience_mode field --------- Co-authored-by: Khaled Hassan <hkhaled@google.com>

* Fixed tf-test prefixes for compute addresses * Reverted unused example changes * Reverted unnecessary change

* adding security_policy field in regionBackendService resource * fixing code review to use http calls instead of lib in RegionBackendService * removing ParseSecurityPolicyRegionalFieldValue method * fixing lint issue

* tgc build on tpg-beta * gcb-push-downstream.yml change ga to beta for tgc * fix forward rule test file * Address comment * compute forwarding rule test file set to beta * switch tgc-base to use beta * tgc make always use beta * generate downstream always use beta for tgc --------- Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>

Co-authored-by: Riley Karson <rileykarson@google.com>

* Add optional_components to documentation * Fix formatting, remove redundant optional * Clean up properties documentation * Apply suggestions from code review Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Add asterisks --------- Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Add comments, link to TeamCity Kotlin DSL docs * Change default value of environment from "public" to "default" This is because Google provider has no public TeamCity resources * Enable different default cron values for `ga`/`beta` downstreams * Enable non-default cron values to be used, based on value of `environment` parameter in TeamCity * Add ability to make VCS root and nightly trigger use non-main branch * Update tests to reflect how entrypoint func requires `branch` parameter now * Update `MAJOR_RELEASE_TESTING` value, and update code to handle unsupported chars * Update `uniqueID` method to uppercase the environment value

* fix enforce_on_key_configs * add updatemask --------- Co-authored-by: Edward Sun <sunedward@google.com>

google-cla · 2023-07-21T16:27:12Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

trodge and others added 30 commits July 12, 2023 15:13

Monitoring monitored project (#8322)

722fb20

* Allow property to work for monitoring monitored project * Change display name * Move handling of long form to encoder * Add error retry predicate * Add a pre-read * Retry all 403 errors

Add making a breaking change guide (#8326)

e3ebcc3

Fix tpg-transport unit tests for local runs (#8325)

e4325d9

Add support for complexDataTypeReferenceParsing in FHIR Stores (#8316)

860d734

Add provider packages to the teamcity (#8330)

49f36b3

Generate DCL tests to service packages (#8257)

c6ecf9c

* Generate DCL test files to the service packages * Replace function calls

feat: add bigtable change stream retention documentation (#8335)

214a377

increase max_sizes for EdgeCacheService (#8333)

2604552

Co-authored-by: Edward Sun <sunedward@google.com>

Revert "Generate DCL tests to service packages (#8257)" (#8340)

a3e513f

This reverts commit c6ecf9c.

Add Update Connector Support for VPC Access Connectors (#8205)

85ff1c2

* Add Update Connetor Support for VPC Access Connectors * fix lint * fix go lint * fix tests

Update TF registry docs to have user_labels nested under settings and… (

bce8215

#8310) Co-authored-by: Cameron Thornton <camthornton@google.com>

Adding enableConfidentialCompute field for Hyperdisk (#8324)

5b6cfe3

* adding in enableConfidentialCompute for Hyper disk * added in min_version * Adding in enableConfidentialCompute field for Hyperdisk * Adding in Test

Support named databases for Firestore (#8341)

ad99390

There's no actual validation changes here; this is really just a documentation/testing update.

feat(google_container_node_pool): support gpu driver version (#8348)

1a6fb11

Signed-off-by: toVersus <toversus2357@gmail.com>

Num nodess doc update (#8358)

180a20c

* Update resource_bigtable_instance.go * Update bigtable_instance.html.markdown

Add support for creating Apigee Organization without VPC peering (#8317)

7cac461

add most_recent option to google_compute_image datasource (#8309)

1905ea9

Add Looker product and Instance resource support (#8110)

e449971

Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: Efe Elaiho <efeelaiho@google.com> Co-authored-by: efeelaiho <efeelaiho15@utexas.edu>

Add mutex to google_tags_location_tag_binding (#8329)

7a7bab5

Co-authored-by: Edward Sun <sunedward@google.com>

Normalize name field (#8360)

a779650

* Normalize name field * Fix import * Support previous import id * Also shorten name in encoder * Add long form test * Add upgrade state function

bigquery table - add json and parquet options (#8296)

35bbe5e

* add json and parquet option to bq table * fmt * fmt

Modify the doc for google_compute_resource_policy (#8339)

39202d4

gkebackup backupplan: Add State and StateReason fields (#8227)

b08129e

fix: Update workflow_basic.tf.erb (#8369)

75f76bc

Made unused async fields optional (#8331)

8be40a0

Resolved hashicorp/terraform-provider-google#14976

breaking-change file name changed (#8375)

f98df39

Simplify network reference in AlloyDB examples (#8367)

5f586e1

Properly handle AutomatedBackupPolicy midnight start time (hours = 0) (…

d2ca0e1

…#8337) * Properly handle ABP midnight (hours = 0) * Add ExpectNonEmptyPlan to test * Simplify custom flatten

Shortened reviewer assignment comment (#8380)

a04bb05

Also updated information re: response time and linked to helpful guides on the docsite

SarahFrench and others added 22 commits July 19, 2023 17:09

Terraform Support for Dataplex Tasks. (#8124)

d70fc72

feature branches (#8298)

4713a03

Fixed alloydb cluster and instance sweeping (#8374)

229c367

* Fixed alloydb cluster and instance sweeping Resolved hashicorp/terraform-provider-google#15215 * Fixed imports in sweeper

Subnetnetwork: replaced ipv6CidrRange with internalIpV6Prefix (#8370)

6e28038

Stop creating new, second VCS Root. Instead use a single manually-cre…

4d20213

…ated root in the whole project. (#8394) * Stop creating new VCS Root, instead use manually-created root made to create original TeamCity/GitHub connection * Remove vcs_root.erb

fix CI for feature branches (#8397)

e357f74

Added note about resource id prefixes for tests to review-pr doc (#8399)

0040570

Added a not that failover_target is not supported for Postgres Databa…

23f0024

…se. (#8401)

Generate DCL tests to service packages (#8349)

353dbb9

This reverts commit a3e513f.

cloud_tasks_queue: supress permadiffs on backoff settings (#8359)

c9cc162

Add `tpgresource.DurationDiffSuppress` to min / max backoff Fixes https://github.com/hashicorp/terraform-provider-google/issues/15166x

Fix issue labeler to use service/ prefix instead of services/ (#8403)

8202745

Parallelize mmv1 build time (#8381)

eadb7f1

Fixed tf-test prefixes for compute addresses (#8398)

c5aa608

* Fixed tf-test prefixes for compute addresses * Reverted unused example changes * Reverted unnecessary change

Fix documentation formatting (#8365)

37c93c6

added contributing to 5.0.0 section (#8404)

4379e91

Co-authored-by: Riley Karson <rileykarson@google.com>

fix enforce_on_key_configs (#8165)

bea9ac7

* fix enforce_on_key_configs * add updatemask --------- Co-authored-by: Edward Sun <sunedward@google.com>

shuyama1 changed the title ~~Added a not that failover_target is not supported for Postgres Databa…~~ Merge main Jul 21, 2023

shuyama1 closed this Jul 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Merge main#8418

Merge main#8418
shuyama1 wants to merge 52 commits into
FEATURE-BRANCH-test-script-masterfrom
main

shuyama1 commented Jul 21, 2023 •

edited

Loading

Uh oh!

google-cla Bot commented Jul 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

shuyama1 commented Jul 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-cla Bot commented Jul 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

shuyama1 commented Jul 21, 2023 •

edited

Loading