Skip to content

fix CI for feature branches#8397

Merged
shuyama1 merged 2 commits into
GoogleCloudPlatform:mainfrom
shuyama1:fix_fb
Jul 19, 2023
Merged

fix CI for feature branches#8397
shuyama1 merged 2 commits into
GoogleCloudPlatform:mainfrom
shuyama1:fix_fb

Conversation

@shuyama1

Copy link
Copy Markdown
Member

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@shuyama1 shuyama1 requested a review from melinath July 19, 2023 19:51
mkdir -p "$(dirname $LOCAL_PATH)"

echo "BASE_BRANCH: $BASE_BRANCH"
git clone $GITHUB_PATH $LOCAL_PATH --branch $BASE_BRANCH

@melinath melinath Jul 19, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than making this change - should this be cloning the $UPSTREAM_BRANCH instead? Since I think UPSTREAM_BRANCH is the base branch in the downstream (confusingly - possibly we should rename the variable)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, using $UPSTREAM_BRANCH should be working fine. I'll make the change

confusingly - possibly we should rename the variable

we do have a mix in use of the terms "upstream" and "downstream" when referring those generated repos. We should standardize them at some point, but probably not in this PR.

@shuyama1 shuyama1 merged commit e357f74 into GoogleCloudPlatform:main Jul 19, 2023
@shuyama1 shuyama1 deleted the fix_fb branch July 19, 2023 22:09
melinath pushed a commit that referenced this pull request Jul 20, 2023
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
wj-chen pushed a commit to wj-chen/magic-modules that referenced this pull request Aug 1, 2023
DanielRieske pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 2, 2023
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants