fix CI for feature branches#8397
Merged
Merged
Conversation
melinath
requested changes
Jul 19, 2023
| mkdir -p "$(dirname $LOCAL_PATH)" | ||
|
|
||
| echo "BASE_BRANCH: $BASE_BRANCH" | ||
| git clone $GITHUB_PATH $LOCAL_PATH --branch $BASE_BRANCH |
Member
There was a problem hiding this comment.
rather than making this change - should this be cloning the $UPSTREAM_BRANCH instead? Since I think UPSTREAM_BRANCH is the base branch in the downstream (confusingly - possibly we should rename the variable)
Member
Author
There was a problem hiding this comment.
Yeah, using $UPSTREAM_BRANCH should be working fine. I'll make the change
confusingly - possibly we should rename the variable
we do have a mix in use of the terms "upstream" and "downstream" when referring those generated repos. We should standardize them at some point, but probably not in this PR.
melinath
approved these changes
Jul 19, 2023
melinath
pushed a commit
that referenced
this pull request
Jul 20, 2023
ericayyliu
pushed a commit
to ericayyliu/magic-modules
that referenced
this pull request
Jul 26, 2023
wj-chen
pushed a commit
to wj-chen/magic-modules
that referenced
this pull request
Aug 1, 2023
DanielRieske
pushed a commit
to bschaatsbergen/magic-modules
that referenced
this pull request
Aug 2, 2023
hao-nan-li
pushed a commit
to hao-nan-li/magic-modules
that referenced
this pull request
Aug 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)