Update TF registry docs to have user_labels nested under settings and…#8310
Conversation
… not settings.advanced_machine_features
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @c2thorn, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
|
I signed the CLA but unsure how to re-trigger that job 😓 |
I have to give approval, should be running now. Also, I went ahead and edited the release note. Documentation-only changes don't need a note |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 2 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules |
|
|
|
Apologies for the miscommunication, I went ahead and committed what I was trying to convey. I'll merge after our CI runs one last time! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 4 insertions(+), 4 deletions(-)) |
GoogleCloudPlatform#8310) Co-authored-by: Cameron Thornton <camthornton@google.com>
GoogleCloudPlatform#8310) Co-authored-by: Cameron Thornton <camthornton@google.com>
GoogleCloudPlatform#8310) Co-authored-by: Cameron Thornton <camthornton@google.com>
GoogleCloudPlatform#8310) Co-authored-by: Cameron Thornton <camthornton@google.com>
… not settings.advanced_machine_features
I was getting the following failure originally:
Until I looked through the JSON API spec and realized it's supposed to only be nested under settings (same level as tier).
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)