fix enforce_on_key_configs

[edwardmedia]

Fixes hashicorp/terraform-provider-google#14905

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: fixed wrongly trigger recreation on changes of `enforce_on_key_configs` on `google_compute_security_policy`

[modular-magician]

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @SarahFrench, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

---

Your assigned reviewer will help review your code by:

• Ensuring it's backwards compatible, covers common error cases, etc.
• Summarizing the change into a user-facing changelog note.
• Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

---

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform Beta: Diff ( 1 file changed, 1 deletion(-))

[SarahFrench]

Note for myself after the acceptance tests complete: rules in this policy resource are updated through add/delete actions because the resource is handwritten and uses a client library. The underlying API allows patches of the policy, patches of specific rules inside the policy, and imperative methods like addRule and removeRule.

Given this info, it definitely doesn't make sense for ForceNew to be there as individual rules can be deleted from the policy without issue and the API doesn't describe special behaviour for this field.

[modular-magician]

Tests analytics

Total tests: 2794
Passed tests 2490
Skipped tests: 301
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeSecurityPolicy_EnforceOnKeyUpdates|TestAccComputeNetworkEndpoints_networkEndpointsBasic|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

[modular-magician]

Tests passed during RECORDING mode:
TestAccComputeNetworkEndpoints_networkEndpointsBasic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeSecurityPolicy_EnforceOnKeyUpdates[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[SarahFrench]

Looks like the ForceNew for this field may have been masking an issue in an acceptance test?

The errors above say:

Error 400: Invalid value for field 'resource.rateLimitOptions.enforceOnKeyConfigs': ''. Only one of enforceOnKey and enforceOnKeyConfigs can be specified., invalid

Here's the relevant part of API docs that confirms this.

Maybe we should remove these lines from the acceptance tests:

• magic-modules/mmv1/third_party/terraform/tests/resource_compute_security_policy_test.go.erb

  Line 1329 in 308e362

  enforce_on_key = ""

• magic-modules/mmv1/third_party/terraform/tests/resource_compute_security_policy_test.go.erb

  Line 1375 in 308e362

  enforce_on_key = ""

Edit: and also make these fields mutually exclusive in the schema too?

[edwardmedia]

This PR is put on hold as the api can't be reset between enforceOnKeyConfigs and enforceOnKey. Although only one of them is provided for the update, below error is still bing hit

Invalid value for field 'resource.rateLimitOptions.enforceOnKeyConfigs': ''. Only one of enforceOnKey and enforceOnKeyConfigs can be specified.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 75 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2860
Passed tests 2554
Skipped tests: 299
Affected tests: 7

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeSecurityPolicy_update|TestAccComputeSecurityPolicy_withPreconfiguredWafConfig|TestAccComputeSecurityPolicy_withRedirectOptionsUpdate|TestAccComputeSecurityPolicy_EnforceOnKeyUpdates|TestAccComputeSecurityPolicy_withHeadAction|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeSecurityPolicy_update[Debug log]
TestAccComputeSecurityPolicy_withPreconfiguredWafConfig[Debug log]
TestAccComputeSecurityPolicy_withRedirectOptionsUpdate[Debug log]
TestAccComputeSecurityPolicy_EnforceOnKeyUpdates[Debug log]
TestAccComputeSecurityPolicy_withHeadAction[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[SarahFrench]

Sorry for the wait - looks good to me