Skip to content

Fixed tf-test prefixes for compute addresses#8398

Merged
melinath merged 3 commits into
mainfrom
static-ip-address-quota
Jul 20, 2023
Merged

Fixed tf-test prefixes for compute addresses#8398
melinath merged 3 commits into
mainfrom
static-ip-address-quota

Conversation

@melinath

Copy link
Copy Markdown
Member

Release Note Template for Downstream PRs (will be copied)


@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 22 insertions(+), 22 deletions(-))
Terraform Beta: Diff ( 13 files changed, 25 insertions(+), 25 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2871
Passed tests 2562
Skipped tests: 299
Affected tests: 10

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccServiceNetworkingPeeredDNSDomain_basic|TestAccSecurityScannerScanConfig_scanConfigUpdate|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeRouterNat_withPortAllocationMethods|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccComputeForwardingRule_ip|TestAccCloudIdsEndpoint_basic|TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccComputeFirewallPolicyRule_multipleRules|TestAccDataSourceComputeAddresses

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccServiceNetworkingPeeredDNSDomain_basic[Debug log]
TestAccSecurityScannerScanConfig_scanConfigUpdate[Debug log]
TestAccComputeRouterNat_withPortAllocationMethods[Debug log]
TestAccComputeRouterNat_withManualIpAndSubnetConfiguration[Debug log]
TestAccComputeForwardingRule_ip[Debug log]
TestAccCloudIdsEndpoint_basic[Debug log]
TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccDataSourceComputeAddresses[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@melinath
melinath requested review from a team and shuyama1 and removed request for a team July 20, 2023 15:36
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 10 files changed, 20 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 12 files changed, 23 insertions(+), 23 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2871
Passed tests 2570
Skipped tests: 299
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@melinath
melinath merged commit c5aa608 into main Jul 20, 2023
@melinath
melinath deleted the static-ip-address-quota branch July 20, 2023 21:03
melinath added a commit that referenced this pull request Jul 20, 2023
* Fixed tf-test prefixes for compute addresses

* Reverted unused example changes

* Reverted unnecessary change
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
* Fixed tf-test prefixes for compute addresses

* Reverted unused example changes

* Reverted unnecessary change
NickElliot pushed a commit to NickElliot/magic-modules that referenced this pull request Jul 31, 2023
* Fixed tf-test prefixes for compute addresses

* Reverted unused example changes

* Reverted unnecessary change
DanielRieske pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 2, 2023
* Fixed tf-test prefixes for compute addresses

* Reverted unused example changes

* Reverted unnecessary change
shuyama1 pushed a commit that referenced this pull request Aug 3, 2023
* Fixed tf-test prefixes for compute addresses

* Reverted unused example changes

* Reverted unnecessary change
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Aug 9, 2023
* Fixed tf-test prefixes for compute addresses

* Reverted unused example changes

* Reverted unnecessary change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants