Add Looker product and Instance resource support by kppk · Pull Request #8110 · GoogleCloudPlatform/magic-modules

kppk · 2023-06-07T21:43:19Z

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_looker_instance`

…ioning

modular-magician · 2023-06-07T21:43:43Z

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @rileykarson, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

Ensuring it's backwards compatible, covers common error cases, etc.
Summarizing the change into a user-facing changelog note.
Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician · 2023-06-07T22:25:54Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 11 files changed, 2590 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 11 files changed, 2590 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 5 files changed, 528 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 259 insertions(+))

modular-magician · 2023-06-07T23:30:38Z

Tests analytics

Total tests: 2783
Passed tests 2483
Skipped tests: 292
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLookerInstance_lookerInstanceFullExample|TestAccLookerInstance_lookerInstanceBasicExample|TestAccLoggingBucketConfigProject_cmekSettings|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccDataSourceAlloydbLocations_basic|TestAccDataSourceGoogleFirebaseAndroidAppConfig

Get to know how VCR tests work

modular-magician · 2023-06-08T00:32:07Z

Tests passed during RECORDING mode:
TestAccLookerInstance_lookerInstanceFullExample[Debug log]
TestAccLookerInstance_lookerInstanceBasicExample[Debug log]
TestAccLoggingBucketConfigProject_cmekSettings[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

kppk · 2023-06-08T22:58:04Z

TestAccComputeFirewallPolicyRule_multipleRules failed because of:

Error: Error creating FirewallPolicyRule: operation received error: 
error code "QUOTA_EXCEEDED", message: Quota 'FIREWALL_SECURITY_POLICY_RULES' exceeded. 
Limit: 250.0 globally.

The failure is not related to this PR.

rileykarson

The failing test is due to an issue on our end!

The pricing on this product is pretty high, we'll need to work out whether that's an issue for our team or not before merging this. I'm not sure offhand- I'm out tomorrow, but will investigate Monday.

rileykarson · 2023-06-08T23:05:25Z

+    name: reservedRange
+    description: |
+      Name of a reserved IP address range within the consumer network, to be used for
+      private servicie access connection. User may or may not specify this in a request.


Suggested change

private servicie access connection. User may or may not specify this in a request.

private service access connection. User may or may not specify this in a request.

This is a typo in the original API docs, fwiw

kppk · 2023-06-13T22:05:31Z

@rileykarson Could you please have another look at this?

Merge into main

modular-magician · 2023-07-12T20:21:56Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 14 files changed, 2940 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 14 files changed, 2940 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 5 files changed, 569 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 12 files changed, 434 insertions(+))

modular-magician · 2023-07-12T21:40:45Z

Tests analytics

Total tests: 2857
Passed tests 2554
Skipped tests: 297
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccVertexAIIndex_updated|TestAccVertexAIIndex_vertexAiIndexStreamingExample|TestAccVertexAIIndex_vertexAiIndexExample|TestAccLookerInstance_lookerInstanceEnterpriseFullExample|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

modular-magician · 2023-07-12T22:52:58Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccVertexAIIndex_updated[Debug log]
TestAccVertexAIIndex_vertexAiIndexExample[Debug log]
TestAccLookerInstance_lookerInstanceEnterpriseFullExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccVertexAIIndex_vertexAiIndexStreamingExample[Error message] [Debug log]
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

rileykarson · 2023-07-12T23:04:08Z

None of those tests are related. I'll make a final review pass tomorrow, but no action expected from 'em on your end.

rileykarson · 2023-07-13T23:12:36Z

+  private_ip_enabled = true
+  public_ip_enabled  = false
+  reserved_range     = "${google_compute_global_address.looker_range.name}"
+  consumer_network   = "projects/${data.google_project.project.number}/global/networks/${google_compute_network.looker_network.name}"


Does this accept a project id, or just a number? Per https://google.aip.dev/cloud/2510#google-apis it should accept both (and return the format that was sent), and project ids are generally preferred as we can just reference https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_network#id instead of needing to do string interpolation here.

@rileykarson Done!

… use id

modular-magician · 2023-07-14T17:08:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 14 files changed, 2940 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 14 files changed, 2940 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 5 files changed, 569 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 12 files changed, 434 insertions(+))

modular-magician · 2023-07-14T18:25:09Z

Tests analytics

Total tests: 2858
Passed tests 2551
Skipped tests: 297
Affected tests: 10

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccLookerInstance_lookerInstanceEnterpriseFullExample|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules|TestAccClouddeployDeliveryPipeline_VerifyDeliveryPipeline|TestAccClouddeployDeliveryPipeline_DeliveryPipeline|TestAccClouddeployTarget_Target|TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline|TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample

Get to know how VCR tests work

modular-magician · 2023-07-14T19:18:39Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccLookerInstance_lookerInstanceEnterpriseFullExample[Debug log]
TestAccClouddeployDeliveryPipeline_VerifyDeliveryPipeline[Debug log]
TestAccClouddeployDeliveryPipeline_DeliveryPipeline[Debug log]
TestAccClouddeployTarget_Target[Debug log]
TestAccClouddeployDeliveryPipeline_CanaryServiceNetworkingDeliveryPipeline[Debug log]
TestAccClouddeployDeliveryPipeline_CanaryrunDeliveryPipeline[Debug log]
TestAccClouddeployDeliveryPipeline_CanaryDeliveryPipeline[Debug log]
TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

…#8110) Co-authored-by: Riley Karson <rileykarson@google.com> Co-authored-by: Efe Elaiho <efeelaiho@google.com> Co-authored-by: efeelaiho <efeelaiho15@utexas.edu>

efeelaiho and others added 15 commits May 6, 2023 17:54

add Looker product

a35c07f

Update Instance.yaml

a9a6e34

Update description for allowed email domains in Instance.yaml

60cce0f

Add looker_instance_basic example

b5235a6

add async definition to product.yaml

2eebe60

Update Instance.yaml for Looker

6971f45

update Instance yaml and looker_instance_basic example

db84947

Merge branch 'GoogleCloudPlatform:main' into main

e24e40a

Merge branch 'GoogleCloudPlatform:main' into main

2d06723

remove custom domain as it requires steps outside of terraform provis…

e2d19ac

…ioning

Merge branch 'main' of https://github.com/efeelaiho/magic-modules

0d7cbd2

fix day of week name for maintenance window in Instance.yaml

b9db09a

Merge branch 'GoogleCloudPlatform:main' into main

6bbb0b6

Merge ssh://github.com/GoogleCloudPlatform/magic-modules

90ae86e

Add looker example with full set of fields

6571e61

modular-magician requested a review from rileykarson June 7, 2023 21:43

modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jun 7, 2023

rileykarson reviewed Jun 8, 2023

View reviewed changes

Changes based on the review comments

4950fa0

modular-magician requested a review from rileykarson June 13, 2023 21:51

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 13, 2023

rileykarson mentioned this pull request Jun 27, 2023

Add Looker product and Instance resource support #7898

Closed

5 tasks

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 27, 2023

Update Instance.yaml to stop retries for 429

1d74d4c

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 11, 2023

Merge pull request #3 from GoogleCloudPlatform/main

c979cc6

Merge into main

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 12, 2023

rileykarson reviewed Jul 13, 2023

View reviewed changes

Update looker_instance_enterprise_full.tf.erb for consumer network to…

fe77d78

… use id

modular-magician requested a review from rileykarson July 14, 2023 01:42

modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 14, 2023

rileykarson approved these changes Jul 14, 2023

View reviewed changes

rileykarson reviewed Jul 14, 2023

View reviewed changes

Comment thread mmv1/products/looker/Instance.yaml Outdated

Update mmv1/products/looker/Instance.yaml

bd9a03e

rileykarson merged commit e449971 into GoogleCloudPlatform:main Jul 14, 2023

modular-magician requested a review from rileykarson July 14, 2023 20:46

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 14, 2023

	private servicie access connection. User may or may not specify this in a request.
	private service access connection. User may or may not specify this in a request.

Uh oh!

Conversation

kppk commented Jun 7, 2023 • edited by rileykarson Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Jun 7, 2023

Uh oh!

modular-magician commented Jun 7, 2023

Diff report

Uh oh!

modular-magician commented Jun 7, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Jun 8, 2023

Uh oh!

kppk commented Jun 8, 2023

Uh oh!

rileykarson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rileykarson Jun 8, 2023

Choose a reason for hiding this comment

Uh oh!

kppk Jun 13, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kppk commented Jun 13, 2023

Uh oh!

modular-magician commented Jul 12, 2023

Diff report

Uh oh!

modular-magician commented Jul 12, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Jul 12, 2023

Rerun these tests in REPLAYING mode to catch issues

Uh oh!

rileykarson commented Jul 12, 2023

Uh oh!

rileykarson Jul 13, 2023

Choose a reason for hiding this comment

Uh oh!

efeelaiho Jul 14, 2023

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Jul 14, 2023

Diff report

Uh oh!

modular-magician commented Jul 14, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Jul 14, 2023

Rerun these tests in REPLAYING mode to catch issues

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kppk commented Jun 7, 2023 •

edited by rileykarson

Loading