Skip to content

Fixed alloydb cluster and instance sweeping#8374

Merged
melinath merged 2 commits into
mainfrom
tpg-15215
Jul 19, 2023
Merged

Fixed alloydb cluster and instance sweeping#8374
melinath merged 2 commits into
mainfrom
tpg-15215

Conversation

@melinath

@melinath melinath commented Jul 18, 2023

Copy link
Copy Markdown
Member

Resolved hashicorp/terraform-provider-google#15215

I ran this locally to clear out test alloydb clusters, and it worked fine.


@melinath melinath requested review from a team and hao-nan-li and removed request for a team July 18, 2023 19:02

@hao-nan-li hao-nan-li left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the linter detected couple items, could you take a look into that?

@melinath

Copy link
Copy Markdown
Member Author

/gcbrun

@melinath

Copy link
Copy Markdown
Member Author

I've fixed the issue, but this seems to be pulling an old version of the generated provider code into the tgc build for some reason. Retrying again. /gcbrun

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 1 insertion(+), 159 deletions(-))
Terraform Beta: Diff ( 2 files changed, 1 insertion(+), 159 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@melinath melinath requested a review from hao-nan-li July 19, 2023 17:30
@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2864
Passed tests 2562
Skipped tests: 299
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeInstance_minCpuPlatform|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstance_minCpuPlatform[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@hao-nan-li hao-nan-li left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melinath melinath merged commit 229c367 into main Jul 19, 2023
@melinath melinath deleted the tpg-15215 branch July 19, 2023 20:03
melinath added a commit that referenced this pull request Jul 20, 2023
* Fixed alloydb cluster and instance sweeping

Resolved hashicorp/terraform-provider-google#15215

* Fixed imports in sweeper
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
* Fixed alloydb cluster and instance sweeping

Resolved hashicorp/terraform-provider-google#15215

* Fixed imports in sweeper
wj-chen pushed a commit to wj-chen/magic-modules that referenced this pull request Aug 1, 2023
* Fixed alloydb cluster and instance sweeping

Resolved hashicorp/terraform-provider-google#15215

* Fixed imports in sweeper
DanielRieske pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 2, 2023
* Fixed alloydb cluster and instance sweeping

Resolved hashicorp/terraform-provider-google#15215

* Fixed imports in sweeper
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Aug 9, 2023
* Fixed alloydb cluster and instance sweeping

Resolved hashicorp/terraform-provider-google#15215

* Fixed imports in sweeper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccAlloydb*

3 participants