Skip to content

Add provider packages to teamcity#8330

Merged
SarahFrench merged 1 commit into
mainfrom
add-provider-packages-tc
Jul 13, 2023
Merged

Add provider packages to teamcity#8330
SarahFrench merged 1 commit into
mainfrom
add-provider-packages-tc

Conversation

@zli82016

Copy link
Copy Markdown
Member

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@zli82016 zli82016 changed the title Add provider packages to the teamcity Add provider packages to teamcity Jul 12, 2023
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 2 insertions(+))
Terraform Beta: Diff ( 1 file changed, 2 insertions(+))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@zli82016 zli82016 requested a review from SarahFrench July 12, 2023 22:11
@SarahFrench

Copy link
Copy Markdown
Contributor

@zli82016 I can see the new service packages reflected in TeamCity - for example the SDK provider acceptance tests are here: https://ci-oss.hashicorp.engineering/buildConfiguration/TerraformOpenSource_TerraformProviders_Google_GOOGLE_SERVICE_PUBLIC_PROVIDER?mode=builds

@zli82016

Copy link
Copy Markdown
Member Author

Thanks, @SarahFrench , that is amazing.

@zli82016 zli82016 deleted the add-provider-packages-tc branch July 13, 2023 18:22
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
wj-chen pushed a commit to wj-chen/magic-modules that referenced this pull request Aug 1, 2023
DanielRieske pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 2, 2023
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants