Skip to content

Added a note that failover_target is not supported for Postgres Database.#8401

Merged
hao-nan-li merged 1 commit into
GoogleCloudPlatform:mainfrom
ibhaskar2:main
Jul 20, 2023
Merged

Added a note that failover_target is not supported for Postgres Database.#8401
hao-nan-li merged 1 commit into
GoogleCloudPlatform:mainfrom
ibhaskar2:main

Conversation

@ibhaskar2

Copy link
Copy Markdown
Contributor

Failover_target is not supported for Postgres Database.
b/290620351

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot. It looks like you are a community contributor. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 2 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 2 insertions(+), 1 deletion(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2871
Passed tests 2570
Skipped tests: 299
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@hao-nan-li hao-nan-li changed the title Added a not that failover_target is not supported for Postgres Database. Added a note that failover_target is not supported for Postgres Database. Jul 20, 2023
@hao-nan-li hao-nan-li merged commit 23f0024 into GoogleCloudPlatform:main Jul 20, 2023
@shuyama1 shuyama1 mentioned this pull request Jul 21, 2023
5 tasks
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
NickElliot pushed a commit to NickElliot/magic-modules that referenced this pull request Jul 31, 2023
DanielRieske pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 2, 2023
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Aug 9, 2023
@aleksandersumowski

Copy link
Copy Markdown

Hi Ishant @ibhaskar2, any particular reason why Postgresql is not supported? Cloud SQL Postgresql itself does support ADR and assigning designated failover target

https://cloud.google.com/sql/docs/postgres/use-advanced-disaster-recovery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants