Add making a breaking change guide#8326
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR hasn't generated any diffs, but I'll let you know if a future commit does. |
Tests analyticsTotal tests: Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccVertexAIIndex_vertexAiIndexStreamingExample|TestAccVertexAIIndex_vertexAiIndexExample|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules|TestAccBigQueryDataTable_bigtable|TestAccVertexAIIndex_updated |
|
Rerun these tests in REPLAYING mode to catch issues
|
c2thorn
left a comment
There was a problem hiding this comment.
Read through a few times and can't find anything I'd change.
|
Notice, this broke the hotlinks for the breaking change detector https://github.com/GoogleCloudPlatform/magic-modules/pull/8375/files |
This file was previously auto generated by code. |
First pass so far- I'm planning to add some more specific guides and hopefully to make them a little more prescriptive, but this is already a bunch of text so I wanted to push it out to review.
Some of the details on this page conflicted with https://googlecloudplatform.github.io/magic-modules/develop/breaking-changes/, so I've made that page a dedicated "reference" page to explain the detector analyser, and removed duplicated content. Note that I think the reference links are broken as they will still link to deleted files in TPG/TPGB, but they were broken in #8240 and I just haven't fixed 'em here, since this is a documentation change.
Note that most of the content on that page was committed directly to TPG/TPGB and was unreviewed in the first place.
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)