Add optional_components to documentation#8407
Conversation
melinath
left a comment
There was a problem hiding this comment.
optional_components LGTM. Could we please clean up the properties line as well since it is also related?
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 4 insertions(+)) |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 366 insertions(+), 362 deletions(-)) |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 379 insertions(+), 362 deletions(-)) |
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 381 insertions(+), 362 deletions(-)) |
* Add optional_components to documentation * Fix formatting, remove redundant optional * Clean up properties documentation * Apply suggestions from code review Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Add asterisks --------- Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
* Add optional_components to documentation * Fix formatting, remove redundant optional * Clean up properties documentation * Apply suggestions from code review Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Add asterisks --------- Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
* Add optional_components to documentation * Fix formatting, remove redundant optional * Clean up properties documentation * Apply suggestions from code review Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Add asterisks --------- Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
* Add optional_components to documentation * Fix formatting, remove redundant optional * Clean up properties documentation * Apply suggestions from code review Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Add asterisks --------- Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
fixes b/284450505
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)