Skip to content

Add optional_components to documentation#8407

Merged
trodge merged 5 commits into
GoogleCloudPlatform:mainfrom
trodge:tpgtools-docs
Jul 20, 2023
Merged

Add optional_components to documentation#8407
trodge merged 5 commits into
GoogleCloudPlatform:mainfrom
trodge:tpgtools-docs

Conversation

@trodge

@trodge trodge commented Jul 20, 2023

Copy link
Copy Markdown
Contributor

fixes b/284450505

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@trodge trodge requested a review from melinath July 20, 2023 18:32

@melinath melinath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional_components LGTM. Could we please clean up the properties line as well since it is also related?

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 4 insertions(+))
Terraform Beta: Diff ( 1 file changed, 4 insertions(+))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@trodge trodge requested a review from melinath July 20, 2023 20:12
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 366 insertions(+), 362 deletions(-))
Terraform Beta: Diff ( 1 file changed, 366 insertions(+), 362 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 379 insertions(+), 362 deletions(-))
Terraform Beta: Diff ( 1 file changed, 379 insertions(+), 362 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

trodge and others added 2 commits July 20, 2023 14:18
Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
@trodge trodge requested a review from melinath July 20, 2023 21:21

@melinath melinath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 381 insertions(+), 362 deletions(-))
Terraform Beta: Diff ( 1 file changed, 381 insertions(+), 362 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@trodge trodge merged commit 1bd9af8 into GoogleCloudPlatform:main Jul 20, 2023
@trodge trodge deleted the tpgtools-docs branch July 20, 2023 22:24
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
* Add optional_components to documentation

* Fix formatting, remove redundant optional

* Clean up properties documentation

* Apply suggestions from code review

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Add asterisks

---------

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
NickElliot pushed a commit to NickElliot/magic-modules that referenced this pull request Jul 31, 2023
* Add optional_components to documentation

* Fix formatting, remove redundant optional

* Clean up properties documentation

* Apply suggestions from code review

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Add asterisks

---------

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
DanielRieske pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 2, 2023
* Add optional_components to documentation

* Fix formatting, remove redundant optional

* Clean up properties documentation

* Apply suggestions from code review

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Add asterisks

---------

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Aug 9, 2023
* Add optional_components to documentation

* Fix formatting, remove redundant optional

* Clean up properties documentation

* Apply suggestions from code review

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Add asterisks

---------

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants