feat: add most_recent option to google_compute_image datasource#8309
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @NickElliot, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
bd5ace1 to
3a22359
Compare
65e9c7c to
5194a89
Compare
NickElliot
left a comment
There was a problem hiding this comment.
Looks like the build is currently failing due to a missing time import to enable the code you added. Could you include that? Thanks!
|
Hello @NickElliot, Oh yes! Sorry, I forgot to copy/paste back from my go code to the ruby template 😅 |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 3 files changed, 72 insertions(+), 1 deletion(-)) |
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeFirewallPolicyRule_multipleRules|TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample|TestAccDataSourceComputeImageFilter|TestAccContainerAwsNodePool_BetaBasicHandWritten |
|
Rerun these tests in REPLAYING mode to catch issues
|
NickElliot
left a comment
There was a problem hiding this comment.
LGTM! to @ScottSuarez for final review
|
Looks good to me. @NickElliot can you approve and merge. Merging gets block if there is a |
|
Many thanks guys ;-) |
This PR aims to add
most_recentargument the same way AWS does.I didn't really find where I could add an example, but here it is:
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)