Support named databases for Firestore#8341
Conversation
|
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
8de6c13 to
f9442e6
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 224 insertions(+), 31 deletions(-)) |
There's no actual validation changes here; this is really just a documentation/testing update.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 219 insertions(+), 28 deletions(-)) |
slevenick
left a comment
There was a problem hiding this comment.
I'm not reviewing as this is marked as draft. Please re-request review when this is ready for me to take a look
Tests analyticsTotal tests: Action takenFound 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccFirestoreDatabase_firestoreDatabaseInDatastoreModeExample|TestAccFirestoreDatabase_firestoreDefaultDatabaseExample|TestAccFirestoreDatabase_firestoreDatabaseExample|TestAccFirestoreDatabase_firestoreDefaultDatabaseInDatastoreModeExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccContainerAwsNodePool_BetaBasicHandWritten |
|
Rerun these tests in REPLAYING mode to catch issues
|
slevenick
left a comment
There was a problem hiding this comment.
Removed the release note as there are no user-facing changes except for docs.
Thanks!
There's no actual validation changes here; this is really just a documentation/testing update.
There's no actual validation changes here; this is really just a documentation/testing update.
There's no actual validation changes here; this is really just a documentation/testing update.
There's no actual validation changes here; this is really just a documentation/testing update.
This adds named database support for Firestore databases.
No actual Terraform code needs to be changed for this to occur, this is purely a matter of documentation and testing.
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)