Skip to content

Support named databases for Firestore#8341

Merged
slevenick merged 1 commit into
GoogleCloudPlatform:mainfrom
bw-yuhogg:firestore-db
Jul 14, 2023
Merged

Support named databases for Firestore#8341
slevenick merged 1 commit into
GoogleCloudPlatform:mainfrom
bw-yuhogg:firestore-db

Conversation

@bw-yuhogg

@bw-yuhogg bw-yuhogg commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

This adds named database support for Firestore databases.
No actual Terraform code needs to be changed for this to occur, this is purely a matter of documentation and testing.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes). Just documentation/testing, so not needed
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests). N/A
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know). Tests not yet passing locally
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @slevenick, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@bw-yuhogg bw-yuhogg force-pushed the firestore-db branch 3 times, most recently from 8de6c13 to f9442e6 Compare July 13, 2023 20:58
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 224 insertions(+), 31 deletions(-))
Terraform Beta: Diff ( 2 files changed, 224 insertions(+), 31 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

There's no actual validation changes here;
this is really just a documentation/testing update.
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 219 insertions(+), 28 deletions(-))
Terraform Beta: Diff ( 2 files changed, 219 insertions(+), 28 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@slevenick slevenick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not reviewing as this is marked as draft. Please re-request review when this is ready for me to take a look

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2855
Passed tests 2552
Skipped tests: 297
Affected tests: 6

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFirestoreDatabase_firestoreDatabaseInDatastoreModeExample|TestAccFirestoreDatabase_firestoreDefaultDatabaseExample|TestAccFirestoreDatabase_firestoreDatabaseExample|TestAccFirestoreDatabase_firestoreDefaultDatabaseInDatastoreModeExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccContainerAwsNodePool_BetaBasicHandWritten

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccFirestoreDatabase_firestoreDatabaseInDatastoreModeExample[Debug log]
TestAccFirestoreDatabase_firestoreDefaultDatabaseExample[Debug log]
TestAccFirestoreDatabase_firestoreDatabaseExample[Debug log]
TestAccFirestoreDatabase_firestoreDefaultDatabaseInDatastoreModeExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@bw-yuhogg bw-yuhogg marked this pull request as ready for review July 14, 2023 15:23
@bw-yuhogg bw-yuhogg requested a review from slevenick July 14, 2023 15:23

@slevenick slevenick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the release note as there are no user-facing changes except for docs.

Thanks!

@slevenick slevenick merged commit ad99390 into GoogleCloudPlatform:main Jul 14, 2023
@bw-yuhogg bw-yuhogg deleted the firestore-db branch July 14, 2023 17:43
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
There's no actual validation changes here;
this is really just a documentation/testing update.
wj-chen pushed a commit to wj-chen/magic-modules that referenced this pull request Aug 1, 2023
There's no actual validation changes here;
this is really just a documentation/testing update.
DanielRieske pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 2, 2023
There's no actual validation changes here;
this is really just a documentation/testing update.
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Aug 9, 2023
There's no actual validation changes here;
this is really just a documentation/testing update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants