[henrychu04]

Syncs upstream pingdotgg/t3code main into coder-only in two stages, as two merge commits plus two adaptation commits.

Range

• Previous sync point: 47f2c8d29e. Base: origin/coder-only adf176d93e.
• Stage 1: bb4afa5425 ("chore(release): prepare v0.1.7"), 327 commits, including the Effect 4.0.5 → 4.1.2 upgrade (chore(deps): upgrade Effect to 4.1.2 and alchemy to beta.85 pingdotgg/t3code#26833). Merge commit 94085d96f0.
• Stage 2: 337c5858c3, 50 more commits. Merge commit caee27a8c4.
• Adaptation commits:
  • 69820f4b12: Claude CLI transport for MCP Apps.
  • 7d03f6b9d5: seams doc, sync tooling, and SYNC_BASE set to 337c5858c3.
• The .repos/ reference-repo sync (chore(repos): sync reference repos from shallow clones pingdotgg/t3code#30472, chore(repos): sync Effect 4.1.2 and Alchemy beta.85, rename effect-smol pingdotgg/t3code#30481) resolved as deleted paths: about 19,800 modify/delete conflicts plus about 2,950 added files. sync-resolve-deleted.mjs now uses a large output buffer and passes paths to git rm on stdin, because the argument list was too long. 82 cut files that upstream modified after their cut joined DELETED_PATHS.

Cut

• GitHub star prompts (feat(web): ask for a GitHub star when idle, and star in one click pingdotgg/t3code#29922, feat(web): celebrate a GitHub star with confetti pingdotgg/t3code#29987). sourceControl.star is not served, and the source-control-core driver has no starRepository.
• Secret-provider readers (feat(server): read source control host tokens from a secret provider pingdotgg/t3code#27756, feat(server): read usage limit source keys from a secret provider pingdotgg/t3code#27760, feat(device): read the EAS access token from a secret provider pingdotgg/t3code#27763). The coderSecretResolver.ts stand-in stays, and secretReferences is not advertised. The helper passes a constant settingsClient (secretReferences: true), because it has no WebSocket query to read upstream's clientCapabilities from.
• Managed policy: Group Policy template, Kiro coverage, and update mirror (feat(policy): admins set managed policy from a Group Policy template pingdotgg/t3code#29862, fix(server): managed policy covers Kiro pingdotgg/t3code#29915, fix(server): t3 update installs from the policy's update mirror pingdotgg/t3code#29911). resolveRuntimeModeOptions takes no policy.
• Kiro (feat(provider-kiro): add Kiro as an ACP provider pingdotgg/t3code#14693, fix(kiro): slow kiro-cli starts no longer show Kiro as unavailable pingdotgg/t3code#29841): its package, registration, fixtures, tests, and guide. Shared provider-acp code stays upstream's; see open questions.
• Telemetry and analytics export (fix(server): quitting no longer waits on an unreachable telemetry endpoint pingdotgg/t3code#30033, fix(server): OTLP export settings survive a saved token streaming mode pingdotgg/t3code#29786, feat(server): log fast and ultrafast service tiers in analytics pingdotgg/t3code#29348 service tiers).
• Relay and T3 Connect signing (refactor: hold relay signing keys in EnvironmentSigningKey and CloudMintSigner pingdotgg/t3code#30529, refactor(client-runtime): share DPoP proof creation across web and mobile pingdotgg/t3code#30540), cloud environment keys, and cloud link state.
• Other cut areas: mobile, desktop, devices, Claude accounts (fix(mobile): configure another Claude account from Providers pingdotgg/t3code#28928), app links for copied thread links (feat(mobile,web): copied thread links open the mobile app pingdotgg/t3code#29815), and managed Codex sharing notices (fix(codex): sharing usage limits offer the existing recovery options pingdotgg/t3code#25341).
• Agent preview recordings (fix(server): deleting a thread also removes its agent preview recordings pingdotgg/t3code#29853).
• Terminal-link metadata check (fix(web): validate terminal links against filesystem metadata pingdotgg/t3code#30526): fork terminal links never open.
• Socket frame parts on the HTTP WebSocket route (fix(client): a big server config on a slow link no longer drops the connection in a loop pingdotgg/t3code#23758): the helper speaks stdio. The client-side handling stays upstream's.

Carried

• Effect 4.1.2. Upstream's renamed @effect/vitest@4.1.2 patch is taken. Crypto moved to effect/crypto (SecureRandom/Digest), and NodeCrypto.layer is provided in coderServer.ts and the fork-only tests. ws@8.22.1 is pinned back to upstream's 8.22.0.
• build: typecheck with tsrs and Effect's rules through @effect/tsgo pingdotgg/t3code#31028 @effect/tsgo, as upstream has it. This follows your decision change. The details:
  • the @effect/tsgo 0.67.1 devDependency;
  • no typescript catalog entry or root devDependency, so the fork's typescript: 7.0.2 pin is gone;
  • its minimumReleaseAgeExclude entries;
  • .vscode/tsdk/tsgo;
  • effect-tsgo tsrs --noEmit typecheck scripts, also in the fork's packages and the root typecheck:* scripts (the names are unchanged, so AGENTS.md needs no edit);
  • build: run Effect rules on mobile and lock in clean suggestion rules pingdotgg/t3code#31111's Effect-rule config (tsconfig.effect.json).
• typescript-legacy stays in the root devDependencies, because knip's scripts/knip-schemas.ts preprocessor needs the JavaScript compiler API. Upstream keeps the same alias in its uncarried scripts/package.json.
• Effect refactors refactor: errors are Schema.TaggedError, not Data.TaggedError or native Error pingdotgg/t3code#31216, refactor: Effect.try calls map failures to typed errors pingdotgg/t3code#31217, refactor: Effect code reads env through HostProcess.Environment pingdotgg/t3code#31218 and effect/jose + effect/crypto (refactor: replace jose with effect/jose pingdotgg/t3code#30474, refactor: move HMAC, key, and random work to effect/crypto pingdotgg/t3code#30501, refactor(server): sign server tokens through PayloadSigner pingdotgg/t3code#30523). auth/PayloadSigner.ts and assets/AssetSigner.ts are kept, because the carried signed asset URLs use them.
• Features: request_secret instead of chat (feat(server): agents ask for secrets through request_secret instead of chat pingdotgg/t3code#30257), Claude models reported by Claude Code (feat(server): list Claude models reported by Claude Code pingdotgg/t3code#30511), ghq-style clone folders (feat: optionally clone repos into ghq-style <host>/<owner>/<repo> folders pingdotgg/t3code#24904), and copy-thread links (feat(server,web,mobile,desktop): Copy thread copies a link that opens the thread pingdotgg/t3code#26290, web part) with the new /threads/$environmentId/$threadId route. Links use the gateway's own origin, and upstream's hosted links still parse.
• MCP Apps from Claude tool calls (feat(server): render MCP Apps from Claude tool calls pingdotgg/t3code#29803). It needed nothing beyond the existing mcpApps rendering path, so no remote content loads in the browser. ClaudeCli.ts now sends:
  • mcp_status;
  • mcp_read_resource;
  • the raw mcp_call and list_permission_rules control requests, with SDK 0.3.316 wire shapes; any other raw request is refused.
• Claude session title (perf(server): skip redundant claude session naming pingdotgg/t3code#28910) travels in initialize, as the SDK sends it.
• Agent SDK type pin moved to 0.3.316.
• Upstream's strictPeerDependencies. The fork installs with autoInstallPeers: false, so @effect/platform-node's unused redis peer joins ignoreMissing.
• Smaller carries: thread titles RPC (fix(web): deleted forks no longer remain in Lineage pingdotgg/t3code#29000) and MR description checkbox saves (fix(web,mobile): save pull request description checkbox changes pingdotgg/t3code#30704).
• Generic fixes: all generic server, web, client-runtime, shared, Pi, Claude, Codex, ACP, and GitLab fixes.

Effect-rule diagnostics after the tsgo switch

• Upstream files: no new suppressions. Each flagged fork seam line was rewritten in upstream's style, for example Effect.fn, tryPromise({ try, catch }) with a Schema.TaggedError, Schema.is, Clock, SecureRandom, HostProcess.Environment, and Effect.forEach.
• Fork-only files: the mechanical fixes were applied:
  • Schema.TaggedError (FileBridgeToolFailure, PastedImageAttachments, CoderWorkspaceResourceUsageError);
  • typed Effect.try / Schema.fromJsonString;
  • HostProcess.Environment in coderEnvironment.ts and coder-helper/helper.ts (which gains a @t3tools/shared workspace dependency);
  • Effect.fn across coderWs.ts, coderHub.ts, T3ToolBridge.ts, and T3ToolDispatch.ts (this re-indents coderWs.ts's makeHandlers);
  • Effect.orElseSucceed / Effect.ignoreCause / Effect.undefined.
• 63 suppressions remain, all in fork-only files, each with a specific reason. None are config-level downgrades.

Rule	Count	Files
nodeBuiltinImport	11	gateway assetProxy, assetProxy.test, bin, connectionShutdown.test; coder-helper build; server coderAssets (1 line), FileBridge.test, T3ToolBridge.test, configMetadata.test, storageCleanup.coder.test (1 line); scripts/build-info
globalDate	10	gateway assetProxy.test, coderCommands, hub.test, rpcBridge.test, workspaceConnections; server coderAssets (2 lines), FileBridge; client-runtime errors/diagnostics (1 line); coder-cli transfer.test
globalTimers	10	gateway assetProxy.test, hub.test, rpcBridge.test; coder-helper bundle.test; server coderAssets (1 line), FileBridge.test, FileBridge, ClaudeCli.test (1 line); coder-cli helperConnection.test, helperConnection
extendsNativeError	9 (lines)	gateway configChanges, lifecycleState, process, rpcBridge ×2; coder-cli helperConnection, portForward, processTermination, transfer (callers instanceof and render .message at the HTTP boundary)
anyUnknownInErrorContext	8	gateway bin, connectionShutdown.test, portForwards, server, server.test, testUtils/gateway, workspaceConnections; server T3ToolBridge (1 line)
globalErrorInEffectFailure	4	gateway coderCommands, portForwards, server, workspaceConnections
unknownInEffectCatch	3	gateway server, testUtils/gateway, workspaceConnections
globalFetch	2	gateway assetProxy.test, connectionShutdown.test (the tests act as the browser)
globalJsonInEffect	2	gateway coderCommands (coder CLI JSON); coder-cli helperConnection (RPC frames)
deterministicKeys	2 (lines)	server coderEnvironment, coderSecretResolver (they keep upstream's service keys)
globalErrorInEffectCatch	1	gateway server
tryCatchInEffectGen	1 (line)	coder-cli processTermination

Entries without "(line)" are file-level directives.

Seams changed (docs/internals/coder-only.md)

• New:
  • thread links on the gateway origin, with threadLinks.ts' local DEFAULT_HOSTED_APP_URL;
  • the settingsClient constant;
  • CodexAdapterV2's codexUsageLimitResetAt without CodexManagedErrors;
  • Kiro's dormant provider-acp flavor hooks;
  • the terminal-link check cut;
  • maintainerEditsChoiceInForce unexported;
  • supervisor.ts without fix(client-runtime): connect to the primary environment while the browser reports offline pingdotgg/t3code#29347's offline exemption or learned-route lease;
  • auth keeps PayloadSigner;
  • no agent preview recordings;
  • resolveRuntimeModeOptions without policy;
  • the TypeScript/tsgo bullet rewritten to list only the remaining differences;
  • the redis ignoreMissing entry;
  • the Claude CLI method list;
  • new test adaptations.
• Dropped: the review top-level sourceKind seam (GitVcsDriverCore and DiffPanel), because upstream now has it (8b44f42 / fix(web): load selected diff metadata before file patches pingdotgg/t3code#30567).
• GitLabCli "checked against" moved to 337c5858c3; the fixes are still absent upstream.

Checks

• pnpm test:coder: passes on the head (exit 0): gateway/helper/coder-cli node tests 121/121, server 4006 (1 skipped), web unit 1168 and browser 555, client-runtime 1101, shared 3992, providers, source control, and knip.
• Fixes made along the way:
  • Upstream test cases that exercise cut surfaces were adapted with Coder: notes: GitHub/Bitbucket registry rows, the preview-recording id, the secret-request metric count, the offline query store step, the terminal-link metadata case, and the Antigravity runtime-mode case.
  • The fork-only Kilo bridge test now turns on protocol logging, which perf(acp): ACP agents skip decoding output twice for unused diagnostics pingdotgg/t3code#29100 stopped enabling by default.
  • A fork-adapted video offset was wrong; it now matches the shorter GitLab URL.
  • ClaudeCapabilitiesProbe spies on the CLI transport.
  • ThreadServersPanel's browser test mocks useCoder.
• Typechecks: every one listed in AGENTS.md passes under effect-tsgo tsrs.
• Formatting and lint-style checks: pnpm knip:check passes, after two upstream exports only cut code uses were added to ignoreIssues (PayloadSigner.ts, socketFrameParts.ts). vp fmt --check over the changed files passes. seams-check passes, no .orig/.rej files are tracked, and ls patches matches patchedDependencies.
• pnpm build: passes.
• sync-check: markers changes are all new seams or the dropped sourceKind seam.
  • lost: 484 lines in stage 1 and 127 in stage 2. All are cut surfaces (Kiro fixtures and registration, peer HTTP links, usage analytics, secret-provider readers, managed policy, preview recordings, the terminal-link check, cloud keys, relay/DPoP, the socket frame route) or existing seams (metrics, Codex managed errors, lastErrorCode, the Claude fork/settings seams, the HTTP routes).
  • both-sides: only the intended seam rewrites remain, plus the removed timingSafeEqualBase64Url that no carried code calls.
  • unused-locals: clean.
• Section 5 checks:
  • Claude transport: the new title option and the mcpServerStatus/readMcpResource/raw calls are all mapped.
  • Node: engines.node stays ^24.13.1 and @types/node stays on 24.
  • MCP: no new MCP server paths.
  • RPCs: WsSourceControlStarRpc is omitted (cut); WsOrchestrationV2GetThreadTitlesRpc is served.
  • Scopes: there are new scope reads, but the fork's scopes always grant.
  • Wording: clean.

Live smoke

• GitLab MR flows, against scripts/coder-pr-smoke.mjs (the local helper with the fake glab): MR list, detail, diff, comment, title update, activity, and a re-read showing the new title all passed over the gateway RPC. The new /threads/… route is served.
• Real Coder workspace, through the fresh scripts/coder-live-test.mjs harness on Coder 2.34.5:
  • a fake kilo acp turn found the file-bridge command in its prompt;
  • --list included t3_queue, and t3_queue returned {"items":[],…};
  • t3_attachment_prepare_upload stored a workspace file;
  • t3_thread_send_attachments started a new turn with it, and the attachment appears in the thread projection;
  • a cross-origin connect is refused with 403.
• Not run: a real Claude turn (no Claude CLI in the harness image) and a browser UI check.

Open questions

1. @effect/tsgo ships platform-native binaries through optional dependencies: @effect/tsgo-win32-x64 on the work laptop, containing tsrs, a patched tsc, and oxlint artifacts, about 100 MB. Please confirm they run there. The Microsoft TypeScript 7 they replace also installed native @typescript/typescript-win32-x64 binaries, but those are Microsoft-signed.
2. .vscode/tsdk/tsgo is a tracked shell script with no .sh extension. The work download scanner keyed on .sh files last time; this file may still trip it. Upstream's .vscode/settings.json and extensions.json are not carried, so the script is only useful if you point VS Code at it yourself.
3. Kiro's dormant code in shared provider-acp. I kept upstream's generic flavor hooks (steering, fork from turn, compactSession, cancelAfterPromptStarts, ignoreSessionUpdate, configOptionChanges) and runtimeModel.ts's Kiro tool-name parsing, the same way as mcpOverAcpBridge.ts. Cutting them would add many seams to adapter.ts. Say if you want them cut.
4. Copied thread links point at the gateway's loopback origin. They are useful only on the same laptop. The alternative is to cut feat(server,web,mobile,desktop): Copy thread copies a link that opens the thread pingdotgg/t3code#26290's link and keep the t3-thread:// chips.
5. The fork-only re-indents (coderWs.ts's Effect.fn and ProviderSessionManager's release Effect.fnUntraced) grow diffs in files that conflict often.

🤖 Generated with Claude Code

[henrychu04]

Review follow-up (c478417):

• Dropped .vscode/tsdk/tsgo: the fork carries no other VS Code settings, and it is an extension-less tracked shell script the work download scanner may reject. Answers open question 2.
• ProviderSessionManager.ts's release block keeps upstream's Effect.gen shape with one effectFnOpportunity suppression instead of an 80-line re-indent. Answers part of open question 5.

Reverified on c478417: format check, all 11 typechecks, knip:check, seams-check, pnpm test:coder (4006 server tests passed; the earlier ClaudeAdapterV2 60 s timeout did not recur and passed twice in isolation), and pnpm build all pass. sync-check both-sides/lost reviewed: every lost line is a cut or an existing seam.

🤖 Generated with Claude Code