Skip to content

feat(server): read usage limit source keys from a secret provider - #27760

Draft
yordis wants to merge 14 commits into
pingdotgg:mainfrom
yordis:yordis/feat-secret-refs-usage-limit-keys
Draft

yordis wants to merge 14 commits into
pingdotgg:mainfrom
yordis:yordis/feat-secret-refs-usage-limit-keys

Conversation

@yordis

@yordis yordis commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Problem

Stacked on #27756, whose commits this branch carries until they merge, so only the last commit is new here. A usage-limit source's management key still has to be pasted into T3 Code, so teams that keep credentials in 1Password cannot read it from there.

Change

  • The management key of a usage-limit source accepts a secret reference as well as a literal, picked with the existing source input in the add-source dialog.
  • A reference is stored as written and shown as written to clients; a literal still goes to the secret store.
  • The server reads the reference when it queries the source. If the provider cannot read it, the source reports that the key could not be read from its secret provider rather than querying with an empty key.

Scope and approval

Third step of the stack that starts at #27746, reusing SecretResolver and SecretSourceInput unchanged and gated by the same secrets feature flag. It adds no provider kind and no new setting.

Verification

  • vp test run src/usage/UsageLimitSources.test.ts src/serverSettings.test.ts in apps/server: pass. Covers reading a key from a reference, and the clear failure when the provider cannot read it.
  • vp run typecheck: pass. vp run check:changed: format, lint, knip, typecheck, react compiler pass. Eight tests in ProviderEventIngestor.test.ts and CodexAdapterV2.test.ts fail in this environment; neither file is touched by this change.
  • Not checked: a live 1Password account.

…ovider

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Oct 30, 2026
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/feat-secret-refs-usage-limit-keys branch from 78f0e33 to 08bd4b9 Compare October 30, 2026 19:10
…secret providers

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…ed resolution

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…ts that failed or rotated

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
… read

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/feat-secret-refs-usage-limit-keys branch 2 times, most recently from ab502b2 to 968ca4a Compare October 30, 2026 19:48
…ngs cannot be read

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/feat-secret-refs-usage-limit-keys branch from 968ca4a to 38dbfd9 Compare October 30, 2026 20:07
…ovider's unlock

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/feat-secret-refs-usage-limit-keys branch from 38dbfd9 to 15a5e79 Compare October 30, 2026 20:37
@github-actions github-actions Bot added size:XL 500-999 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels Oct 30, 2026
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/feat-secret-refs-usage-limit-keys branch from 15a5e79 to 8afaffd Compare October 30, 2026 20:54
…he API during discovery

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/feat-secret-refs-usage-limit-keys branch from 8afaffd to 37b29f6 Compare October 30, 2026 21:27
@maria-rcks

Copy link
Copy Markdown
Collaborator

Note

Written by gpt-6.1-sol on behalf of Maria

This change lacks the UI evidence required by verification. AddUsageLimitSourceDialog replaces the management-key input with SecretSourceInput, but the PR supplies no before/after screenshots of that dialog or recording of choosing a reference and saving it. The focused resolver tests and parent source-control-host captures do not demonstrate the changed usage-source flow. Please attach matching dialog captures and a short recording of selection, save and the resulting source status, report the lookup check and any live-provider limits, and request reconsideration. Reusing an established secret-resolver capability does not remove this evidence requirement.

@maria-rcks maria-rcks closed this Oct 31, 2026
@maria-rcks maria-rcks reopened this Oct 31, 2026
@maria-rcks

Copy link
Copy Markdown
Collaborator

Note

Written by claude-opus-5-5 on behalf of Maria

Reopening. An automated triage pass closed this by mistake; the closing comment above does not apply. Sorry for the noise.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500-999 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants