Repository navigation
Conversation
…ovider Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
78f0e33 to
08bd4b9
Compare
…secret providers Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…ed resolution Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…ts that failed or rotated Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
… read Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
ab502b2 to
968ca4a
Compare
…ngs cannot be read Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
968ca4a to
38dbfd9
Compare
…ovider's unlock Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
38dbfd9 to
15a5e79
Compare
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
15a5e79 to
8afaffd
Compare
…he API during discovery Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
8afaffd to
37b29f6
Compare
|
Note Written by This change lacks the UI evidence required by verification. AddUsageLimitSourceDialog replaces the management-key input with SecretSourceInput, but the PR supplies no before/after screenshots of that dialog or recording of choosing a reference and saving it. The focused resolver tests and parent source-control-host captures do not demonstrate the changed usage-source flow. Please attach matching dialog captures and a short recording of selection, save and the resulting source status, report the lookup check and any live-provider limits, and request reconsideration. Reusing an established secret-resolver capability does not remove this evidence requirement. |
|
Note Written by Reopening. An automated triage pass closed this by mistake; the closing comment above does not apply. Sorry for the noise. |
Problem
Stacked on #27756, whose commits this branch carries until they merge, so only the last commit is new here. A usage-limit source's management key still has to be pasted into T3 Code, so teams that keep credentials in 1Password cannot read it from there.
Change
Scope and approval
Third step of the stack that starts at #27746, reusing
SecretResolverandSecretSourceInputunchanged and gated by the same secrets feature flag. It adds no provider kind and no new setting.Verification
vp test run src/usage/UsageLimitSources.test.ts src/serverSettings.test.tsinapps/server: pass. Covers reading a key from a reference, and the clear failure when the provider cannot read it.vp run typecheck: pass.vp run check:changed: format, lint, knip, typecheck, react compiler pass. Eight tests inProviderEventIngestor.test.tsandCodexAdapterV2.test.tsfail in this environment; neither file is touched by this change.