[saddlepaddle]

Problem

Pasting rich text into a markdown editor could put it into a state where it silently stops saving. The pasted content appears on screen, but the editor's onChange never fires again and onBlur no longer saves — every later serialization of that document throws.

Reported as DESKTOP-1A6 (desktop 1.29.0, renderer, unhandled, on a paste event).

Root cause

@tiptap/core's default attribute parser runs element.getAttribute(name) through fromString, which coerces numeric- and boolean-looking strings:

function fromString(value) {
	if (typeof value !== "string") return value;
	if (value.match(/^[+-]?(?:\d*\.)?\d+$/)) return Number(value);
	if (value === "true") return true;
	if (value === "false") return false;
	return value;
}

Any attribute that does not declare its own parseHTML gets that treatment. @tiptap/extension-link declares title: { default: null } with no parseHTML (its href has one, which is why only title was exposed), so an anchor carrying title="2024" loads a link mark whose title is the number 2024. prosemirror-markdown then does:

mark.attrs.title ? ` "${mark.attrs.title.replace(/"/g, '\\"')}"` : ""

Truthy, not a string — TypeError. Both markdown surfaces serialize on every update (onUpdate → getMarkdown), so once such a link is in the document the throw repeats on every keystroke and nothing downstream ever receives the content again.

This is the same coercion #6663 fixed for image src/alt/title. That fix landed on SafeImage in the renderer and never reached MarkdownEditor, because the two surfaces keep separate copies of these extensions. So the editor had two live instances of the same crash class: the link title reported here, and image alt/title — LinearImage overrode only src, and only incidentally, to rewrite Linear-hosted URLs through the proxy.

Fix

Declare the verbatim parsing once, in renderer/lib/tiptap/markdown-attributes.ts, and use it from every extension that feeds the markdown serializer:

• verbatimStringAttributes(...names) — used by SafeImage (src/alt/title) and LinearImage (alt/title, composing with its own proxying src).
• SafeLink — one shared mark, imported by both extension lists, each still applying its own .configure().

renderer/lib/tiptap/ already exists and is already imported by both surfaces, so this adds no new coupling direction. Both files come out net smaller, and the duplication that let the earlier fix drift is gone.

No behaviour change for attributes that were already strings, and the Linear image proxy rewrite is untouched.

Verification

Reproduced first — the new tests fail on main with the exact production error:

484 |    : "](" + mark.attrs.href.replace(...) + (mark.attrs.title ? ` "${mark.attrs.title.replace(/"/g, '\"')}"` : "") + ")";
                                                                                  ^
TypeError: mark.attrs.title.replace is not a function.

(fail) link attribute parsing > keeps a numeric link title as a string and serializes it
(fail) link attribute parsing > keeps a boolean-looking link title as a string

 9 pass
 2 fail

After the fix:

$ cd apps/desktop && bun test src/renderer/components/MarkdownRenderer/components/TipTapMarkdownRenderer/
 66 pass
 0 fail
 151 expect() calls
Ran 66 tests across 5 files. [922.00ms]

$ bunx biome check <the four changed files>
Checked 4 files in 8ms. No fixes applied.

$ cd apps/desktop && bun run typecheck
$ tsc --noEmit      (clean)

The round-trip tests cover SafeLink and the helper — the code both surfaces now share, including the exact production path. LinearImage stays module-local inside MarkdownEditor.tsx and is covered by typecheck rather than by its own test; its extension list is built inline in the component, which cannot be mounted without the authenticated route provider tree.

No user-facing strings changed, so check:i18n does not apply.

Refs DESKTOP-1A6
Refs DESKTOP-100

Summary by CodeRabbit

• Bug Fixes

  • Fixed Markdown links and images so text-based attributes, including titles and alternative text such as “2024” or “true,” retain their original string values.
  • Improved Markdown round-tripping to preserve link titles and title-less links without unintended conversions.

• Tests

  • Added coverage for preserving link attributes and maintaining unchanged Markdown through editing and rendering.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 06d32ffa-0e53-49dd-b1c0-a26d87b76479

📥 Commits

Reviewing files that changed from the base of the PR and between 8d10ce6 and 359aefc.

📒 Files selected for processing (4)

• apps/desktop/src/renderer/components/MarkdownEditor/MarkdownEditor.tsx
• apps/desktop/src/renderer/components/MarkdownRenderer/components/TipTapMarkdownRenderer/createMarkdownExtensions.test.ts
• apps/desktop/src/renderer/components/MarkdownRenderer/components/TipTapMarkdownRenderer/createMarkdownExtensions.ts
• apps/desktop/src/renderer/lib/tiptap/markdown-attributes.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.

---

📝 Walkthrough

Walkthrough

The change adds shared verbatim attribute parsing for Tiptap links and images. The editor and renderer use SafeLink. Tests cover numeric, boolean-looking, and missing link titles.

Changes

Safe link title handling

Layer / File(s)	Summary
SafeLink implementation apps/desktop/src/renderer/lib/tiptap/markdown-attributes.ts	Adds verbatimStringAttributes and SafeLink. Link titles are parsed from HTML without type coercion.
Editor and renderer wiring apps/desktop/src/renderer/components/MarkdownEditor/MarkdownEditor.tsx, apps/desktop/src/renderer/components/MarkdownRenderer/components/TipTapMarkdownRenderer/createMarkdownExtensions.ts	Registers SafeLink and applies shared verbatim parsing to image attributes.
Link title round-trip tests apps/desktop/src/renderer/components/MarkdownRenderer/components/TipTapMarkdownRenderer/createMarkdownExtensions.test.ts	Tests numeric, boolean-looking, and missing link titles during markdown round trips.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: kitenite

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title uses conventional commit format and clearly describes the primary fix: preserving markdown link and image attributes as strings to prevent editor saving failures.
Description check	✅ Passed	The description clearly explains the problem, root cause, fix, affected components, and verification results. It does not include the template's explicit Checklist section, but the missing section is …
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch

Thank you for your contribution! 🎉