[Kitenite]

Summary

Follow-up to #7671. Deploy Production is disabled again until this merges.

On the first production run after #7671 (run 35466469044), the migration hit its 5 second lock timeout on automation_events, rolled back cleanly and drizzle-kit exited 1, which is the designed safe failure. The step still reported success, so the app deploys started against an unmigrated database. The run was cancelled before any app job reached its build step, so no app code shipped. Production stayed at 122 migrations applied and healthy throughout (peak 38 lock waiters for 3 seconds, connections flat at 77 to 79).

Cause: the retry loop added in #7671 pipes drizzle-kit migrate through tee to grep for a lost lock race. GitHub runs a step with no explicit shell: as bash -e {0}, without pipefail, so the pipeline's exit status was tee's. It was tested locally under bash -eo pipefail, which GitHub only uses when a step sets shell: bash.

Fix: the block sets pipefail itself.

Testing

Run with /bin/bash -e, the shell from the production log, against a Neon branch of production with 0119 pending:

Case	Result
Old block, lock held 12s	exit 0 after 6.3s, nothing applied (reproduces the bug)
New block, lock held past all 8 attempts	exit 1 after 228s, nothing applied, 8 retry warnings
New block, bad credentials	exit 1 after 0.7s, no retries
New block, lock held 14s	one retry, exit 0, applied 123
New block, nothing pending	exit 0

---

Summary by cubic

Fixes the production migration job so a failed migration can no longer pass as successful and start app deploys against an unmigrated database. The retry loop now sets pipefail, so the step exits with drizzle-kit's status instead of tee's when the lock times out. A new verification step fails the job unless the newest migration in the repo's journal is recorded in the database, and preview deploys run the same check. Deploy Production is disabled until this merges.

^{Written for commit a2fb18b. Summary will update on new commits.}

Summary by CodeRabbit

• Chores
  • Improved deployment reliability by ensuring database migration failures are detected correctly.
  • Failed migrations now properly trigger the configured retry behavior instead of being incorrectly reported as successful.
  • Added post-migration checks to confirm that the production and preview databases are fully up to date before deployment continues.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 2546819e-be9f-4f2e-9f60-1ec7f8cb9f59

📥 Commits

Reviewing files that changed from the base of the PR and between 83f770e and a2fb18b.

📒 Files selected for processing (3)

• .github/workflows/deploy-preview.yml
• .github/workflows/deploy-production.yml
• packages/db/src/verify-migrations-applied.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

Deployment workflows now verify that the latest migration is applied. The production migration retry loop also propagates failures through tee by enabling pipefail.

Changes

Migration verification

Layer / File(s)	Summary
Migration verifier packages/db/src/verify-migrations-applied.ts	The new script compares the latest migration journal entry with the newest applied database migration. It exits with code 1 when they differ or when the journal is empty.
Deployment integration .github/workflows/deploy-preview.yml, .github/workflows/deploy-production.yml	Preview and production deployments run the verifier after migration. Production enables set -o pipefail so migration failures are not masked by tee.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Bug fix

Suggested reviewers: saddlepaddle

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 2 …
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title uses conventional commit format and clearly describes the main change: preventing failed production migrations from being reported as successful.
Description check	✅ Passed	The description explains the problem, root cause, fix, and testing results in detail. It uses Summary and Testing headings instead of the template headings and omits the Checklist section, but it is o…

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Kitenite]

Added a second guard that does not depend on exit codes: a Verify migrations applied step after the migrate step. It compares the newest migration recorded in drizzle.__drizzle_migrations with the newest entry in packages/db/drizzle/meta/_journal.json and fails if they differ. The preview migrate step runs it too, so this PR's Deploy Database (Neon) check exercises it in GitHub's environment.

Checked under bash -e: exit 0 against a database at 0119, exit 1 against one still at 0118 ("Database is not at 0119_plugin_oauth_clients_and_connectors: newest applied migration is 1789546826052, expected 1789625882184").

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ✅ Neon database branch

Thank you for your contribution! 🎉

[expo]

No installed development build can load this pull request as an update: its native fingerprint is c68b78a2cc25 and no development build has it. Add the mobile-build label to build one.