[Waka07]

What & why

Markdown preview links were inert while editing. Route HTTP(S) link clicks through Settings → Links, sharing the terminal's URL actions: by default plain click places the caret, Shift-click opens a new tab, Cmd/Ctrl-click opens a split browser pane, and Cmd/Ctrl+Shift-click opens the system browser. Editable and read-only previews follow the same policy. Views without pane context retain the inline editor's external-browser fallback.

TipTap's native link opening stays disabled. The DOM click handler also handles Shift-clicks, which ProseMirror skips in its normal click handlers. Relative, anchor, and non-web links are ignored. Shared action and click-hint helpers move to their common parent without duplication.

Original fix by Waka07; policy rework co-authored with Waka07.

How I tested it

• 19 focused tests; 230 tests across MarkdownRenderer, pane registry, and click policy passed in the verification run. Three mutations confirmed the focused tests detect regressions.
• Desktop typecheck and Biome on changed files passed.
• Real dev-app CDP clicks verified all four modifier tiers, editable and read-only previews, live Settings changes, blocked schemes, and terminal link regression coverage.
• Manual user test confirmed link behavior and editing.
• Current-main merge-tree check passes.
• Evidence: https://app.superset.sh/page/external-pr-verification-evidence-18-sep-qjrdpw (version 6).

Limitations: the v1 fallback was typechecked but not exercised in-app; Shift-click also extends selection; no modifier hover label was added. No new user-facing strings.

Checklist

• PR title follows conventional commits (type(scope): subject)
• bun run lint and bun run typecheck pass (full CI green)
• "Allow edits from maintainers" is checked on fork PRs

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: a8049af6-26e3-491b-8e52-ce5c2eea7214

📥 Commits

Reviewing files that changed from the base of the PR and between 1b54731 and 521b19e.

📒 Files selected for processing (15)

• apps/desktop/src/renderer/components/MarkdownRenderer/components/TipTapMarkdownRenderer/TipTapMarkdownRenderer.tsx
• apps/desktop/src/renderer/components/MarkdownRenderer/components/TipTapMarkdownRenderer/createMarkdownExtensions.test.ts
• apps/desktop/src/renderer/components/MarkdownRenderer/components/TipTapMarkdownRenderer/createMarkdownExtensions.ts
• apps/desktop/src/renderer/components/MarkdownRenderer/components/TipTapMarkdownRenderer/resolveLinkClick.test.ts
• apps/desktop/src/renderer/components/MarkdownRenderer/components/TipTapMarkdownRenderer/resolveLinkClick.ts
• apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/FilePane/FilePane.tsx
• apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/FilePane/registry/types.ts
• apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/FilePane/registry/views/MarkdownPreviewView/MarkdownPreviewView.tsx
• apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/TerminalPane.tsx
• apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/contextMenuLinkStore.ts
• apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/hooks/useLinkClickHint/index.ts
• apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/hooks/useLinkClickHint/useLinkClickHint.ts
• apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/utils/openInActions/openInActions.ts
• apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/utils/runTerminalLinkAction/index.ts
• apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/utils/runTerminalLinkAction/runTerminalLinkAction.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

Markdown preview links now use explicit click policies. Supported clicks resolve to pane actions or the system browser, while unsupported and unbound clicks are handled without navigation. File panes provide routing callbacks, and preview views display unbound-link hints.

Changes

Markdown link routing

Layer / File(s)	Summary
Link resolution contract and tests apps/desktop/src/renderer/components/MarkdownRenderer/components/TipTapMarkdownRenderer/resolveLinkClick.ts, apps/desktop/src/renderer/components/MarkdownRenderer/components/TipTapMarkdownRenderer/resolveLinkClick.test.ts	resolveLinkClick classifies primary clicks on HTTP(S) links as none, unbound, or open. Tests cover modifier policies, custom tiers, unsupported schemes, non-link targets, and non-primary buttons.
Renderer click handling apps/desktop/src/renderer/components/MarkdownRenderer/components/TipTapMarkdownRenderer/TipTapMarkdownRenderer.tsx, apps/desktop/src/renderer/components/MarkdownRenderer/components/TipTapMarkdownRenderer/createMarkdownExtensions.ts, apps/desktop/src/renderer/components/MarkdownRenderer/components/TipTapMarkdownRenderer/createMarkdownExtensions.test.ts	The renderer disables default TipTap link opening and handles clicks through inline or terminal URL policies. It routes bound clicks to onOpenUrl or electronTrpcClient.external.openUrl, reports unbound coordinates, and covers shift-click handling.
Preview pane integration and action wiring apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/FilePane/*, apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/components/TerminalPane/*, apps/desktop/src/renderer/routes/_authenticated/_dashboard/v2-workspace/$workspaceId/hooks/usePaneRegistry/utils/*	File panes pass URL actions to Markdown previews. Previews show LinkHoverHint for unbound clicks. Shared terminal link-action imports are updated, and runUrlLinkAction accepts only the dependencies it uses.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Bug fix

Suggested reviewers: saddlepaddle

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 12 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title uses conventional commit format and clearly identifies the main change: Markdown preview links now follow the link click policy.
Description check	✅ Passed	The description includes complete What & why, How I tested it, and Checklist sections. It explains the behavior, testing coverage, limitations, and verification results.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}