[Kitenite]

What & why

When a root route fails, its error screen replaces the layout containing the language provider. The error screen then crashes in useLingui(), hiding the original exception and preventing its Sentry reporting effect from running.

Wrap the router in a Lingui provider backed by the shared i18n instance. Root error and not-found screens keep translation context and the active language even after the normal layout unmounts. Add an isolated regression test using real Lingui hooks and compiled macros, bypassing the desktop test suite's translation mocks.

This fixes the secondary crash shown in the report. The original trigger for the affected user is still unknown; their Sentry event, logs, or reproduction steps are needed to diagnose it.

How I tested it

• Passed bun run lint, bun run typecheck, and bun run check:plugins.
• Passed all six targeted RendererRouter and LanguageAwareI18nProvider tests.
• Regression coverage exercises root-layout exceptions, loader failures, and 404s; checks French translations, original error details, the Sentry capture call, and Go home recovery from loader errors and 404s.
• Removing the outer provider makes the regression test fail with a missing-I18nProvider error.
• bun run test failed: host-service tests and one desktop Git test report an unaccepted Xcode license; a desktop node-pty native symbol check also returns empty output. Desktop results: 3,928 passed, 2 failed. These failures are outside the changed renderer code.
• Verification is synthetic; no live-app before/after screenshots were captured, and the other user's exact journey was not reproduced.

Checklist

• PR title follows conventional commits (type(scope): subject)
• bun run lint and bun run typecheck pass (CI fails on lint warnings too)
• "Allow edits from maintainers" is checked on fork PRs (same-repository branch)

---

Summary by cubic

Desktop route error and not-found screens now retain the shared Lingui context instead of crashing in useLingui() after the normal layout unmounts. This keeps the original exception available for its Sentry report; the affected user's initial failure remains unidentified.

• Covers layout exceptions, loader failures, and 404s with real Lingui hooks and compiled macros, including localized fallback text and navigation recovery.
• 404 screens remain unreported as crashes, while exception screens show the original error details.
• Lint, type checking, and plugin checks pass; full-suite failures remain limited to unrelated Xcode-license and node-pty issues.
• Verification is synthetic and still needs the affected user's Sentry event, logs, or reproduction steps.

^{Written for commit 88409fd. Summary will update on new commits.}

Summary by CodeRabbit

• Bug Fixes
  • Improved route error handling so fallback screens retain the correct translation context.
  • Error details now display the original failure while preserving localized headings.
  • Not-found and other route failures recover correctly, allowing navigation back to the home screen.
  • Improved error reporting for unexpected route failures without affecting not-found handling.
  • Prevented translation-related errors from obscuring the original route failure.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: caf7a201-ff80-4a84-9c8d-8fc6717e31b4

📥 Commits

Reviewing files that changed from the base of the PR and between 144ed78 and 88409fd.

📒 Files selected for processing (1)

• apps/desktop/src/renderer/components/RendererRouter/fixtures/route-errors.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review.

---

📝 Walkthrough

Walkthrough

The renderer now uses RendererRouter to provide Lingui context around TanStack Router. An integration fixture tests route failures, translated fallbacks, error reporting, and recovery.

Changes

Renderer Router integration

Layer / File(s)	Summary
Lingui-aware router wrapper apps/desktop/src/renderer/components/RendererRouter/RendererRouter.tsx, apps/desktop/src/renderer/components/RendererRouter/index.ts, apps/desktop/src/renderer/index.tsx	RendererRouter initializes Lingui when no locale is set, renders RouterProvider inside I18nProvider, and replaces the direct provider in the renderer entry point.
Error fallback validation apps/desktop/src/renderer/components/RendererRouter/fixtures/route-errors.tsx, apps/desktop/src/renderer/components/RendererRouter/RendererRouter.test.ts	The fixture exercises layout, loader, and not-found failures. It checks translated fallbacks, locale state, error capture, console output, error details, and recovery. The test runs the fixture in a subprocess and checks for passed.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant RendererEntry
  participant RendererRouter
  participant I18nProvider
  participant RouterProvider
  RendererEntry->>RendererRouter: pass router
  RendererRouter->>I18nProvider: provide i18n context
  I18nProvider->>RouterProvider: render router

Loading

Merge Risk: ⚪ Minimal · up to 88409

Root error and not-found screens retain the bundled translation context, with no merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 5 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the primary change: preserving translation context for desktop route errors. It follows the required conventional commit format.
Description check	✅ Passed	The description includes complete What & why, How I tested it, and Checklist sections. It explains the change, test coverage, unrelated full-suite failures, and remaining diagnostic limits.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-issue-2

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

🧹 Preview Cleanup Complete

The following preview resources have been cleaned up:

• ⚠️ Neon database branch

Thank you for your contribution! 🎉