Sync 5.0.0 with main by shuyama1 · Pull Request #8523 · GoogleCloudPlatform/magic-modules

shuyama1 · 2023-08-02T19:02:15Z

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

…se. (#8401)

This reverts commit a3e513f.

Add `tpgresource.DurationDiffSuppress` to min / max backoff Fixes https://github.com/hashicorp/terraform-provider-google/issues/15166x

* Adding Support For resilience_mode field * Adding new field RESILIENCE_MODE_UNSPECIFIED * Added RESILIENCE_MODE_UNSPECIFIED in the docs * Removing the resilience mode test as the API is not yet launched * Adding test for high resilience and adding mapping * Fixing docs and flatten logic * Fixing expand method * Fixing flatten to accept empty Resilience_mode field --------- Co-authored-by: Khaled Hassan <hkhaled@google.com>

* Fixed tf-test prefixes for compute addresses * Reverted unused example changes * Reverted unnecessary change

* adding security_policy field in regionBackendService resource * fixing code review to use http calls instead of lib in RegionBackendService * removing ParseSecurityPolicyRegionalFieldValue method * fixing lint issue

* tgc build on tpg-beta * gcb-push-downstream.yml change ga to beta for tgc * fix forward rule test file * Address comment * compute forwarding rule test file set to beta * switch tgc-base to use beta * tgc make always use beta * generate downstream always use beta for tgc --------- Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>

Co-authored-by: Riley Karson <rileykarson@google.com>

* Add optional_components to documentation * Fix formatting, remove redundant optional * Clean up properties documentation * Apply suggestions from code review Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Add asterisks --------- Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Add comments, link to TeamCity Kotlin DSL docs * Change default value of environment from "public" to "default" This is because Google provider has no public TeamCity resources * Enable different default cron values for `ga`/`beta` downstreams * Enable non-default cron values to be used, based on value of `environment` parameter in TeamCity * Add ability to make VCS root and nightly trigger use non-main branch * Update tests to reflect how entrypoint func requires `branch` parameter now * Update `MAJOR_RELEASE_TESTING` value, and update code to handle unsupported chars * Update `uniqueID` method to uppercase the environment value

* fix enforce_on_key_configs * add updatemask --------- Co-authored-by: Edward Sun <sunedward@google.com>

* chore: replace tgc compare library to go-cmp * convert indent to tab * fix import

* Writing yaml Writing Succeeding Writing real yamls Refactor Refactor Stop reading output Update Remove extra puts, resource to_yaml method Spaces --> tabs Remove * Remove debugging * Spaces * Test * PR feedback, add rspec test Remove spec from folder * PR feedback, rename openapi_generate * Add comment

This reverts commit d5f1be7.

* Move function serviceAccountCanonicalEmail * Move provider tests * accessapproval tetss * Move activedirectory_test, appengine_test, bigquery_test, bigquerydatatransfer_test, bigtable_test * Move composer_test, cloudtasks_test, cloudrun_test, cloudiot_test, cloudids_test * Move compute_test * Move firestore_test * Move redis_test * Move storagetransfer_test * Fix errors * Move vpcaccess_test * Move apigee_test * Put function to test_utils.go to not break tgc * Remove spaces * Move resource_endpoints_service_test.go back to the google package * Fix rebasing errors

* Writing yaml Writing Succeeding Writing real yamls Refactor Refactor Stop reading output Update Remove extra puts, resource to_yaml method Spaces --> tabs Remove * Remove debugging * Spaces * Test * PR feedback, add rspec test Remove spec from folder * PR feedback, rename openapi_generate * Add comment * Attempt * Add async initialize defaults * Rubocop * Autofix rubocop

…a package for now (#8423)

…ackage (#8428) * Revert "Fix the folder to run sweepers (#8425)" This reverts commit 18d4037. * Revert "pre-sweeper and post-sweeper should only run in the google/google-beta package for now (#8423)" This reverts commit 762c77b.

…8426) This reverts commit 8ab7bd3.

This reverts commit 353dbb9.

* Adding custom_audiences field for cloud run v2 service. * Add custom audiences example for Cloud Run v2 API

)

* feat: added E2_MEDIUM as machine_type for cloud build triggers * feat: changed type to String * chore: reverted changes to previous version

…Clusters (#8492) * Allow setting enable_private_endpoint on creation time for PSC Based clusters * Update tests since enablePrivateEndpoint now can be set on cluster creation time * Put back accidentally removed test func

#8406) * Properly handle ABP midnight (hours = 0) * Add ExpectNonEmptyPlan to test * Add continuous backup config to alloydb cluster * add more unit tests * Adding more tests * Fix cluster.yaml lint * Add default value and update cmek test * Update test to use kms key bootstrapping util * condense update tests * Change encryptionType output field to string * use two different keys * Only update encryption in CBR

… notification configs. (#8507) * Add support for setting `sendPreviousResourceOnDelete` for FHIR store notification configs. * Add test for sendPreviousResourceOnDelete

) * adding both resources, basic test for serviceClass it's working, need to fix the test scenario for policy * fix the test scenario and the service class resource properties * adding a testing update, just adding the labels for the resource * added the resource service connection map, and it's basic test, need to evaluate * Revert "added the resource service connection map, and it's basic test, need to evaluate" This reverts commit 4240e1d. * removing the service class in one test scenario and using a static value * fix a typo * removing serviceClass and fix the tests * removing ga tag and updatinga etag for fingerprint type * updating the code, to remove the static value from the docs, need to test * adding a file to tpgtools override at product level * adding function to help with env var, but the patch on tests it's failing * adding the variable to be used in the docs * fixing the test, the network field cannot be immutable * removing the env_var service class and adding a static value * updating the value used from tests and documentation * removing unused resources for docs and tests * fix typos, not used variables and run the fmt * adding description to the basic test * fixed yaml variable override * removing unused resources for tests, and making the test fails with network as immutable * adding encoder to help network field be immutable and be sent on patch method

google-cla · 2023-08-02T19:02:54Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

shuyama1 · 2023-08-02T19:08:29Z

/gcbrun

shuyama1 · 2023-08-02T20:26:30Z

resolved the tgc downstream issues. kicking off a rerun now
/gcbrun

shuyama1 · 2023-08-02T20:48:26Z

/gcbrun

shuyama1 · 2023-08-02T21:13:11Z

/gcbrun

shuyama1 · 2023-08-02T21:46:57Z

/gcbrun

ibhaskar2 and others added 30 commits July 20, 2023 08:58

Added a not that failover_target is not supported for Postgres Databa…

23f0024

…se. (#8401)

Generate DCL tests to service packages (#8349)

353dbb9

This reverts commit a3e513f.

cloud_tasks_queue: supress permadiffs on backoff settings (#8359)

c9cc162

Add `tpgresource.DurationDiffSuppress` to min / max backoff Fixes https://github.com/hashicorp/terraform-provider-google/issues/15166x

Fix issue labeler to use service/ prefix instead of services/ (#8403)

8202745

Parallelize mmv1 build time (#8381)

eadb7f1

Fixed tf-test prefixes for compute addresses (#8398)

c5aa608

* Fixed tf-test prefixes for compute addresses * Reverted unused example changes * Reverted unnecessary change

Fix documentation formatting (#8365)

37c93c6

added contributing to 5.0.0 section (#8404)

4379e91

Co-authored-by: Riley Karson <rileykarson@google.com>

fix enforce_on_key_configs (#8165)

bea9ac7

* fix enforce_on_key_configs * add updatemask --------- Co-authored-by: Edward Sun <sunedward@google.com>

Tgc diff (#8379)

36ef8de

* chore: replace tgc compare library to go-cmp * convert indent to tab * fix import

Revert "Yaml writing (#8204)" (#8420)

a79bb13

This reverts commit d5f1be7.

copy go package data to downstream builder (#8386)

8c28b34

speed up file deletion in containerized build (#8384)

015b870

pre-sweeper and post-sweeper should only run in the google/google-bet…

762c77b

…a package for now (#8423)

Fix the folder to run sweepers (#8425)

18d4037

Revert "Move some handwritten acc tests to service package (#8400)" (#…

8ad92ee

…8426) This reverts commit 8ab7bd3.

Revert "Generate DCL tests to service packages (#8349)" (#8427)

63eca84

This reverts commit 353dbb9.

Adding custom_audiences field for cloud run v2 service. (#8290)

9b15705

* Adding custom_audiences field for cloud run v2 service. * Add custom audiences example for Cloud Run v2 API

Recorded additional quotas and enabled API for nightly tests (#8434)

2c4ae13

Read back empty maven_config field in artifactregistry_repository (#8383

0e4db60

)

Support for lastUpdatedPartitionConfig in Terraform (#8363)

2e90d01

melinath and others added 18 commits August 1, 2023 09:02

Exported enrolled_teams.yaml (#8504)

473705d

Added E2_MEDIUM as machine_type for CloudBuild triggers (#8489)

692134a

* feat: added E2_MEDIUM as machine_type for cloud build triggers * feat: changed type to String * chore: reverted changes to previous version

Add Ipv6 Reservation to Compute Instance (#8482)

eb2e834

fix: add updateMask to bqtransfer config updateurl (#8433)

b4ed168

Fix casing of databaseUrl (#8505)

9cd5995

Add timeouts for bare metal resources (#8513)

6acfb62

Add accelerators workstation config resource (#8490)

da45213

Add default from API on function upgrade generation field (#8515)

f9235bb

Promote local_ssd_recovery_timeout field to GA. (#8498)

ee36e93

Add support for policy_name field in Placement Policy (#8475)

a64f6d2

support master_global_access_config for flexible cluster (#8314)

024b343

Skip *_BetaBasicHandWritten tests that are consistently failing (#8476)

2a0393a

add test prefix to cloud build trigger tests (#8506)

d481f57

Add support for setting sendPreviousResourceOnDelete for FHIR store…

20768d5

… notification configs. (#8507) * Add support for setting `sendPreviousResourceOnDelete` for FHIR store notification configs. * Add test for sendPreviousResourceOnDelete

Update target size docs to call out lifecycle.ignore_changes (#8521)

9725f76

shuyama1 mentioned this pull request Aug 3, 2023

Sync 5.0.0 with main part 1 #8530

Merged

5 tasks

This was referenced Aug 3, 2023

Sync 5.0.0 with main part 1 hashicorp/terraform-provider-google-beta#6011

Merged

Sync 5.0.0 with main part 1 hashicorp/terraform-provider-google#15396

Merged

Sync 5.0.0 with main part 1 GoogleCloudPlatform/terraform-google-conversion#1243

Merged

shuyama1 closed this Aug 3, 2023

shuyama1 deleted the main_copy branch August 4, 2023 19:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sync 5.0.0 with main#8523

Sync 5.0.0 with main#8523
shuyama1 wants to merge 102 commits into
FEATURE-BRANCH-major-release-5.0.0from
main_copy

shuyama1 commented Aug 2, 2023

Uh oh!

google-cla Bot commented Aug 2, 2023

Uh oh!

shuyama1 commented Aug 2, 2023

Uh oh!

shuyama1 commented Aug 2, 2023

Uh oh!

shuyama1 commented Aug 2, 2023

Uh oh!

shuyama1 commented Aug 2, 2023

Uh oh!

shuyama1 commented Aug 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

shuyama1 commented Aug 2, 2023

Uh oh!

google-cla Bot commented Aug 2, 2023

Uh oh!

shuyama1 commented Aug 2, 2023

Uh oh!

shuyama1 commented Aug 2, 2023

Uh oh!

shuyama1 commented Aug 2, 2023

Uh oh!

shuyama1 commented Aug 2, 2023

Uh oh!

shuyama1 commented Aug 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants