Skip to content

Update target size docs to call out lifecycle.ignore_changes#8521

Merged
rileykarson merged 2 commits into
mainfrom
rileykarson-patch-7
Aug 2, 2023
Merged

Update target size docs to call out lifecycle.ignore_changes#8521
rileykarson merged 2 commits into
mainfrom
rileykarson-patch-7

Conversation

@rileykarson

Copy link
Copy Markdown
Member

Addresses yaqs/570067092187906048

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

@rileykarson rileykarson requested review from a team and NickElliot and removed request for a team August 2, 2023 17:27
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 6 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 2 files changed, 6 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@rileykarson rileykarson merged commit 9725f76 into main Aug 2, 2023
rainshen49 added a commit to rainshen49/magic-modules that referenced this pull request Aug 2, 2023
DanielRieske pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 2, 2023
simonebruzzechesse pushed a commit to simonebruzzechesse/magic-modules that referenced this pull request Aug 3, 2023
nevzheng pushed a commit to nevzheng/magic-modules that referenced this pull request Aug 3, 2023
jeperetz pushed a commit to jeperetz/magic-modules that referenced this pull request Aug 10, 2023
@rileykarson rileykarson deleted the rileykarson-patch-7 branch September 15, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants