Revert tc fix to avoid pre- and post-sweepers run for every service package#8428
Merged
Conversation
This reverts commit 18d4037.
Member
|
We need to find a way to run pre-sweeper and post-sweeper only once before and after all tests run with our new teamcity setup |
shuyama1
approved these changes
Jul 22, 2023
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2 files changed, 4 insertions(+), 5 deletions(-)) |
This was referenced Jul 22, 2023
epk
pushed a commit
to epk/magic-modules
that referenced
this pull request
Jul 24, 2023
…ackage (GoogleCloudPlatform#8428) * Revert "Fix the folder to run sweepers (GoogleCloudPlatform#8425)" This reverts commit 18d4037. * Revert "pre-sweeper and post-sweeper should only run in the google/google-beta package for now (GoogleCloudPlatform#8423)" This reverts commit 762c77b.
ericayyliu
pushed a commit
to ericayyliu/magic-modules
that referenced
this pull request
Jul 26, 2023
…ackage (GoogleCloudPlatform#8428) * Revert "Fix the folder to run sweepers (GoogleCloudPlatform#8425)" This reverts commit 18d4037. * Revert "pre-sweeper and post-sweeper should only run in the google/google-beta package for now (GoogleCloudPlatform#8423)" This reverts commit 762c77b.
NickElliot
pushed a commit
to NickElliot/magic-modules
that referenced
this pull request
Jul 31, 2023
…ackage (GoogleCloudPlatform#8428) * Revert "Fix the folder to run sweepers (GoogleCloudPlatform#8425)" This reverts commit 18d4037. * Revert "pre-sweeper and post-sweeper should only run in the google/google-beta package for now (GoogleCloudPlatform#8423)" This reverts commit 762c77b.
DanielRieske
pushed a commit
to bschaatsbergen/magic-modules
that referenced
this pull request
Aug 2, 2023
…ackage (GoogleCloudPlatform#8428) * Revert "Fix the folder to run sweepers (GoogleCloudPlatform#8425)" This reverts commit 18d4037. * Revert "pre-sweeper and post-sweeper should only run in the google/google-beta package for now (GoogleCloudPlatform#8423)" This reverts commit 762c77b.
hao-nan-li
pushed a commit
to hao-nan-li/magic-modules
that referenced
this pull request
Aug 9, 2023
…ackage (GoogleCloudPlatform#8428) * Revert "Fix the folder to run sweepers (GoogleCloudPlatform#8425)" This reverts commit 18d4037. * Revert "pre-sweeper and post-sweeper should only run in the google/google-beta package for now (GoogleCloudPlatform#8423)" This reverts commit 762c77b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit a7c143e actually is working and fixed the original issue in the command line to run the script. The reason to revert it is because of another bug, that the sweepers are run for every package.
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)