Skip to content

Move some handwritten acc tests to service package#8400

Merged
zli82016 merged 16 commits into
mainfrom
move-acc-tests-to-service-package-handwritten-only
Jul 21, 2023
Merged

Move some handwritten acc tests to service package#8400
zli82016 merged 16 commits into
mainfrom
move-acc-tests-to-service-package-handwritten-only

Conversation

@zli82016

@zli82016 zli82016 commented Jul 20, 2023

Copy link
Copy Markdown
Member

As we don't want to move all of the tests in one PR. The PR 8272 is going to be split into two PRs. This is the first PR.

  1. Move handwritten tests to the specific service packages
  2. Move function ServiceAccountCanonicalEmail to the envvar package
  3. Move function GetResourceAttributes to the tpgresource package

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@zli82016 zli82016 force-pushed the move-acc-tests-to-service-package-handwritten-only branch 2 times, most recently from 88cc01d to 6d938c8 Compare July 20, 2023 16:41
@zli82016

Copy link
Copy Markdown
Member Author

/gcbrun

@zli82016 zli82016 force-pushed the move-acc-tests-to-service-package-handwritten-only branch from 34d967a to b4ceb84 Compare July 20, 2023 17:23
@zli82016 zli82016 closed this Jul 20, 2023
@zli82016 zli82016 reopened this Jul 20, 2023
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 245 files changed, 550 insertions(+), 376 deletions(-))
Terraform Beta: Diff ( 245 files changed, 659 insertions(+), 384 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2872
Passed tests 2570
Skipped tests: 299
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeFirewallPolicyRule_multipleRules|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccEndpointsService_grpc

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccEndpointsService_grpc[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 244 files changed, 549 insertions(+), 375 deletions(-))
Terraform Beta: Diff ( 244 files changed, 658 insertions(+), 383 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2872
Passed tests 2571
Skipped tests: 299
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeFirewallPolicyRule_multipleRules|TestAccContainerAwsNodePool_BetaBasicHandWritten

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@zli82016 zli82016 force-pushed the move-acc-tests-to-service-package-handwritten-only branch from d84f839 to 44c4c6e Compare July 20, 2023 20:19
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 244 files changed, 549 insertions(+), 375 deletions(-))
Terraform Beta: Diff ( 244 files changed, 658 insertions(+), 383 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 244 files changed, 553 insertions(+), 379 deletions(-))
Terraform Beta: Diff ( 244 files changed, 662 insertions(+), 387 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@zli82016 zli82016 force-pushed the move-acc-tests-to-service-package-handwritten-only branch from a8f6330 to 36030c2 Compare July 20, 2023 21:19
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 244 files changed, 553 insertions(+), 379 deletions(-))
Terraform Beta: Diff ( 244 files changed, 662 insertions(+), 387 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2873
Passed tests 2572
Skipped tests: 299
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeFirewallPolicyRule_multipleRules|TestAccContainerAwsNodePool_BetaBasicHandWritten

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@zli82016 zli82016 requested a review from slevenick July 20, 2023 22:41
@zli82016 zli82016 force-pushed the move-acc-tests-to-service-package-handwritten-only branch from 36030c2 to c1761c5 Compare July 21, 2023 15:43
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 244 files changed, 553 insertions(+), 379 deletions(-))
Terraform Beta: Diff ( 244 files changed, 662 insertions(+), 387 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2874
Passed tests 2572
Skipped tests: 299
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeFirewallPolicyRule_multipleRules|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccSpannerDatabaseIamPolicy

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSpannerDatabaseIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@zli82016 zli82016 merged commit 8ab7bd3 into main Jul 21, 2023
zli82016 added a commit that referenced this pull request Jul 21, 2023
zli82016 added a commit that referenced this pull request Jul 22, 2023
epk pushed a commit to epk/magic-modules that referenced this pull request Jul 24, 2023
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
…rm#8400)

* Move function serviceAccountCanonicalEmail

* Move provider tests

* accessapproval tetss

* Move activedirectory_test, appengine_test, bigquery_test, bigquerydatatransfer_test, bigtable_test

* Move composer_test, cloudtasks_test, cloudrun_test, cloudiot_test, cloudids_test

* Move compute_test

* Move firestore_test

* Move redis_test

* Move storagetransfer_test

* Fix errors

* Move vpcaccess_test

* Move apigee_test

* Put function to test_utils.go to not break tgc

* Remove spaces

* Move resource_endpoints_service_test.go back to the google package

* Fix rebasing errors
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
NickElliot pushed a commit to NickElliot/magic-modules that referenced this pull request Jul 31, 2023
…rm#8400)

* Move function serviceAccountCanonicalEmail

* Move provider tests

* accessapproval tetss

* Move activedirectory_test, appengine_test, bigquery_test, bigquerydatatransfer_test, bigtable_test

* Move composer_test, cloudtasks_test, cloudrun_test, cloudiot_test, cloudids_test

* Move compute_test

* Move firestore_test

* Move redis_test

* Move storagetransfer_test

* Fix errors

* Move vpcaccess_test

* Move apigee_test

* Put function to test_utils.go to not break tgc

* Remove spaces

* Move resource_endpoints_service_test.go back to the google package

* Fix rebasing errors
NickElliot pushed a commit to NickElliot/magic-modules that referenced this pull request Jul 31, 2023
DanielRieske pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 2, 2023
…rm#8400)

* Move function serviceAccountCanonicalEmail

* Move provider tests

* accessapproval tetss

* Move activedirectory_test, appengine_test, bigquery_test, bigquerydatatransfer_test, bigtable_test

* Move composer_test, cloudtasks_test, cloudrun_test, cloudiot_test, cloudids_test

* Move compute_test

* Move firestore_test

* Move redis_test

* Move storagetransfer_test

* Fix errors

* Move vpcaccess_test

* Move apigee_test

* Put function to test_utils.go to not break tgc

* Remove spaces

* Move resource_endpoints_service_test.go back to the google package

* Fix rebasing errors
DanielRieske pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 2, 2023
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Aug 9, 2023
…rm#8400)

* Move function serviceAccountCanonicalEmail

* Move provider tests

* accessapproval tetss

* Move activedirectory_test, appengine_test, bigquery_test, bigquerydatatransfer_test, bigtable_test

* Move composer_test, cloudtasks_test, cloudrun_test, cloudiot_test, cloudids_test

* Move compute_test

* Move firestore_test

* Move redis_test

* Move storagetransfer_test

* Fix errors

* Move vpcaccess_test

* Move apigee_test

* Put function to test_utils.go to not break tgc

* Remove spaces

* Move resource_endpoints_service_test.go back to the google package

* Fix rebasing errors
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Aug 9, 2023
@zli82016 zli82016 deleted the move-acc-tests-to-service-package-handwritten-only branch November 29, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants