Move some handwritten acc tests to service package#8400
Conversation
88cc01d to
6d938c8
Compare
|
/gcbrun |
34d967a to
b4ceb84
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 245 files changed, 550 insertions(+), 376 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeFirewallPolicyRule_multipleRules|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccEndpointsService_grpc |
|
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 244 files changed, 549 insertions(+), 375 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeFirewallPolicyRule_multipleRules|TestAccContainerAwsNodePool_BetaBasicHandWritten |
|
|
d84f839 to
44c4c6e
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 244 files changed, 549 insertions(+), 375 deletions(-)) |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 244 files changed, 553 insertions(+), 379 deletions(-)) |
a8f6330 to
36030c2
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 244 files changed, 553 insertions(+), 379 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeFirewallPolicyRule_multipleRules|TestAccContainerAwsNodePool_BetaBasicHandWritten |
|
|
…atransfer_test, bigtable_test
36030c2 to
c1761c5
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 244 files changed, 553 insertions(+), 379 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeFirewallPolicyRule_multipleRules|TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccSpannerDatabaseIamPolicy |
|
Rerun these tests in REPLAYING mode to catch issues
|
…rm#8400) * Move function serviceAccountCanonicalEmail * Move provider tests * accessapproval tetss * Move activedirectory_test, appengine_test, bigquery_test, bigquerydatatransfer_test, bigtable_test * Move composer_test, cloudtasks_test, cloudrun_test, cloudiot_test, cloudids_test * Move compute_test * Move firestore_test * Move redis_test * Move storagetransfer_test * Fix errors * Move vpcaccess_test * Move apigee_test * Put function to test_utils.go to not break tgc * Remove spaces * Move resource_endpoints_service_test.go back to the google package * Fix rebasing errors
…rm#8400) * Move function serviceAccountCanonicalEmail * Move provider tests * accessapproval tetss * Move activedirectory_test, appengine_test, bigquery_test, bigquerydatatransfer_test, bigtable_test * Move composer_test, cloudtasks_test, cloudrun_test, cloudiot_test, cloudids_test * Move compute_test * Move firestore_test * Move redis_test * Move storagetransfer_test * Fix errors * Move vpcaccess_test * Move apigee_test * Put function to test_utils.go to not break tgc * Remove spaces * Move resource_endpoints_service_test.go back to the google package * Fix rebasing errors
…rm#8400) * Move function serviceAccountCanonicalEmail * Move provider tests * accessapproval tetss * Move activedirectory_test, appengine_test, bigquery_test, bigquerydatatransfer_test, bigtable_test * Move composer_test, cloudtasks_test, cloudrun_test, cloudiot_test, cloudids_test * Move compute_test * Move firestore_test * Move redis_test * Move storagetransfer_test * Fix errors * Move vpcaccess_test * Move apigee_test * Put function to test_utils.go to not break tgc * Remove spaces * Move resource_endpoints_service_test.go back to the google package * Fix rebasing errors
…rm#8400) * Move function serviceAccountCanonicalEmail * Move provider tests * accessapproval tetss * Move activedirectory_test, appengine_test, bigquery_test, bigquerydatatransfer_test, bigtable_test * Move composer_test, cloudtasks_test, cloudrun_test, cloudiot_test, cloudids_test * Move compute_test * Move firestore_test * Move redis_test * Move storagetransfer_test * Fix errors * Move vpcaccess_test * Move apigee_test * Put function to test_utils.go to not break tgc * Remove spaces * Move resource_endpoints_service_test.go back to the google package * Fix rebasing errors
As we don't want to move all of the tests in one PR. The PR 8272 is going to be split into two PRs. This is the first PR.
ServiceAccountCanonicalEmailto theenvvarpackageGetResourceAttributesto thetpgresourcepackageIf this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)