Skip to content

Read back empty maven_config field in artifactregistry_repository#8383

Merged
rileykarson merged 1 commit into
GoogleCloudPlatform:mainfrom
Subserial:AR-maven-equal-empty
Jul 24, 2023
Merged

Read back empty maven_config field in artifactregistry_repository#8383
rileykarson merged 1 commit into
GoogleCloudPlatform:mainfrom
Subserial:AR-maven-equal-empty

Conversation

@Subserial

@Subserial Subserial commented Jul 18, 2023

Copy link
Copy Markdown
Contributor

Fixes #terraform-provider-google/14900

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

artifactregistry: fixed reading back maven_config state in `google_artifact_registry_repository`

@modular-magician

Copy link
Copy Markdown
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @rileykarson, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 18, 2023
Comment thread mmv1/products/artifactregistry/Repository.yaml
MavenRepositoryConfig is maven related repository details.
Provides additional configuration details for repositories of the maven
format type.
allow_empty_object: true

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably doing nothing here- did you find it was required?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The request returns mavenConfig: {}, and Terraform reads this as null. This value allows the defaults to fill out the object and correctly compare configurations.

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 19, 2023
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 10 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 1 file changed, 10 insertions(+), 4 deletions(-))
TF Conversion: Diff ( 3 files changed, 9 insertions(+), 4 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2864
Passed tests 2561
Skipped tests: 299
Affected tests: 4

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeInstance_minCpuPlatform|TestAccComputeFirewallPolicyRule_multipleRules|TestAccFrameworkProviderBasePath_setInvalidBasePath

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstance_minCpuPlatform[Debug log]
TestAccFrameworkProviderBasePath_setInvalidBasePath[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@Subserial

Copy link
Copy Markdown
Contributor Author

I'm not sure if I have control over the failing tests.

@rileykarson

Copy link
Copy Markdown
Member

Those are both unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants