Read back empty maven_config field in artifactregistry_repository#8383
Conversation
|
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @rileykarson, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
| MavenRepositoryConfig is maven related repository details. | ||
| Provides additional configuration details for repositories of the maven | ||
| format type. | ||
| allow_empty_object: true |
There was a problem hiding this comment.
This is probably doing nothing here- did you find it was required?
There was a problem hiding this comment.
The request returns mavenConfig: {}, and Terraform reads this as null. This value allows the defaults to fill out the object and correctly compare configurations.
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 10 insertions(+), 4 deletions(-)) |
Tests analyticsTotal tests: Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeInstance_minCpuPlatform|TestAccComputeFirewallPolicyRule_multipleRules|TestAccFrameworkProviderBasePath_setInvalidBasePath |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
I'm not sure if I have control over the failing tests. |
|
Those are both unrelated |
Fixes #terraform-provider-google/14900
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)