Skip to content

Revert "Move some handwritten acc tests to service package (#8400)"#8426

Merged
zli82016 merged 1 commit into
mainfrom
revert-handwritten-tests
Jul 22, 2023
Merged

Revert "Move some handwritten acc tests to service package (#8400)"#8426
zli82016 merged 1 commit into
mainfrom
revert-handwritten-tests

Conversation

@zli82016

Copy link
Copy Markdown
Member

This reverts commit 8ab7bd3.

There is a bug in the teamcity when running sweepers. Revert the RP before it is fixed.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@zli82016 zli82016 requested a review from slevenick July 21, 2023 22:57
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 261 files changed, 413 insertions(+), 587 deletions(-))
Terraform Beta: Diff ( 244 files changed, 387 insertions(+), 662 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@zli82016 zli82016 requested a review from shuyama1 July 21, 2023 23:05
@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2874
Passed tests 2573
Skipped tests: 299
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeFirewallPolicyRule_multipleRules|TestAccContainerAwsNodePool_BetaBasicHandWritten

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@zli82016 zli82016 merged commit 8ad92ee into main Jul 22, 2023
@zli82016 zli82016 deleted the revert-handwritten-tests branch July 22, 2023 00:32
epk pushed a commit to epk/magic-modules that referenced this pull request Jul 24, 2023
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
NickElliot pushed a commit to NickElliot/magic-modules that referenced this pull request Jul 31, 2023
DanielRieske pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 2, 2023
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants