Add default from API on function upgrade generation field#8515
Conversation
This field is causing upgrade in place errors because the object seems like it's being updated when it's not. We want to default from the API when possible so that we can resolve this issue.
|
Hello! I am a robot. It looks like you are a community contributor. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 1 file changed, 1 insertion(+)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccSpannerDatabaseIamPolicy|TestAccContainerAwsNodePool_BetaBasicHandWritten |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
Test failures are unrelated to this change. |
This field is causing upgrade in place errors because the object seems like it's being updated when it's not. We want to default from the API when possible so that we can resolve this issue.
fixes hashicorp/terraform-provider-google#15249
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.