speed up file deletion in containerized build#8384
Merged
Conversation
ScottSuarez
requested review from
a team and
slevenick
and removed request for
a team
ScottSuarez
changed the title
slevenick
approved these changes
Jul 19, 2023
epk
pushed a commit
to epk/magic-modules
that referenced
this pull request
Jul 24, 2023
ericayyliu
pushed a commit
to ericayyliu/magic-modules
that referenced
this pull request
Jul 26, 2023
NickElliot
pushed a commit
to NickElliot/magic-modules
that referenced
this pull request
Jul 31, 2023
DanielRieske
pushed a commit
to bschaatsbergen/magic-modules
that referenced
this pull request
Aug 2, 2023
hao-nan-li
pushed a commit
to hao-nan-li/magic-modules
that referenced
this pull request
Aug 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current command is slow because -exec spawns a new git rm process for every single file. Changing this to xargs so we can batch the deletion together.
https://www.everythingcli.org/find-exec-vs-find-xargs/#:~:text=grep%20%5B...%5D%20file5001%20file5002%20...-,1.5%20Performance,-Let%E2%80%99s%20see%20how
Release Note Template for Downstream PRs (will be copied)