fix: expose running terminals and prevent setup install stalls

[Yash-Singh1]

The sidebar showed running terminals without a way to open them. Opening an empty terminal drawer could create a new shell instead of revealing a server-created setup terminal. Worktree setup could also wait indefinitely for install confirmation.

The running-terminal indicator now opens the existing terminal in its thread and environment, including terminals in a split panel. Opening an empty drawer reuses an existing server session. Worktree setup passes pnpm's --yes flag through vp i and closes stdin.

Validation: 17 focused terminal state tests passed, web typecheck passed, and targeted lint passed before submission. A client test verified that the indicator reveals the waiting setup terminal and Ctrl+C stops it. An install fixture confirmed that the unattended command completes when pnpm needs to recreate node_modules.

Model: GPT 6.1 Sol. Harness: Codex.

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — The PR adds a new actionable sidebar workflow for revealing running terminals and changes terminal-panel state behavior across multiple production UI paths. The setup-script adjustment is localized to developer worktree setup, but the new user-facing terminal capability warrants human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	5.0 KiB	5.0 KiB	0 B (0.0%)	6.8 KiB	✅
Codex	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Codex	Live turn WebSocket wire	1.2 KiB	1.2 KiB	0 B (0.0%)	2.0 KiB	✅
Codex	Live turn WebSocket decoded	20.9 KiB	20.9 KiB	0 B (0.0%)	29.3 KiB	✅
Codex	Live turn messages	2	2	0 (0.0%)	8	✅
Claude	Total thread wire	5.0 KiB	5.0 KiB	−24 B (−0.5%)	6.8 KiB	✅
Claude	Thread snapshot wire	3.8 KiB	3.8 KiB	0 B (0.0%)	4.9 KiB	✅
Claude	Live turn WebSocket wire	1.2 KiB	1.2 KiB	−24 B (−2.0%)	2.0 KiB	✅
Claude	Live turn WebSocket decoded	21.2 KiB	21.2 KiB	−41 B (−0.2%)	29.3 KiB	✅
Claude	Live turn messages	2	1	−1 (−50.0%)	8	✅

Baseline: 9e55228 · PR result: f20fcce · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 108.5 KiB
• Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Dismissing prior approval to re-evaluate f20fcce

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Team
• Run ID: 36e6048a-402c-4020-8a09-6f4d83ffcba6

---

📥 Commits

Reviewing files that changed from the base of the PR and between 9e55228 and f20fcce.

---

📒 Files selected for processing (7)

• apps/web/src/components/ChatView.tsx
• apps/web/src/components/LegacySidebar.tsx
• apps/web/src/components/Sidebar.tsx
• apps/web/src/components/ThreadStatusIndicators.tsx
• apps/web/src/lib/revealThreadTerminal.test.ts
• apps/web/src/lib/revealThreadTerminal.ts
• scripts/setup-worktree.ts

---

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

---

---

📝 Walkthrough

Walkthrough

The chat drawer can reuse an existing terminal. Sidebar terminal indicators now reveal a terminal and activate its thread. The worktree setup script runs dependency installation with stdin closed.

Changes

Terminal access

Layer / File(s)	Summary
Reveal terminals in the right panel apps/web/src/lib/revealThreadTerminal.ts, apps/web/src/lib/revealThreadTerminal.test.ts	revealThreadTerminal activates a terminal in an existing right-panel surface or opens it in terminal UI state. Tests cover setup terminals, closed panels, split selection, and local and remote state.
Add terminal actions to sidebar indicators apps/web/src/components/ThreadStatusIndicators.tsx, apps/web/src/components/LegacySidebar.tsx, apps/web/src/components/Sidebar.tsx	ThreadTerminalStatusButton displays a process count and reveals the first terminal when clicked. Both sidebar implementations use the button and pass the thread activation callback.
Reuse running terminals in the chat drawer apps/web/src/components/ChatView.tsx	When the drawer has no terminal IDs, it selects a running terminal not shown in a panel, or falls back to an eligible server-ordered terminal ID. It opens and activates the selected terminal without issuing a new terminal-open command.

Worktree setup

Layer / File(s)	Summary
Run dependency installation without stdin scripts/setup-worktree.ts	The install command now forwards --yes through vp and ignores stdin while inheriting stdout and stderr.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant Sidebar
  participant ThreadTerminalStatusButton
  participant revealThreadTerminal
  participant RightPanelSurface
  ThreadTerminalStatusButton->>revealThreadTerminal: Reveal the first terminal ID
  revealThreadTerminal->>RightPanelSurface: Activate containing surface or open terminal
  ThreadTerminalStatusButton->>Sidebar: Activate thread

Loading

Suggested reviewers: maria-rcks

---

Merge Risk: ⚪ Minimal · up to f20fc

No confirmed issue blocks merging. Whether opening the drawer should reuse an exited terminal remains unclear.

Pre-merge checks | 3 | 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check		The description explains the problem, the changes, and focused verification results. It does not include the required Scope and approval section, and it omits before/after screenshots required for the…	Add a Scope and approval section with the linked issue or maintainer approval, or explain why this focused fix qualifies without prior approval. Add clear before/after UI screenshots and a recording if interaction timing or motion needs dem…

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check		The title clearly summarizes both primary fixes: exposing running terminals and preventing setup install stalls.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

---

Full details: Description check

Explanation

The description explains the problem, the changes, and focused verification results. It does not include the required Scope and approval section, and it omits before/after screenshots required for the UI changes.

Resolution

Add a Scope and approval section with the linked issue or maintainer approval, or explain why this focused fix qualifies without prior approval. Add clear before/after UI screenshots and a recording if interaction timing or motion needs demonstration.

---

• Fix all pre-merge checks with AI

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

---

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}