Repository navigation
fix(desktop): keep annotation comment direction independent of host page - #11005
Merged
maria-rcks merged 2 commits intoOct 11, 2026
Merged
Conversation
The preview annotation overlay inherited its text direction from the inspected page's document, so RTL comments (Arabic, Hebrew, Persian) were misaligned on LTR pages, and forcing the host page to RTL mirrored the entire annotation toolbar instead of only the comment text. Pin the overlay host/root to dir="ltr" so the annotation chrome always has a stable layout, and set dir="auto" on the comment textarea so its direction is inferred from the typed content instead of inherited. Fixes pingdotgg#4644 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused three-line fix that isolates the desktop annotation overlay's layout direction from the inspected page while allowing comment text to follow its own content direction. Its runtime impact is limited to annotation UI presentation, with no schema, infrastructure, security, billing, or static-analysis changes. Notes:
You can add or adjust custom eligibility rules. Learn more. |
macroscopeapp
Bot
dismissed
their stale review
October 1, 2026 17:32
Dismissing prior approval to re-evaluate 0967483
maria-rcks
enabled auto-merge (squash)
October 11, 2026 02:58
github-actions Bot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Oct 11, 2026
## What's Changed * perf(server): drive shell last-error lookup from thread bindings by @only21mil in pingdotgg/t3code#17842 * perf(server): skip parsing plain terminal history output by @StiensWout in pingdotgg/t3code#17179 * perf(server): batch terminal history writes every 250 ms by @StiensWout in pingdotgg/t3code#17183 * perf(server): storage cleanup no longer runs a full status or size walk for worktrees it keeps by @tris203 in pingdotgg/t3code#17911 * perf(usage): usage scans skip OpenCode legacy messages older than the window by @tris203 in pingdotgg/t3code#17254 * perf(usage): OpenCode legacy walk stats entries before checking for symlinks by @tris203 in pingdotgg/t3code#17638 * fix(web): MCP app permission prompts no longer overflow the screen by @juliusmarminge in pingdotgg/t3code#17962 * feat(provider-antigravity): support subscription quota and usage limits by @Maseeek in pingdotgg/t3code#17530 * fix(desktop): keep generated annotation styles in sync by @t3-code[bot] in pingdotgg/t3code#17838 * fix(web): Resume continues on the model picked in the composer by @akbarakma in pingdotgg/t3code#17867 * fix(devices): bump agent-device to 0.21.24 for native Windows hosts by @TanJeeSchuan in pingdotgg/t3code#17706 * fix(web): keybinding group headings no longer touch the group above by @fixfon in pingdotgg/t3code#17766 * feat(web): configure OpenTelemetry exports in diagnostics by @MatthewFeroz in pingdotgg/t3code#12538 * docs: update user count to 500k by @Kamkmgamer in pingdotgg/t3code#17783 * fix(mobile): working pill no longer bulges on its right end by @id0Sch in pingdotgg/t3code#16143 * perf(opencode): stop retaining every message of a loaded OpenCode thread by @tris203 in pingdotgg/t3code#17784 * fix(web): switch thumbs stay in their track while scrolling by @raphaelpra in pingdotgg/t3code#15240 * fix(keybindings): thread jumps no longer overlap model picker jumps by @Fluffy-Bunny-23 in pingdotgg/t3code#14475 * fix(mobile): restore QR scanning in iPad pairing sheet by @arhammahajan in pingdotgg/t3code#16019 * fix(server): delegated Muse tasks no longer ask approval for every command by @t3dotgg in pingdotgg/t3code#18065 * fix(codex): prevent unsupported agent history in ChatGPT sharing by @connwalk in pingdotgg/t3code#17499 * fix(server): disabled providers stop checking for CLI updates by @yordis in pingdotgg/t3code#16772 * fix(mobile): round Android queued message sheet corners by @PixPMusic in pingdotgg/t3code#14934 * fix(ssh): record the archive lock owner's real PID by @Gigioxx in pingdotgg/t3code#14598 * fix(desktop): keep annotation comment direction independent of host page by @abdelrhmanehab10 in pingdotgg/t3code#11005 * fix(ssh): qualify runner script builders in tunnel test by @juliusmarminge in pingdotgg/t3code#18078 * fix(web): keep thread links open until the shell is live by @saphid in pingdotgg/t3code#14697 * fix(web): scope PR title collapse to tab scrollers by @Adamulek123 in pingdotgg/t3code#14644 * fix(server): detect fork PRs for branches without upstreams by @Adamulek123 in pingdotgg/t3code#13894 * fix(search): find threads by their branch PR number by @tris203 in pingdotgg/t3code#14658 * feat(web): show Claude workflow phases and members in Lineage by @Bil0000 in pingdotgg/t3code#12598 * fix(mobile): round Android Agents sheet corners by @PixPMusic in pingdotgg/t3code#14925 * fix(web): the Usage page sends a signed-out browser to pairing by @AdEx-Partners-DE in pingdotgg/t3code#17938 * fix(server): OpenCode 2 continuations end after a reconnect took a Stop's end by @juliusmarminge in pingdotgg/t3code#14744 * fix(server): OpenCode 2 continuations replay only their own background reply by @juliusmarminge in pingdotgg/t3code#14752 * fix(server): ACP reapplies a model after a switch away from it failed partway by @juliusmarminge in pingdotgg/t3code#14723 * fix(web): focus settings search with command-f by @extoci in pingdotgg/t3code#17859 * fix(mobile): keep Android project paths on one line by @wellorbetter in pingdotgg/t3code#14178 * fix(web): unpin preview dragging on narrow chat canvases by @MatthewFeroz in pingdotgg/t3code#15556 * fix(web): thread details toggle no longer covers the thread title on Windows desktop by @freddy-d in pingdotgg/t3code#16869 * fix(server): a directory no longer resolves as the resource monitor binary by @Furox-Art in pingdotgg/t3code#16838 * fix(server): a Claude usage limit no longer resets the context meter to 0% by @Vantrongs in pingdotgg/t3code#16394 * fix(server): GitLab merge requests can expand unchanged lines by @ScottN-PV in pingdotgg/t3code#17528 * fix(provider-cursor): a skill tree deeper than the scan limit no longer hides every skill by @ScottN-PV in pingdotgg/t3code#17389 * fix(web): pass hex theme colors to HTML renders by @RustedAperture in pingdotgg/t3code#16325 * fix(web): align the API estimate info icon by @RakshithBhat03 in pingdotgg/t3code#15655 * test(server): ACP teardown tests pass on Windows hosts by @sheehanmunim in pingdotgg/t3code#17080 * fix(server): sync device tool license versions with installer pins by @Yash-Singh1 in pingdotgg/t3code#18121 * fix: sync model favorites and visibility across clients by @jakeleventhal in pingdotgg/t3code#16816 * chore(deps-dev): bump compression from 1.8.1 to 1.8.2 in the npm_and_yarn group across 1 directory by @dependabot[bot] in pingdotgg/t3code#16309 * fix(server): update fff to stop runaway watcher rescans by @realhasanshoaib in pingdotgg/t3code#14543 * fix(mobile): license generation works with filtered installs by @Yash-Singh1 in pingdotgg/t3code#18127 * fix(mobile): image-only messages ask the agent to respond, like desktop by @whoisaldo in pingdotgg/t3code#16480 ## New Contributors * @Maseeek made their first contribution in pingdotgg/t3code#17530 * @TanJeeSchuan made their first contribution in pingdotgg/t3code#17706 * @fixfon made their first contribution in pingdotgg/t3code#17766 * @id0Sch made their first contribution in pingdotgg/t3code#16143 * @raphaelpra made their first contribution in pingdotgg/t3code#15240 * @Fluffy-Bunny-23 made their first contribution in pingdotgg/t3code#14475 * @arhammahajan made their first contribution in pingdotgg/t3code#16019 * @connwalk made their first contribution in pingdotgg/t3code#17499 * @abdelrhmanehab10 made their first contribution in pingdotgg/t3code#11005 * @AdEx-Partners-DE made their first contribution in pingdotgg/t3code#17938 * @wellorbetter made their first contribution in pingdotgg/t3code#14178 * @freddy-d made their first contribution in pingdotgg/t3code#16869 * @Furox-Art made their first contribution in pingdotgg/t3code#16838 * @RustedAperture made their first contribution in pingdotgg/t3code#16325 * @sheehanmunim made their first contribution in pingdotgg/t3code#17080 * @realhasanshoaib made their first contribution in pingdotgg/t3code#14543 * @whoisaldo made their first contribution in pingdotgg/t3code#16480 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261011.2955...v0.0.46-nightly.20261011.2967 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261011.2967
github-actions Bot
added a commit
to davidvanderklay/t3code-flake
that referenced
this pull request
Oct 11, 2026
## What's Changed * perf(server): drive shell last-error lookup from thread bindings by @only21mil in pingdotgg/t3code#17842 * perf(server): skip parsing plain terminal history output by @StiensWout in pingdotgg/t3code#17179 * perf(server): batch terminal history writes every 250 ms by @StiensWout in pingdotgg/t3code#17183 * perf(server): storage cleanup no longer runs a full status or size walk for worktrees it keeps by @tris203 in pingdotgg/t3code#17911 * perf(usage): usage scans skip OpenCode legacy messages older than the window by @tris203 in pingdotgg/t3code#17254 * perf(usage): OpenCode legacy walk stats entries before checking for symlinks by @tris203 in pingdotgg/t3code#17638 * fix(web): MCP app permission prompts no longer overflow the screen by @juliusmarminge in pingdotgg/t3code#17962 * feat(provider-antigravity): support subscription quota and usage limits by @Maseeek in pingdotgg/t3code#17530 * fix(desktop): keep generated annotation styles in sync by @t3-code[bot] in pingdotgg/t3code#17838 * fix(web): Resume continues on the model picked in the composer by @akbarakma in pingdotgg/t3code#17867 * fix(devices): bump agent-device to 0.21.24 for native Windows hosts by @TanJeeSchuan in pingdotgg/t3code#17706 * fix(web): keybinding group headings no longer touch the group above by @fixfon in pingdotgg/t3code#17766 * feat(web): configure OpenTelemetry exports in diagnostics by @MatthewFeroz in pingdotgg/t3code#12538 * docs: update user count to 500k by @Kamkmgamer in pingdotgg/t3code#17783 * fix(mobile): working pill no longer bulges on its right end by @id0Sch in pingdotgg/t3code#16143 * perf(opencode): stop retaining every message of a loaded OpenCode thread by @tris203 in pingdotgg/t3code#17784 * fix(web): switch thumbs stay in their track while scrolling by @raphaelpra in pingdotgg/t3code#15240 * fix(keybindings): thread jumps no longer overlap model picker jumps by @Fluffy-Bunny-23 in pingdotgg/t3code#14475 * fix(mobile): restore QR scanning in iPad pairing sheet by @arhammahajan in pingdotgg/t3code#16019 * fix(server): delegated Muse tasks no longer ask approval for every command by @t3dotgg in pingdotgg/t3code#18065 * fix(codex): prevent unsupported agent history in ChatGPT sharing by @connwalk in pingdotgg/t3code#17499 * fix(server): disabled providers stop checking for CLI updates by @yordis in pingdotgg/t3code#16772 * fix(mobile): round Android queued message sheet corners by @PixPMusic in pingdotgg/t3code#14934 * fix(ssh): record the archive lock owner's real PID by @Gigioxx in pingdotgg/t3code#14598 * fix(desktop): keep annotation comment direction independent of host page by @abdelrhmanehab10 in pingdotgg/t3code#11005 * fix(ssh): qualify runner script builders in tunnel test by @juliusmarminge in pingdotgg/t3code#18078 * fix(web): keep thread links open until the shell is live by @saphid in pingdotgg/t3code#14697 * fix(web): scope PR title collapse to tab scrollers by @Adamulek123 in pingdotgg/t3code#14644 * fix(server): detect fork PRs for branches without upstreams by @Adamulek123 in pingdotgg/t3code#13894 * fix(search): find threads by their branch PR number by @tris203 in pingdotgg/t3code#14658 * feat(web): show Claude workflow phases and members in Lineage by @Bil0000 in pingdotgg/t3code#12598 * fix(mobile): round Android Agents sheet corners by @PixPMusic in pingdotgg/t3code#14925 * fix(web): the Usage page sends a signed-out browser to pairing by @AdEx-Partners-DE in pingdotgg/t3code#17938 * fix(server): OpenCode 2 continuations end after a reconnect took a Stop's end by @juliusmarminge in pingdotgg/t3code#14744 * fix(server): OpenCode 2 continuations replay only their own background reply by @juliusmarminge in pingdotgg/t3code#14752 * fix(server): ACP reapplies a model after a switch away from it failed partway by @juliusmarminge in pingdotgg/t3code#14723 * fix(web): focus settings search with command-f by @extoci in pingdotgg/t3code#17859 * fix(mobile): keep Android project paths on one line by @wellorbetter in pingdotgg/t3code#14178 * fix(web): unpin preview dragging on narrow chat canvases by @MatthewFeroz in pingdotgg/t3code#15556 * fix(web): thread details toggle no longer covers the thread title on Windows desktop by @freddy-d in pingdotgg/t3code#16869 * fix(server): a directory no longer resolves as the resource monitor binary by @Furox-Art in pingdotgg/t3code#16838 * fix(server): a Claude usage limit no longer resets the context meter to 0% by @Vantrongs in pingdotgg/t3code#16394 * fix(server): GitLab merge requests can expand unchanged lines by @ScottN-PV in pingdotgg/t3code#17528 * fix(provider-cursor): a skill tree deeper than the scan limit no longer hides every skill by @ScottN-PV in pingdotgg/t3code#17389 * fix(web): pass hex theme colors to HTML renders by @RustedAperture in pingdotgg/t3code#16325 * fix(web): align the API estimate info icon by @RakshithBhat03 in pingdotgg/t3code#15655 * test(server): ACP teardown tests pass on Windows hosts by @sheehanmunim in pingdotgg/t3code#17080 * fix(server): sync device tool license versions with installer pins by @Yash-Singh1 in pingdotgg/t3code#18121 * fix: sync model favorites and visibility across clients by @jakeleventhal in pingdotgg/t3code#16816 * chore(deps-dev): bump compression from 1.8.1 to 1.8.2 in the npm_and_yarn group across 1 directory by @dependabot[bot] in pingdotgg/t3code#16309 * fix(server): update fff to stop runaway watcher rescans by @realhasanshoaib in pingdotgg/t3code#14543 * fix(mobile): license generation works with filtered installs by @Yash-Singh1 in pingdotgg/t3code#18127 * fix(mobile): image-only messages ask the agent to respond, like desktop by @whoisaldo in pingdotgg/t3code#16480 ## New Contributors * @Maseeek made their first contribution in pingdotgg/t3code#17530 * @TanJeeSchuan made their first contribution in pingdotgg/t3code#17706 * @fixfon made their first contribution in pingdotgg/t3code#17766 * @id0Sch made their first contribution in pingdotgg/t3code#16143 * @raphaelpra made their first contribution in pingdotgg/t3code#15240 * @Fluffy-Bunny-23 made their first contribution in pingdotgg/t3code#14475 * @arhammahajan made their first contribution in pingdotgg/t3code#16019 * @connwalk made their first contribution in pingdotgg/t3code#17499 * @abdelrhmanehab10 made their first contribution in pingdotgg/t3code#11005 * @AdEx-Partners-DE made their first contribution in pingdotgg/t3code#17938 * @wellorbetter made their first contribution in pingdotgg/t3code#14178 * @freddy-d made their first contribution in pingdotgg/t3code#16869 * @Furox-Art made their first contribution in pingdotgg/t3code#16838 * @RustedAperture made their first contribution in pingdotgg/t3code#16325 * @sheehanmunim made their first contribution in pingdotgg/t3code#17080 * @realhasanshoaib made their first contribution in pingdotgg/t3code#14543 * @whoisaldo made their first contribution in pingdotgg/t3code#16480 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261011.2955...v0.0.46-nightly.20261011.2967 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261011.2967
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
The preview annotation overlay now forces its own
dir="ltr"on the overlay host, so the toolbar, editor, and element labels keep a stable layout regardless of the inspected page's direction. The comment textarea usesdir="auto", so Arabic, Hebrew, Persian, and other RTL comments start from the right and keep readable bidi ordering, while LTR comments are unchanged.Fixes #4644
Why
The annotation
<textarea>had nodirattribute and the overlay inherited direction from the inspected document. On an LTR page an Arabic comment was anchored to the left and ordered incorrectly. On an RTL page the whole annotation chrome mirrored: tool order reversed, the Attach button moved, and element labels got pushed off the right edge of the viewport.Isolating the overlay from the host document and letting the comment field infer direction from its content is the smallest change that fixes both.
UI Changes
Arabic comment on an LTR host page. Before: text is anchored to the left of the field.
After: the comment starts from the right, toolbar unchanged.
RTL host page. Before: the overlay mirrors along with the page, and the element label is pushed off screen.
After: the overlay keeps its LTR layout while the page stays RTL.
Checklist
Reviewed and verified with Claude Fable 5.1 in Claude Code.
🤖 Generated with Claude Code