fix(pi): preserve native abort outcomes

[StiensWout]

Problem

Pi-native aborts could be recorded as completed turns.

Change

Carry the native aborted outcome through the existing idle settlement check and clear it when a new agent run starts, preserving queued continuation and wake acknowledgement barriers. Native cancellations from extensions, compaction, or session replacement now use the existing interrupted-run presentation, including its "Run interrupted by user" row.

Scope and approval

Maintainer-requested Pi support follow-up. Scope is native Pi abort outcomes in the existing turn lifecycle.

Verification

Validation: 82 adapter tests, Pi typecheck and scoped lint/format checks passed.

_{Prepared for Wout by gpt-6.1-sol in Codex.}

[macroscopeapp]

Approvability

Verdict: Approved at 79d6e92

Macroscope's review found this PR approvable — This is a narrowly scoped Pi adapter bug fix that preserves native cancellation outcomes through the existing turn lifecycle and adds targeted regression coverage. It does not introduce new capabilities, schema changes, product-default changes, or static-analysis suppressions.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: b2e8fade-e88d-4c0b-9b56-49a19b999b43

---

📥 Commits

Reviewing files that changed from the base of the PR and between a11f464 and 79d6e92.

---

📒 Files selected for processing (2)

• packages/provider-pi/src/server/adapter.test.ts
• packages/provider-pi/src/server/adapter.ts

---

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

---

---

📝 Walkthrough

Walkthrough

The Pi adapter now records native aborts and treats them as interruptions during provider turn finalization. Tests cover aborted and non-aborted settlements, joined prompts, and retry-progress items.

Changes

Native abort settlement

Layer / File(s)	Summary
Track native abort state packages/provider-pi/src/server/adapter.ts	The active turn records Pi’s aborted value from settlement events and adopted settled wakes. New turns initialize the state, and a new agent_start clears it.
Finalize aborted turns packages/provider-pi/src/server/adapter.ts, packages/provider-pi/src/server/adapter.test.ts	Finalization treats native aborts as interruptions when updating compaction and retry items, suppressing failure, setting turn status, and reporting terminal events. Tests cover settlement outcomes, joined prompts, and retry-progress interruption.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

---

Merge Risk | ⚪ Minimal · up to 79d6e

Merge Risk: ⚪ Minimal · up to 79d6e

No concrete issue remains that would prevent merging the native-abort settlement change after normal checks.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 79d6e

Native cancellations now use the existing interrupted outcome without adding access, privileges or external interfaces. Settlement barriers and transport-failure reporting remain in place. Residual uncertainty concerns cancellation overlapping transport failure, not an established security vulnerability.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

• inferred — The demonstrated change affects existing Pi turns, their retry/compaction items and downstream run outcomes. It does not demonstrate expanded tenant, service or credential exposure; deployed topology was not available to establish a broader maximum scope.

Trust Boundaries and Controls

• observed — Turn finalization still cancels pending native prompts. Existing orchestration handling also dismisses native user inputs when provider turns become interrupted or terminal; native abort does not leave those requests open merely because it uses a different terminal outcome.

Resilience and Maintainability Implications

• observed — Native cancellation is distinct from planned process shutdown. Unexpected transport closure still fails pending RPC requests, rejects outgoing work, marks the session errored and fails its event stream. Downstream failure recovery avoids rewriting an already-finalized run. These controls counter the possible interrupted-turn/errored-session combination, although that precise overlap lacks direct test coverage.

---

Pre-merge checks | 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check		The title is concise, uses the conventional commit format, and clearly identifies the fix for preserving native Pi abort outcomes.
Description check		The description includes the required Problem, Change, Scope and approval, and Verification sections. It explains the behavior change and reports focused validation results.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

---

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}