Repository navigation
Conversation
…Windows desktop With the right panel open, the thread details toggle sits inside the chat header but was offset by --workspace-controls-right, which also clears the native window buttons. Those buttons sit over the right panel, so on Windows and Linux desktop the toggle landed about 150px in from the chat column's edge and covered the title as the panel was widened. Inset it from the chat header's own edge instead. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe inline thread-panel title-bar control now uses the chat-header edge for its horizontal inset. The separate workspace title-bar controls retain their existing positioning. ChangesThread panel positioning
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the Windows desktop app, opening the right panel and dragging it wider moves the thread details toggle on top of the thread title. It should sit beside the panel's edge, as it does in the browser and on macOS.
Change
While the right panel is open, the toggle is positioned inside the chat header, but it used
--workspace-controls-right. In the desktop app's window-controls overlay that inset also clears the native minimise/maximise/close buttons (about 150px on Windows). Those buttons sit over the right panel, not the chat header, so the toggle landed about 150px in from the chat column's edge, past the 40px the title reserves for it.The toggle now uses the chat header's own inset (
env(safe-area-inset-right) + 0.75rem, the non-overlay value of the same variable), so the browser and macOS render exactly as before. The pull requests page keeps the shared variable because its controls sit on the window edge.Scope and approval
A one-line positioning fix for an obvious layout bug, so it should fit the small obvious bug-fix exception. No product behavior changes.
Related: #15371 addresses the same overlap by reserving more title padding while leaving the toggle at the inset position. This PR instead moves the toggle to the chat header's edge, so the title keeps its normal space and no gap is left beside the panel. Maintainers can pick whichever approach they prefer.
Verification
Tested in the Windows desktop app (
vp run dev:desktop), with the right panel open and resized:vp lintandvp fmt --checkonChatView.tsx: no new findings.right: calc(env(safe-area-inset-right) + 0.75rem), identical to the old value outside the window-controls overlay.Not checked: Linux and macOS desktop builds. Running the dev build locally also needed the one-line fix from #16799 (pairing currently fails with HTTP 500 on Node < 24.21); that change is not part of this PR.
Model: Claude Opus 5.5. Harness: Claude Code in T3 Code.
🤖 Generated with Claude Code