fix(source-control): keep distinct CI checks with overlapping names

[Lucenx9]

Problem

Two unrelated CI checks disappear into one when their workflow and job names produce the same space-separated string. For example, Build / Linux tests and Build Linux / tests both use the key Build Linux tests, so the newer result overwrites the other check, even if it failed.

Change

Serialize the workflow and job names as a pair for the deduplication key. Distinct pairs remain separate, while reruns of the same pair still replace their earlier result in place. The existing null/empty workflow handling is preserved.

Scope and approval

This is a very small, focused fix for an obvious collision in the existing check deduplicator, eligible under the exception in CONTRIBUTING.md. It changes one implementation line and adds one regression test. The GitHub, Forgejo, and Bitbucket callers use the same helper; their contracts and UI need no changes. Searches of open and closed issues/PRs found no duplicate. #12274 concerns check ordering, and #17207 concerns concurrent runs of the same check pair.

Verification

• Reproduced the loss by passing the two pairs above to the real helper: one check was returned before the fix; both checks, including the failure, are returned after it.
• Added the regression before changing the implementation and observed it fail because the second check was missing. It now verifies both pairs survive and a rerun replaces only its own pair without changing their order.
• vp test run packages/source-control-core/src/server/pullRequestChecks.test.ts packages/source-control-github/src/server/gitHubPullRequestJson.test.ts --maxWorkers=1: 100 tests passed in 1.31 seconds.
• Targeted lint and formatting passed for both changed files. tsc-rs --noEmit passed with a temporary config including only those files and extending the package config.
• Fallow 3.33.1 review scoped to the source-control-core server directory reported low risk, with no new exports, dependencies, or boundary crossings.

No live hosting API or UI verification was performed; this is a backend normalization fix exercised with deterministic inputs.

Reviewed before submission by Gemini 3.8 Flash High via Antigravity in T3 Code: APPROVE, no actionable findings.

Implemented with GPT-6.1 Sol via the Codex harness in T3 Code; reviewed with Gemini 3.8 Flash High via the Antigravity harness.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-13T21:46:36.787301Z	fcff60d	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[macroscopeapp]

Approvability

Verdict: Approved at fcff60d

Macroscope's review found this PR approvable — This is a focused backend bug fix that replaces an ambiguous check-deduplication key with an unambiguous workflow/name pair and adds a targeted regression test. Its runtime impact is limited to retaining distinct CI checks that previously collided, with existing rerun behavior preserved.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Path: .coderabbit.config.ts
• Review profile: CHILL
• Plan: Advanced
• Run ID: 27e0b2f9-8f57-4598-811f-a3374e891d6f

📥 Commits

Reviewing files that changed from the base of the PR and between a01c48f and fcff60d.

📒 Files selected for processing: 2

• packages/source-control-core/src/server/pullRequestChecks.test.ts
• packages/source-control-core/src/server/pullRequestChecks.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

dedupeChecks now uses a JSON-encoded workflow and check name pair as its grouping key. A regression test verifies that distinct pairs with colliding joined names remain separate, while a later run replaces the earlier result for the same pair.

Changes: Pull request check deduplication

Layer / File(s)	Summary
Pair key and regression test packages/source-control-core/src/server/pullRequestChecks.ts, packages/source-control-core/src/server/pullRequestChecks.test.ts	dedupeChecks encodes the workflow and check names as a tuple. The regression test verifies that distinct pairs remain separate and that a later run replaces the earlier result for the same pair without changing its position.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: juliusmarminge

Merge Risk: ⚪ Minimal · up to fcff6

This change addresses the reported check-name collision, and the supplied regression-test summary covers distinct colliding pairs and reruns. No material merge risk is evident.

### Architecture Summary

Architecture risk: 🔵 Low · up to fcff6

The change affects 1 system.

Changed systems: packages/source-control-core

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — packages/source-control-core (library) was modified; 2 changed files map to changed impact.

Before / after behavior

• observed — Modified behavior in packages/source-control-core/src/server/pullRequestChecks.test.ts: Adds a regression test for distinct workflow/check pairs whose joined names collide; the later run for the same pair supplies the retained status while the other pair remains in its original position.
• observed — Modified behavior in packages/source-control-core/src/server/pullRequestChecks.ts: dedupeChecks now encodes the workflow name and check name as a JSON tuple for its grouping key, replacing space-delimited concatenation.

Pre-merge checks: 4

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main fix: preventing distinct CI checks with overlapping names from being merged.
Description check		The description covers the problem, change, scope justification, regression test, verification commands, observed results, and limitations. It also explains why the focused fix qualifies without prior…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}