Repository navigation
fix(server): restore OpenCode adapter test typecheck - #17810
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a one-file test/typecheck correction confined to an ignored path, with no production runtime, product-default, schema, or static-analysis suppression impact. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
## What's Changed * fix(web): align compact button touch targets by @Yash-Singh1 in pingdotgg/t3code#17748 * fix(server): t3_thread_launch refuses a new worktree whose base ref has no commit by @tris203 in pingdotgg/t3code#17791 * fix(web): omit underlines on markdown image links by @Saikrishna1876 in pingdotgg/t3code#17728 * fix(server): restore auto resume for wrapped Claude gateway rate limits by @tzachbon in pingdotgg/t3code#17778 * fix(opencode): name OpenCode 2 sessions after their thread by @nkoynov in pingdotgg/t3code#17414 * fix(web): find update settings from the command palette by @sergical in pingdotgg/t3code#17396 * fix(provider-opencode): tell OpenCode Zen and Go models apart by @mr-karan in pingdotgg/t3code#17424 * fix(server): a pull that fast-forwards no longer fails on large Git output by @ScottN-PV in pingdotgg/t3code#17376 * fix(web): cancel question auto-advance after navigation by @maxwellyoung in pingdotgg/t3code#17364 * fix(server): a bare repository name resolves to the signed-in account again by @ScottN-PV in pingdotgg/t3code#17379 * fix(web): a maximized right panel stays maximized when you return to its thread by @jamesvillarrubia in pingdotgg/t3code#17327 * fix(mobile): allow starting a task with only an image by @Claudesaul in pingdotgg/t3code#17409 * fix(server): PR watch no longer reports passed while a second run of a check is still going by @ScottN-PV in pingdotgg/t3code#17344 * fix(server): say why a thread can't be settled by @DylanTX in pingdotgg/t3code#17258 * fix(server): prevent busy terminals from starving history persistence by @StiensWout in pingdotgg/t3code#17181 * feat(server): use macOS .icns app icons as project icons by @psv2522 in pingdotgg/t3code#17149 * fix(mobile): usage reset icon lines up with its row by @Aforno in pingdotgg/t3code#17175 * fix(web): paths pasted after @ keep their underscores by @derektrimm in pingdotgg/t3code#16619 * fix(server): settle every OpenCode subagent call one report answers by @nkoynov in pingdotgg/t3code#17134 * perf(web): switching project keeps Diagnostics and Providers mounted by @flamboh in pingdotgg/t3code#17122 * perf(web): Open Source Licenses downloads its manifest once per session by @flamboh in pingdotgg/t3code#17119 * fix(server): restore OpenCode adapter test typecheck by @Yash-Singh1 in pingdotgg/t3code#17810 * fix(server): Claude subagents show the reasoning effort they run at by @RakshithBhat03 in pingdotgg/t3code#17496 ## New Contributors * @tzachbon made their first contribution in pingdotgg/t3code#17778 * @sergical made their first contribution in pingdotgg/t3code#17396 * @mr-karan made their first contribution in pingdotgg/t3code#17424 * @Claudesaul made their first contribution in pingdotgg/t3code#17409 * @DylanTX made their first contribution in pingdotgg/t3code#17258 * @psv2522 made their first contribution in pingdotgg/t3code#17149 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261010.2922...v0.0.46-nightly.20261010.2935 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261010.2935
## What's Changed * fix(web): align compact button touch targets by @Yash-Singh1 in pingdotgg/t3code#17748 * fix(server): t3_thread_launch refuses a new worktree whose base ref has no commit by @tris203 in pingdotgg/t3code#17791 * fix(web): omit underlines on markdown image links by @Saikrishna1876 in pingdotgg/t3code#17728 * fix(server): restore auto resume for wrapped Claude gateway rate limits by @tzachbon in pingdotgg/t3code#17778 * fix(opencode): name OpenCode 2 sessions after their thread by @nkoynov in pingdotgg/t3code#17414 * fix(web): find update settings from the command palette by @sergical in pingdotgg/t3code#17396 * fix(provider-opencode): tell OpenCode Zen and Go models apart by @mr-karan in pingdotgg/t3code#17424 * fix(server): a pull that fast-forwards no longer fails on large Git output by @ScottN-PV in pingdotgg/t3code#17376 * fix(web): cancel question auto-advance after navigation by @maxwellyoung in pingdotgg/t3code#17364 * fix(server): a bare repository name resolves to the signed-in account again by @ScottN-PV in pingdotgg/t3code#17379 * fix(web): a maximized right panel stays maximized when you return to its thread by @jamesvillarrubia in pingdotgg/t3code#17327 * fix(mobile): allow starting a task with only an image by @Claudesaul in pingdotgg/t3code#17409 * fix(server): PR watch no longer reports passed while a second run of a check is still going by @ScottN-PV in pingdotgg/t3code#17344 * fix(server): say why a thread can't be settled by @DylanTX in pingdotgg/t3code#17258 * fix(server): prevent busy terminals from starving history persistence by @StiensWout in pingdotgg/t3code#17181 * feat(server): use macOS .icns app icons as project icons by @psv2522 in pingdotgg/t3code#17149 * fix(mobile): usage reset icon lines up with its row by @Aforno in pingdotgg/t3code#17175 * fix(web): paths pasted after @ keep their underscores by @derektrimm in pingdotgg/t3code#16619 * fix(server): settle every OpenCode subagent call one report answers by @nkoynov in pingdotgg/t3code#17134 * perf(web): switching project keeps Diagnostics and Providers mounted by @flamboh in pingdotgg/t3code#17122 * perf(web): Open Source Licenses downloads its manifest once per session by @flamboh in pingdotgg/t3code#17119 * fix(server): restore OpenCode adapter test typecheck by @Yash-Singh1 in pingdotgg/t3code#17810 * fix(server): Claude subagents show the reasoning effort they run at by @RakshithBhat03 in pingdotgg/t3code#17496 ## New Contributors * @tzachbon made their first contribution in pingdotgg/t3code#17778 * @sergical made their first contribution in pingdotgg/t3code#17396 * @mr-karan made their first contribution in pingdotgg/t3code#17424 * @Claudesaul made their first contribution in pingdotgg/t3code#17409 * @DylanTX made their first contribution in pingdotgg/t3code#17258 * @psv2522 made their first contribution in pingdotgg/t3code#17149 **Full Changelog**: pingdotgg/t3code@v0.0.46-nightly.20261010.2922...v0.0.46-nightly.20261010.2935 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.46-nightly.20261010.2935
Problem
The latest main CI run fails Typecheck because
watchCallsin the OpenCode 2 adapter tests refers to an unimportedProviderAdapterV2SessionRuntime. That unresolved type also causes downstream Effect context and event type errors. Lint already passes on that commit.Change
Qualify the runtime type through the existing
ProviderAdapternamespace import, matching the other helpers in the file.Scope and approval
This is a focused fix for an obvious compiler error in a test helper. It changes only a type reference and qualifies for the small bug fix exception without a prior issue or discussion.
Verification
Validated in a temporary worktree with a frozen-lockfile install of current dependencies:
vp run --filter t3 typecheckpasses.vp test run apps/server/src/orchestration-v2/Adapters/OpenCode2AdapterV2.test.tspasses all 89 tests.vp lint --report-unused-disable-directives apps/server/src/orchestration-v2/Adapters/OpenCode2AdapterV2.test.tspasses.vp fmt --check apps/server/src/orchestration-v2/Adapters/OpenCode2AdapterV2.test.tspasses.Model: gpt-6.1-sol. Harness: Codex in T3 Code.