Repository navigation
feat(chat): show the picture attached to a Hermes prompt - #2482
Merged
Merged
Conversation
Hermes v0.21.5 keeps no picture bytes in state.db: a prompt with a picture is stored as its caption, a `[Image attached at: <path>]` hint per picture and a `[screenshot]` stand-in for each. Chat now reads that block as Hermes's own history does (tui_gateway/session_history.py) and shows each hint as a Markdown image of that local file, so the chat's local Markdown image path (#2435: /api/fs/stat then /api/fs/file, raster and 20 MiB checks, a link otherwise) draws it. No new route. Any other hint (a URL, a relative or Windows path, a malformed block) stays as written.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 18 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
devswha
added a commit
that referenced
this pull request
Oct 31, 2026
…window (#2483) ## Change Closes #2478. Copilot CLI interns every picture of a turn in its session file as base64 (`session.binary_asset`), so one turn with a few pictures can pass the 16 MiB page window (`TRANSCRIPT_WINDOW_BYTES`). With no turn start in that window, the newest page began mid-turn and showed only the answer. The older page was also capped at one window (`MAX_PAGE_BYTES`), so it held the prompt and its tool calls with **empty output**: their results sat on the other side. - A Copilot page now widens back to its turn's start, the newest page included, up to four windows (`COPILOT_PAGE_BYTES`, 64 MiB). Past that it starts mid-turn, as before. - Widening searches only each chunk it adds, plus the rest of the line that chunk cuts (read forward 1 MiB at a time, stopping on an empty read), then reads the page once from the start it finds. - Other agents' pages are unchanged: their cap is still one window, so they never widen. Own PR from `main`, not stacked on #2479. `git merge-tree` against #2479, #2481 and #2482 is clean in either order. ## Validation - Failing first: the new `server/copilot.test.ts` case uses the real recorded `copilot-recorded.jsonl` turn, after an earlier turn. Two interned pictures go between its tool call and the call's result (over one window together). On `main`, the newest page held only the answer. With the fix, the newest page (`prompts: 1`) equals the whole-file parse of the pictured turn, tool output included, and the older page holds the earlier turn. - `bun run check fast` on 893d55c: all steps ok, unit **9828 pass, 0 fail, 41 skip**. - Cost per poll (merge-pass finding, fixed in 9bfb005): the first fix re-widened the newest page on every append. The newest Copilot turn that has outgrown its window is now kept between polls: - It keeps the turn's start, the read point, the 64 bytes before it, and the complete lines. Each picture record is checked whole once, then kept only as its byte length behind a per-process mark, so later records keep their exact offsets. - A poll reads only the appended bytes. - It reads afresh on another history, a changed tail, a new prompt, or a turn grown a window past the cap. - It is released with the pane's other per-path caches, and bounded by bytes as well as count: least-recently-read entries are evicted while the kept lines pass one capped turn (`COPILOT_PAGE_BYTES` + a window). Picture records count only as their length. - Measured on a 55 MB file (5 pictures of 11 MiB of base64, 5 small appends): | Code | First read | Read per append | Time per append | Turns on newest page | |---|---|---|---|---| | `main` | 87.1 MiB | 16.1–16.1 MiB | 22–52 ms | 1 (turn split: answer only) | | 0b5ce2f (first fix) | 200.0 MiB | 129.0–129.0 MiB | 247–341 ms | 2 | | 9bfb005 (this round) | 200.0 MiB | 741 bytes | 0–1 ms | 2 | The new test counts bytes read with a `readSync` spy (no timing asserts): under 64 KiB per append. It read 45 MB against 0b5ce2f's code. - Between the cap and the cap plus one window, a warm cache may hold up to one window more of the same turn than a fresh read would. This hysteresis rescans once per window of growth instead of on every poll. - Known limit, like the existing `liveScans` cache: the cache trusts Copilot to append. An earlier line rewritten in place, with the 64 bytes before the read point unchanged and the file grown, is not noticed. ## Reviews - omo-native-code-reviewer (cache round, e59939ff): REQUEST_CHANGES on H1, M1, M2 and L1. All four are the same findings as Codex's and are fixed in 9bfb005 (the reviewer read that diff and found them addressed). It also verified that tool-output refs resolve across set-aside lines, that partial and UTF-8-split lines and held cursors match a fresh read, and that malformed asset lines still make the strict reader throw. - omo-native-code-reviewer (first fix): **PASS / APPROVE**. A page walk over 27, 40 and 72 MiB turns, and sub-agent pictures, matched the whole-file parse. Other agents' paging is unchanged. - MEDIUM (per-poll `Buffer.concat` cost): fixed. The page is now read once. - MEDIUM (the test never checked the older page): fixed. An earlier turn is first, and both pages are asserted. - Codex Terra 6.1 fast xhigh (cache round, 0064d2ac): HIGH (a new prompt plus more than a window appended between polls was missed) fixed; HIGH (unbounded, never-released cache) fixed with the cap rescan, 4 entries and pane release; LOW (forged marker) fixed with a per-process nonce; HIGH (rewrite-and-grow) kept as the documented known limit above. Final round on 9bfb005: **PASS**. - Codex Terra 6.1 fast xhigh (first fix): - Round 1: MEDIUM (a `session.binary_asset` skip in `copilotRecords` bypassed strict validation). The skip is removed; it is not needed for the cost. - Delta round: HIGH (the forward scan could loop on an empty read after truncation). Fixed. - Final round: **PASS**. - Known limit, unchanged: a single record longer than the cap still starts a page mid-line. Codex found this pre-existing at the old 16 MiB cap; A 64 MiB single record is far beyond a Copilot picture as seen here, since Copilot resizes images before interning them.
Owner
Author
|
Merging ae5912f on the maintainer's OK of the screenshots (brought into 0.4.22 at his request): a Hermes prompt's attached picture ('[Image attached at: ]' with '[screenshot]') now shows above the words in Chat, as a normal Markdown image through #2435's existing local image rules and file API (no new route). Strict review by the merge pass (APPROVE, own repros through the real parser): only absolute paths, accepted less widely than a typed Markdown image; |
devswha
added a commit
that referenced
this pull request
Oct 31, 2026
Merge main and fold the changelog fragments of every PR merged since the last refresh into 0.4.22: - #2490 (Fixed): Chat keeps messages mounted when the pane's skill names load, by @nocstah - #2483 (Fixed): a Copilot turn stays whole when its pictures pass the page window - #2479 (Added): Chat shows the pictures in a Copilot CLI session - #2482 (Added): Chat shows the picture attached to a Hermes prompt #2480 (site only) had no fragment.
devswha
added a commit
that referenced
this pull request
Oct 31, 2026
Merged
devswha
added a commit
that referenced
this pull request
Nov 2, 2026
## Release 0.4.22 The release PR, prepared by step 1 of [docs/development.md#releasing](https://github.com/devswha/ovis/blob/main/docs/development.md#releasing) on main `41492320` (#2453 the last merge), refreshed to main `99a6671f` (#2582 the last merge). **Do not merge yet:** the owner tests main and judges the final build before release. No tag and no Release run from this PR's author. - **Version:** `version` is 0.4.22 in `package.json` and `herdr-plugin.toml`. - **Changelog:** `bun scripts/changelog-fold.ts 0.4.22` (2026-10-31, local) folded 20 fragments into the 2026-10-31 section of `CHANGELOG.md` (23 entries with the hand entry), linked their PRs and deleted the fragments; `changelog.d` holds only `README.md`. - `by @login` on every outside contributor's PR link: #2453 @jokkopucko, #2452 @jokkopucko, #2442 @nahwan-kim, #2463 @zerodice0, #2468 @Yoonwoo-Ha, #2065 @rabbitson87 (both entries), #2466 @jpcarranza94, #2467 @jpcarranza94, #2457 @YuuuXie, #2420 @cheol-95 (both entries), #2459 @Haeminway1, #2450 @briantcl1992, #2448 @briantcl1992. - One outside PR had no fragment and got an entry by hand: #2448 (installer test no longer finds the host's Node, Maintenance). - Issue reporters: #2442's entry credits @Ploppy3, who asked for herdr-core support in #2439. The other fixed issues were filed by the PR's own author (#2460 @zerodice0, #2464 @jpcarranza94, #2419 @cheol-95, #2089 @rabbitson87) or the maintainer (#2444), so the PR credit covers them. - Two fragments ran past the changelog's width (#2443, #2446); their entries are re-wrapped, words unchanged. - Folded after the PR opened (merge of main `653613cb`, by hand per the release steps): #2474 (Pi Chat message with leading/trailing spaces, a tab or a trailing `@mention` no longer stuck "waiting for transcript", Fixed), credited `reported by @BeerBelly69` (he reported issue #2454; the PR is the maintainer's, so the earlier `by @BeerBelly69` was corrected in `90536524`). Its fragment is deleted; `changelog.d` holds only `README.md`. The release summaries are unchanged: their fixed list is already at five lines. - Folded in a second refresh (merge of main `98c1f5e0`, by hand): #2475 (a reconnecting or reloading browser gets back its follow-up's lost "sent" receipt, Fixed), credited `reported by @christso`, who filed #2421 and proposed the approach. Its fragment is deleted; `changelog.d` holds only `README.md`. The release summaries are unchanged (fixed list already at five lines). - Folded in a third refresh (merge of main `af20e0a4`, by hand): #2490 (Chat keeps its messages mounted when the pane's skill names load, so a decoded image no longer drops back to its loading slot, Fixed), credited `by @nocstah` (outside PR, no linked issue); #2483 (a Copilot turn stays whole when its pictures pass the page window, Fixed); #2479 (Chat shows the pictures in a Copilot CLI session, Added); #2482 (Chat shows the picture attached to a Hermes prompt, Added). #2483, #2479 and #2482 are maintainer PRs; #2483's issue #2478 is the maintainer's, so no reporter credit. #2480 (site only) had no fragment. Their fragments are deleted; `changelog.d` holds only `README.md`. The release summaries are unchanged: the fixed list is already at five lines, and the two new picture features stay in the changelog only (the new list has room for them if the owner wants them there). - Folded in a fourth refresh (merge of main `4ca7d24d`, by hand): #2481 (Grok pictures in Chat), #2477 (svg figures, `reported by @affeek`, who filed #2441 and co-authored the PR), #2498 (dollar math, `reported by @kjohnsen`, #2407), #2484 (Expand thinking / Collapse work defaults, `reported by @altgans and @Ploppy3`, #2346 and #2228) under Added; #2494 (`by @todor-a`), #2491 (`by @nocstah`), #2487, #2486, #2472 (`reported by @matiemer`, #2462) and #2476 (relay session uses the server's port) under Fixed. 10 fragments deleted; `changelog.d` holds only `README.md`. Every entry's credit was re-checked with GraphQL (PR author, closing issues' authors, commit authors): #2487's #2374, #2486's #2485 and #2483's #2478 are the maintainer's, so no reporter credit. - Folded in a fifth refresh (merge of main `f5370d54`, by hand): #2503 (Claude question card steps and Back, `reported and co-authored by @jpcarranza94`, who filed #2465 and co-authored the fix), #2502 (tab name from its first message, `reported by @vibewriter-hand`, #2019) and #2505 (a note on a diff line goes into the next message; #1603 is the maintainer's, so no credit) under Added; #2506 (OmO, Codex and Hermes question cards move between questions without answering; it closes no issue, so no credit) under Fixed. 4 fragments deleted; `changelog.d` holds only `README.md`. #2499's hand-written relay entry is kept. All four PRs are the maintainer's; credits re-checked with GraphQL (PR author, closing issues' authors, commit authors). - Sixth refresh (merge of main `feb3ae09`, head `e3b0dc37`): main had no fragment left to fold. #2504 (the owner's PR, no fragment) gets a hand entry under Added next to #2499's: the PC side of the relay, which answers the relay's server proof, `/api/relay` start/stop routes restricted to the owner and to direct connections, and a relay QR from `plugin pair`; off by default with no Settings switch yet. No credit (maintainer PR). It stays out of the release summaries (off by default, no UI). - Seventh refresh (merge of main `a683e3ff`, head `7855c73c`): folded #2509's two fragments by hand, two entries under Added (the phone side of the relay: the hosted shell that pairs from the PC's relay QR and opens the app end-to-end encrypted; files and chat images through the relay) and one under Fixed (the iOS and Android apps no longer show the hosted shell's home-screen hint). Each says the relay is off by default. #2499's entry now says Ovis uses the relay only once a PC's relay link is started. No credit (maintainer PR). The fragments are deleted; `changelog.d` holds only `README.md`. The relay stays out of the release summaries. - Eighth refresh (merge of main `0b215abf`, head `f76f3ae4`): folded #2514's three fragments by hand under Fixed (relay connection limits and the 30 s wait for an absent PC, proof of the PC's relay key, the hosted shell's copy-on-select and relay-control requests) and added a hand entry for #2514 under Added: remote access through the Ovis relay can be turned on in **Settings → Phone & devices** (off by default), with the iOS and Android apps opening a relay-paired PC from its link; app.ovis.sh is deployed separately. #2499, #2504 and #2509's entries no longer say there is no Settings switch: they now say the relay is turned on in Settings. No credit (maintainer PR). Also folded #2511 (Claude task-list scan on file workers, Fixed, `by @duytbp`) and #2518 (feedback typed on Claude Code's plan card keeps Claude planning, Fixed, `by @jpcarranza94`, who also reported #2517, so no separate reporter credit). #2515 is docs only, no fold. 5 fragments deleted; `changelog.d` holds only `README.md`. - Ninth refresh (merge of main `fbb97b62`, head `44048d5f`, fold in the merge commit): folded 23 fragments by hand: 7 entries under Added (#2514's rewritten relay-identity entry, which replaces its old Fixed entry about the PC's relay key; #2519 Letta model pill `by @homebodify`; #2522 relay bulk window and the relay overview, self-hosting and hosted-shell attestation; #2524 DeepSeek Harness in the catalog), 3 under Changed (#2533 Connect a phone dialog and the `tailscale serve` box; #2539 chat pictures shown whole) and 26 under Fixed: #2508; #2512 `by @lifeofpi-ux`; #2516; #2521, #2526, #2531, #2538, #2541, #2543, #2545, #2547, #2549 and #2551 `by @jpcarranza94`; #2527 `reported by @duytbp` (#2510); #2532; #2535 `reported by @devtm1123` (#2513). #2532's #2523 is the maintainer's; @jpcarranza94's issues (#2525, #2537, #2540, #2542, #2544, #2546, #2548, #2550) are covered by his PR credit. #2529 (perf) is not merged and stays out of 0.4.22. 23 fragments deleted; `changelog.d` holds only `README.md`. - Tenth refresh (merge of main `afdfb1e0`, head `1cfcfab7`, fold in the merge commit), on the owner's OK for both: folded #2567 (Connect a phone shows three choice cards and opens on the relay whenever it is offered, with the relay's switch on its card on a tailnet; maintainer PR, no credit) under Changed and #2555 (the New workspace folder picker's compact row; `by @iwangjie`, no linked issue) under Fixed. 2 fragments deleted; `changelog.d` holds only `README.md`. The IMPROVED summary line now says the relay needs no Tailscale, in en, ko, ja and zh. - Eleventh refresh (merge of main `2b620462`, head `13fa0181`, fold in the merge commit), on the owner's go for each: folded 13 entries from 12 fragments by hand. Changed: #2562 (a chat starts loading when the press begins, `by @jpcarranza94`), #2574 (Quote a selection into the message box), #2578 (the relay's switch, reset and failures only in Connect a phone). Fixed: #2564 and #2560 (two entries) `by @jpcarranza94`; #2554 `by @iwangjie`; #2577; #2576 (the session-bound conversation cache, fixing the two HIGHs the post-merge Codex Terra review reproduced in #2562 and #2545); #2572 `reported by @rkqksk` (#2557); #2570 `reported by @nathanvale` (#2566); #2571 `reported by @altgans` (#2568); #2575 `reported by @matiemer` (#2558). @jpcarranza94's own issues (#2559, #2561, #2563) are covered by his PR credit. 12 fragments deleted; `changelog.d` holds only `README.md`. IMPROVED summary: "Select words in a Chat reply to quote them into your message." replaces the spacing line, in en, ko, ja and zh. - Twelfth refresh (merge of main `64ae5e72`, head `3ae2133e`), on Dori's go: folded #2580 under Fixed (the Cloudflare relay closes both ends of a pair after a frame send fails, so they reconnect at once; maintainer PR, no credit) and deleted its fragment. #2579 (guide only) has no fragment. Summaries unchanged. - Thirteenth refresh (merge of main `99a6671f`, head `aebaabbf`), on Dori's go: folded #2582 under Fixed (`by @iwangjie`: the folder picker's Show hidden waits for a loading folder; the path bar wraps at very narrow widths) and deleted its fragment. Summaries unchanged. - Maintainer PRs without a fragment and without a user-facing change have no entry: #2436 (relay crypto/mux foundations, not wired yet), #2445 (CI contract test against a pinned hc). - **Release summaries:** en, ko, ja and zh each have 8 new, 8 improved and 8 fixed lines (8 is the most a list the app reads may hold, 90 characters a line). New: remote access through the Ovis relay, turned on in Settings (off by default), with app.ovis.sh shipping separately (#2514); pictures in Chat for Copilot, Grok and Hermes (#2479, #2481, #2482); svg figures (#2477); math with dollar signs (#2498); Portal sign-in with watch-only visitors (#2065); DeepSeek Harness in Settings → Agents with its conversations in Chat on Linux (#2524, #2453); tab names from the first message (#2502); notes on diff lines (#2505). Improved: Expand thinking / Collapse work defaults (#2484), Chat spacing that follows the font size (#2491), key bar drag reorder (#2463), same-host links in an in-app popup on phones (#2459), Claude question cards with steps and Back (#2503), OmO, Codex and Hermes cards with Back and Next (#2506), one Connect a phone dialog (#2533), pictures shown whole (#2539). Fixed: panes again on Safari 16.4–17.3 and iOS 16.4+ (#2535), Stop with a queued follow-up keeps the stopped message (#2547), a first message reaches Claude Code (#2526), Codex Chat after a finished answer (#2443), question cards show at once and stay (#2543), Chat no longer redraws turns or jumps (#2538, #2545), a setting kept across a quick reload (#2487), Claude's plan card in narrow panes (#2541). Moved to the changelog only to fit the 8-line lists: Codex behind Kiro (#2420), Pi messages with spaces (#2474), the Claude question card between questions (#2466, #2467, now covered by the question-card line), short-phone overlap (#2494), cross-tab settings (#2486), the Antigravity note (#2472), plus the subagent poll perf (#2527), relay transport (#2516), herdr-core no-watch (#2512) and the other Fixed entries above. - **Remote bundle:** `REMOTE_BUNDLE_VERSION` rises from 40 to 41 because the bundle inputs (`server/`, `shared/`, `bun.lock`) changed since remote-v40. After merge: push `remote-v41` on the merged commit and wait for the Remote PC bundles workflow before running Release. - **Telemetry:** `telemetry/worker.ts` and `shared/telemetry.ts` are unchanged since `telemetry/deployed.json`; no Worker deploy. ## Validation - `bun scripts/release-guards.ts --base v0.4.21`: before the bump it asked to raise `REMOTE_BUNDLE_VERSION` from 40 to 41 and nothing else; after it, "Release 0.4.22: remote bundle, telemetry Worker and release metadata are in order." - `UNIT_TEST_WORKERS=4 dori heavy rel0422 -- bun run check fast` on this branch: workflow syntax, generated types and themes, typecheck, build, unit tests all ok. Unit: 9827 pass, 0 fail, 41 skip in 623 files. - After folding #2474 (head `3de63b49`): `bun scripts/release-guards.ts --base 653613c` "Release 0.4.22: remote bundle, telemetry Worker and release metadata are in order."; `UNIT_TEST_WORKERS=4 dori heavy refresh2473 -- bun run check fast` all ok, unit 9827 pass, 0 fail, 41 skip in 623 files. - After folding #2475 and correcting the #2474 credit (head `90536524`): `bun scripts/release-guards.ts --base 653613c` "Release 0.4.22: remote bundle, telemetry Worker and release metadata are in order."; `UNIT_TEST_WORKERS=4 dori heavy refresh2473b -- bun run check fast` all ok, unit 9851 pass, 0 fail, 41 skip in 623 files. - After folding #2490, #2483, #2479 and #2482 (head `0da3756d`; `e6eb7df6` removed the fragments and `0da3756d` adds their CHANGELOG entries, which that commit left out): `bun scripts/release-guards.ts --base 98c1f5e` "Release 0.4.22: remote bundle, telemetry Worker and release metadata are in order."; `UNIT_TEST_WORKERS=4 dori heavy refresh2473c -- bun run check fast` all ok, unit 9855 pass, 0 fail, 41 skip in 623 files (with `TMPDIR` off the quota'd `/tmp` tmpfs; an earlier run with the default `TMPDIR` hit `EDQUOT` there). - After the fourth refresh (head `af31fa98`): `bun scripts/release-guards.ts --base v0.4.21` and `--base origin/main` both "Release 0.4.22: remote bundle, telemetry Worker and release metadata are in order." main still has `REMOTE_BUNDLE_VERSION` 40 (no commit since v0.4.21 touches it) and `remote-v41` is not tagged yet, so this PR's 41 stays the one raise. `UNIT_TEST_WORKERS=4 dori heavy rel2473 -- bun run check fast` all ok, unit 9973 pass, 0 fail, 41 skip in 624 files. - After the fifth refresh (head `b602a998`, merge of main `f5370d54`): `bun scripts/release-guards.ts --base v0.4.21` and `--base origin/main` both "Release 0.4.22: remote bundle, telemetry Worker and release metadata are in order." (`REMOTE_BUNDLE_VERSION` stays 41). `UNIT_TEST_WORKERS=4 dori heavy rel2473c -- bun run check fast` all ok, unit 10107 pass, 0 fail, 41 skip in 631 files. - After the sixth refresh (head `e3b0dc37`, merge of main `feb3ae09`): `bun scripts/release-guards.ts --base v0.4.21` and `--base origin/main` both "Release 0.4.22: remote bundle, telemetry Worker and release metadata are in order." (`REMOTE_BUNDLE_VERSION` stays 41). `UNIT_TEST_WORKERS=4 dori heavy rel2473d -- bun run check fast` all ok, unit 10123 pass, 0 fail, 41 skip in 632 files. - After the seventh refresh (head `7855c73c`, merge of main `a683e3ff`): `bun scripts/release-guards.ts --base v0.4.21` and `--base origin/main` both "Release 0.4.22: remote bundle, telemetry Worker and release metadata are in order." (`REMOTE_BUNDLE_VERSION` stays 41). `UNIT_TEST_WORKERS=4 dori heavy rel2473e -- bun run check fast` all ok, unit 10314 pass, 0 fail, 41 skip in 644 files. - After the eighth refresh (head `f76f3ae4`, merge of main `0b215abf`): `bun scripts/release-guards.ts --base v0.4.21` and `--base origin/main` both "Release 0.4.22: remote bundle, telemetry Worker and release metadata are in order." #2514's and #2511's `server/` changes land before `remote-v41` is tagged, so `REMOTE_BUNDLE_VERSION` stays 41. `UNIT_TEST_WORKERS=4 dori heavy rel2473g -- bun run check fast` all ok, unit 10363 pass, 0 fail, 41 skip in 649 files. - After the ninth refresh (head `44048d5f`, merge of main `fbb97b62`): `bun scripts/release-guards.ts --base v0.4.21` and `--base origin/main` both "Release 0.4.22: remote bundle, telemetry Worker and release metadata are in order." (`REMOTE_BUNDLE_VERSION` stays 41; `remote-v41` is not tagged yet). `UNIT_TEST_WORKERS=4 dori heavy rel2473 -- bun run check fast` all ok, unit 10511 pass, 0 fail, 41 skip in 654 files; `server/release-notes.test.ts` and `src/lib/updateNotes.test.ts` 52 pass. - After the tenth refresh (head `1cfcfab7`, merge of main `afdfb1e0`): `bun scripts/release-guards.ts --base v0.4.21` and `--base origin/main` both "Release 0.4.22: remote bundle, telemetry Worker and release metadata are in order." (`REMOTE_BUNDLE_VERSION` stays 41; both PRs are client-only). `UNIT_TEST_WORKERS=4 dori heavy rel2473j -- bun run check fast` all ok, unit 10511 pass, 0 fail, 41 skip in 654 files; `server/release-notes.test.ts` and `src/lib/updateNotes.test.ts` 52 pass. - After the eleventh refresh (head `13fa0181`, merge of main `2b620462`): `bun scripts/release-guards.ts --base v0.4.21` and `--base origin/main` both "Release 0.4.22: remote bundle, telemetry Worker and release metadata are in order." (`REMOTE_BUNDLE_VERSION` stays 41; `remote-v41` is not tagged). `UNIT_TEST_WORKERS=4 dori heavy rel2473k -- bun run check fast` all ok, unit 10551 pass, 0 fail, 41 skip in 656 files; `server/release-notes.test.ts` and `src/lib/updateNotes.test.ts` 52 pass. - After the twelfth refresh (head `3ae2133e`, merge of main `64ae5e72`): both release guards "in order" (`--base v0.4.21` and `--base origin/main`); `UNIT_TEST_WORKERS=4 dori heavy rel2473l -- bun run check fast` all ok, unit 10553 pass, 0 fail, 41 skip in 656 files; release-notes tests 52 pass. - After the thirteenth refresh (head `aebaabbf`, merge of main `99a6671f`): both release guards "in order" (`--base v0.4.21` and `--base origin/main`); `UNIT_TEST_WORKERS=4 dori heavy rel2473m -- bun run check fast` all ok, unit 10553 pass, 0 fail, 41 skip in 656 files; release-notes tests 52 pass. - Not run: `bun run check full` (integration and browser), left to CI; no hands-on test of main, which is the owner's. This is a release-metadata PR: it changes no code path. Per the release steps, merge it after CI and the owner's go, then push `remote-v41`, wait for its bundles, and run Release with `0.4.22`. [exit 0]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Part of #992 (pictures in Chat), after #2479 (Copilot) and #2481 (Grok). Hermes v0.21.5 keeps no picture bytes in its store (checked on a real recording:
state.dbmessageshold no base64 or data URL, andvision_analyze's result is text only). A prompt with a picture is stored as its caption, an[Image attached at: <path>]hint per picture, and one[screenshot]stand-in per picture (agent/image_routing.py,agent/session_persistence.py).What changes: the chat reads that block the way Hermes's own history does (
tui_gateway/session_history.py) and shows each hint as a Markdown image of that local file. The chat's existing local Markdown image path then draws it: #2435'smarkdownImagePreview, which stats via/api/fs/stat, requireskind: image, caps at 20 MiB, fetches via/api/fs/file, and falls back to a link otherwise. No new route, no server file-serving change, no new UI. This is the same reach a user-typedin that bubble already has.[screenshot]. Hermes writes that stand-in for each picture it actually attached, so typed look-alike text stays text. URL hints, relative or Windows paths, malformed blocks and mismatched counts stay as written.localImageTargetreads back the exact path.Validation
server/fixtures/hermes-pictures-0.21.5-rows.json, the rows of a session recorded on this PC withhermes chat -q ... --image red.png(the vision tool then also readblue.png). Paths are redacted.server/hermes.test.tscase failed (the raw hint text was returned), then passed. It also covers URL, relative, Windows, trailing-text, placeholder-mismatch, no-placeholder, open-fence and[-in-name inputs, and a real skill-invocation fixture with a picture.bun run check faston ae5912f: all steps ok, unit 9828 pass, 0 fail, 41 skip./api/fs/statand/api/fs/fileanswered for the recorded path): the picture decodes in the prompt bubble on desktop and phone, with 0 page errors.Reviews