Skip to content

Sync 5.0.0 with main #8747

Merged
shuyama1 merged 115 commits into
FEATURE-BRANCH-major-release-5.0.0from
main_sync
Aug 24, 2023
Merged

Sync 5.0.0 with main #8747
shuyama1 merged 115 commits into
FEATURE-BRANCH-major-release-5.0.0from
main_sync

Conversation

@shuyama1

Copy link
Copy Markdown
Member

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


yanweiguo and others added 30 commits August 10, 2023 12:52
* Move some handwritten acc tests to service packages

This reverts commit 8ad92ee.

* Fix rebasing error
…beta to test writing docs (#8591)

* Added notes about ProtoV5ProviderBetaFactories and provider = google-beta to test writing docs

* Added note about replacing import paths
…gger.source_to_build, supporting manual, pub/sub and webhook triggers. (#8544)

Also fixes TestAccCloudBuildTrigger_basic_bitbucket test.

Co-authored-by: Mario Machado <mariomachado@google.com>
…oogle (#8526)

* add scalingConfig object for google_dataproc_metastore_service

* add an example of a DPMS 2 config

* remove invalid value for instanceSize

* WIP: Add tests for scaling_factor

* changes for ga provider

- removed google-beta provider
- removed fields from tests that require google-beta provider (gRPC)

* add exactly_one_of for instance_size and scaling_factor
* Add Backupdr with Management Server resource

* Fixing lint issue

* Fixing Variable name

* FIxing values of type and peering mode

* Fixing description and example

* Adding type and Peering_mode to coverage

* Changing release version of provider to only beta

* Changing variable name

* Fixing Acceptance test and trademark
* Generate Mmv1 test files to the service packages

* Fix test-fixtures

* Copy test-fixtures in service packages

* Replace test-fixtures path

* Fix rebasing errors

* Fix function usage

* Fix test TestAccBigQueryExternalDataTable_objectTable

* Fix test-fixtures

* Keep deprecated utility functions

* Move tests

* Fixing rebasing error

* Move more tests to the service packages

* Add back resource_resourcemanager_lien_test.go

* Change package name

* Fix test-fixtures

* Fix the test-fixtures
* Made reviewer assignment comment include detected reviewer type

Also made it clearly state whether tests will run automatically

* Temporarily made it run for core contributors

* Revert "Temporarily made it run for core contributors"

This reverts commit 18314a0.

* Fixed formatting for non-Googler comments

* gofmt

* Switched back to using the embedded string for the comment template

* Fixed conditions for posting new comment
* Build provider before running tests

* Exit if build fails

* Move pending status after build
…Y instead of deprecated INTERNAL_HTTPS_LOAD_BALANCER (#8571)

* Update subnetwork descriptions and tests to use REGIONAL_MANAGED_PROXY instead of deprecated INTERNAL_HTTPS_LOAD_BALANCER.

* Update mmv1/products/compute/Subnetwork.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/products/compute/Subnetwork.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/products/compute/Subnetwork.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/products/compute/Subnetwork.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/products/compute/Subnetwork.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/products/compute/Subnetwork.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Remove remaining references to INTERNAL_HTTPS_LOAD_BALANCER.

---------

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
…t resource (#8555)

* Added support for versionAliases field in google_secret_manager_secret resource

* Removed redundant test step from the version_aliases field testcases
…8629)

* Add `BRANCH_NAME` parameter to projects. This will be used by the manually-configured VCS root

* Update comment above where `BRANCH_NAME` is set
Also added unit tests for labeler and backfill script
… resource (#8625)

* Add a new supported value to the scope field in certificate resource

* Improve the naming of the examples to avoid concurrency errors while running acceptance tests

---------

Co-authored-by: Hamza Hassan <hamzahassan@google.com>
* Look for test files in service packages

* Remove TPG_LOCAL_PATH
* Move gcp_sweeper_test.go to the sweeper package

* Change the sweeper path
* Remove validation on max_bytes

* Test max_bytes less than 1000

* Revert max_bytes to valid value
* Add disk.provisioned_iops to compute_instance_template

* Add to region template as well

* Add provisioned_iops to disk characteristics that are used for array ordering
roaks3 and others added 5 commits August 23, 2023 09:51
* Clarify types of changes that should use release-note:none

* Move none release note under other tab

* Update docs/content/contribute/release-notes.md

Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>

---------

Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
@google-cla

google-cla Bot commented Aug 23, 2023

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2137 files changed, 250206 insertions(+), 236185 deletions(-))
Terraform Beta: Diff ( 2292 files changed, 296760 insertions(+), 279953 deletions(-))
TF Conversion: Diff ( 596 files changed, 8659 insertions(+), 15707 deletions(-))
TF OiCS: Diff ( 73 files changed, 1666 insertions(+), 61 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_artifact_registry_repository (23 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_artifact_registry_repository" "primary" {
  cleanup_policies {
    condition {
      newer_than            = # value needed
      version_name_prefixes = # value needed
    }
  }
}

Resource: google_compute_target_pool (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_target_pool" "primary" {
  security_policy = # value needed
}

Resource: google_container_cluster (229 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  ip_allocation_policy {
    additional_pod_ranges_config {
      pod_range_names = # value needed
    }
  }
}

Resource: google_dataplex_datascan (9 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_datascan" "primary" {
  data_quality_spec {
    post_scan_actions {
      bigquery_export {
        results_table = # value needed
      }
    }
  }
}

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2994
Passed tests 2564
Skipped tests: 301
Affected tests: 129

Action taken

Found 129 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccAlloydbCluster_restore|TestAccAlloydbBackup_alloydbBackupFullExample|TestAccAlloydbBackup_usingCMEK|TestAccAlloydbBackup_alloydbBackupBasicExample|TestAccAlloydbBackup_update|TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample|TestAccArtifactRegistryRepository_virtual|TestAccArtifactRegistryRepository_update|TestAccBackupDRManagementServer_backupDrManagementServerExample|TestAccBigQueryExternalDataTable_json|TestAccBigQueryTable_MonthlyTimePartitioning|TestAccBigQueryTable_RangePartitioning|TestAccBigQueryJob_bigqueryJobExtractExample|TestAccBigQueryTable_YearlyTimePartitioning|TestAccBigQueryTableIamBindingGenerated|TestAccBigQueryJob_bigqueryJobExtractTableReferenceExample|TestAccBigQueryTable_HourlyTimePartitioning|TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Update|TestAccBigQueryTable_HivePartitioningCustomSchema|TestAccBigQueryTable_Kms|TestAccBigQueryJob_bigqueryJobCopyExample|TestAccBigQueryJob_bigqueryJobCopyTableReferenceExample|TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTagNames|TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTag|TestAccBigQueryTable_Update_SchemaWithPolicyTagsToNoPolicyTag|TestAccBigQueryTable_Update_SchemaWithoutPolicyTagsToWithPolicyTags|TestAccBigQueryExternalDataTable_parquetOptions|TestAccBigQueryTable_Basic|TestAccBigQueryTableIamPolicyGenerated_withCondition|TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Basic|TestAccBigQueryDataTable_jsonEquivalency|TestAccBigQueryDataTable_canReorderParameters|TestAccBigQueryTable_allowDestroy|TestAccBigQueryDataTable_expandArray|TestAccBigQueryDataTable_sheet|TestAccBigQueryExternalDataTable_CSV_WithSchema_UpdateAllowQuotedNewlines|TestAccBigQueryTableIamBindingGenerated_withCondition|TestAccBigQueryExternalDataTable_CSV_WithSchema_UpdateToConnectionID|TestAccBigQueryExternalDataTable_CSV_WithSchemaAndConnectionID_UpdateNoConnectionID|TestAccBigQueryTableIamMemberGenerated_withCondition|TestAccBigQueryTableIamPolicyGenerated|TestAccBigQueryTableIamMemberGenerated|TestAccBigQueryExternalDataTable_CSV|TestAccBigqueryReservationBiReservation_bigqueryReservationBiReservationBasicExample|TestAccBigqueryReservationBiReservation_bigqueryReservationBiReservationFullExample|TestAccBigqueryReservationBiReservation_update|TestAccCertificateManagerTrustConfig_certificateManagerTrustConfigExample|TestAccCertificateManagerTrustConfig_update|TestAccCertificateManagerCertificate_certificateManagerSelfManagedCertificateExample|TestAccCertificateManagerCertificateIssuanceConfig_certificateManagerCertificateIssuanceConfigExample|TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateIssuanceConfigExample|TestAccCloudBuildTrigger_cloudbuildTriggerManualBitbucketServerExample|TestAccCloudBuildTrigger_basic_bitbucket|TestAccCloudBuildTrigger_cloudbuildTriggerAllowFailureExample|TestAccCloudBuildTrigger_cloudbuildTriggerAllowExitCodesExample|TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleNetworkMatchUpdate|TestAccComputeTargetInstance_withSecurityPolicy|TestAccComputeTargetPool_withSecurityPolicy|TestAccComputeRegionSecurityPolicy_regionSecurityPolicyUserDefinedFieldsUpdate|TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleBasicUpdate|TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleMultipleRulesExample|TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleBasicExample|TestAccComputeRegionSecurityPolicy_regionSecurityPolicyBasicUpdateExample|TestAccComputeInstance_regionBootDisk|TestAccComputeRegionSecurityPolicy_regionSecurityPolicyWithUserDefinedFieldsExample|TestAccComputeNetworkEdgeSecurityService_computeNetworkEdgeSecurityServiceBasicExample|TestAccComputeInstanceTemplate_diskIops|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeSubnetwork_subnetworkInternalL7lbExample|TestAccComputeRegionInstanceTemplate_diskIops|TestAccComputeSecurityPolicy_withAdvancedOptionsConfig|TestAccComputeTargetInstance_targetInstanceWithSecurityPolicyExample|TestAccContainerCluster_additional_pod_ranges_config_on_update|TestAccContainerCluster_additional_pod_ranges_config_on_create|TestAccContainerAwsCluster_BetaBasicEnumHandWritten|TestAccContainerAwsNodePool_BetaBasicEnumHandWritten|TestAccContainerAwsCluster_BasicEnumHandWritten|TestAccContainerAwsNodePool_BasicEnumHandWritten|TestAccContainerAzureCluster_BetaBasicEnumHandWritten|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample|TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample|TestAccDataLossPreventionJobTrigger_dlpJobTriggerChangingActions|TestAccDataLossPreventionJobTrigger_dlpJobTriggerDeidentifyUpdate|TestAccDataLossPreventionJobTrigger_dlpJobTriggerDeidentifyExample|TestAccDataplexDatascan_dataplexDatascanFullProfileExample|TestAccDataplexDatascan_dataplexDatascanBasicQualityExample|TestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2ScalingFactorExample|TestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2Example|TestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2ScalingFactorLt1Example|TestAccDNSRecordSet_routingPolicy|TestAccDNSResponsePolicy_update|TestAccFirebaseWebApp_firebaseWebAppCustomApiKeyExample|TestAccFirebaseAndroidApp_firebaseAndroidAppCustomApiKeyExample|TestAccFirebaseAppleApp_firebaseAppleAppFullExample|TestAccFirebaseAndroidApp_update|TestAccFirebaseAppleApp_update|TestAccGKEHub2MembershipRBACRoleBinding_gkehubMembershipRbacRoleBindingBasicExample|TestAccGkeonpremBareMetalAdminCluster_gkeonpremBareMetalAdminClusterBasicExample|TestAccGkeonpremBareMetalAdminCluster_gkeonpremBareMetalAdminClusterFullExample|TestAccMemcacheInstance_memcacheInstanceBasicExample|TestAccMemcacheInstance_update|TestAccPubsubSubscription_pubsubSubscriptionPushBqExample|TestAccRedisInstance_redisInstancePrivateServiceExample|TestAccSecretManagerSecret_versionAliasesUpdate|TestAccSpannerDatabaseIamPolicy|TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject|TestAccSqlDatabaseInstance_withPSCEnabled_withAllowedConsumerProjects|TestAccSqlDatabaseInstance_withPSCEnabled_withEmptyAllowedConsumerProjects|TestAccSqlDatabaseInstance_withPSCEnabled_withoutAllowedConsumerProjects|TestAccSqlDatabaseInstance_withPSCEnabled_withIpV4Enabled|TestAccSqlDatabaseInstance_basicInstance_thenPSCEnabled|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone|TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica|TestAccSqlDatabaseInstance_ReplicaPromoteSkippedWithNoMasterInstanceNameAndNoReplicaConfigurationPresent|TestAccDataSourceSqlDatabaseInstanceLatestRecoveryTime_basic|TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica|TestAccSqlDatabaseInstance_ReplicaPromoteSuccessful|TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithMasterInstanceNameAndReplicaConfigurationPresent|TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithReplicaConfigurationPresent|TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithMasterInstanceNamePresent|TestAccWorkstationsWorkstationConfig_workstationConfigContainerExample|TestAccWorkstationsWorkstationConfig_update|TestAccWorkstationsWorkstationConfig_updateHostDetails

Get to know how VCR tests work

@shuyama1

Copy link
Copy Markdown
Member Author

/gcbrun

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2137 files changed, 250206 insertions(+), 236185 deletions(-))
Terraform Beta: Diff ( 2292 files changed, 296760 insertions(+), 279953 deletions(-))
TF Conversion: Diff ( 596 files changed, 8659 insertions(+), 15707 deletions(-))
TF OiCS: Diff ( 73 files changed, 1666 insertions(+), 61 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_artifact_registry_repository (23 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_artifact_registry_repository" "primary" {
  cleanup_policies {
    condition {
      newer_than            = # value needed
      version_name_prefixes = # value needed
    }
  }
}

Resource: google_compute_target_pool (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_target_pool" "primary" {
  security_policy = # value needed
}

Resource: google_container_cluster (229 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  ip_allocation_policy {
    additional_pod_ranges_config {
      pod_range_names = # value needed
    }
  }
}

Resource: google_dataplex_datascan (9 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_datascan" "primary" {
  data_quality_spec {
    post_scan_actions {
      bigquery_export {
        results_table = # value needed
      }
    }
  }
}

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2994
Passed tests 2688
Skipped tests: 301
Affected tests: 5

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeTargetInstance_withSecurityPolicy|TestAccComputeInstance_regionBootDisk|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccDataplexDatascan_dataplexDatascanFullProfileExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeTargetInstance_withSecurityPolicy[Debug log]
TestAccComputeInstance_regionBootDisk[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataplexDatascan_dataplexDatascanFullProfileExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2137 files changed, 250502 insertions(+), 236185 deletions(-))
Terraform Beta: Diff ( 2292 files changed, 297056 insertions(+), 279958 deletions(-))
TF Conversion: Diff ( 596 files changed, 8768 insertions(+), 15707 deletions(-))
TF OiCS: Diff ( 73 files changed, 1666 insertions(+), 61 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_artifact_registry_repository (23 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_artifact_registry_repository" "primary" {
  cleanup_policies {
    condition {
      newer_than            = # value needed
      version_name_prefixes = # value needed
    }
  }
}

Resource: google_compute_target_pool (30 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_target_pool" "primary" {
  security_policy = # value needed
}

Resource: google_container_cluster (229 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_container_cluster" "primary" {
  ip_allocation_policy {
    additional_pod_ranges_config {
      pod_range_names = # value needed
    }
  }
}

Resource: google_dataplex_datascan (9 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_datascan" "primary" {
  data_profile_spec {
    post_scan_actions {
      bigquery_export {
        results_table = # value needed
      }
    }
  }
  data_quality_spec {
    post_scan_actions {
      bigquery_export {
        results_table = # value needed
      }
    }
  }
}

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2994
Passed tests 2691
Skipped tests: 301
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataplexDatascan_dataplexDatascanFullProfileExample|TestAccHealthcareDatasetIamPolicy

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataplexDatascan_dataplexDatascanFullProfileExample[Debug log]
TestAccHealthcareDatasetIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@shuyama1
shuyama1 requested review from a team and ScottSuarez and removed request for a team August 24, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.