Sync 5.0.0 with main #8747
Conversation
* Move some handwritten acc tests to service packages This reverts commit 8ad92ee. * Fix rebasing error
…beta to test writing docs (#8591) * Added notes about ProtoV5ProviderBetaFactories and provider = google-beta to test writing docs * Added note about replacing import paths
OOO until 8/18
…gger.source_to_build, supporting manual, pub/sub and webhook triggers. (#8544) Also fixes TestAccCloudBuildTrigger_basic_bitbucket test. Co-authored-by: Mario Machado <mariomachado@google.com>
…oogle (#8526) * add scalingConfig object for google_dataproc_metastore_service * add an example of a DPMS 2 config * remove invalid value for instanceSize * WIP: Add tests for scaling_factor * changes for ga provider - removed google-beta provider - removed fields from tests that require google-beta provider (gRPC) * add exactly_one_of for instance_size and scaling_factor
* Add Backupdr with Management Server resource * Fixing lint issue * Fixing Variable name * FIxing values of type and peering mode * Fixing description and example * Adding type and Peering_mode to coverage * Changing release version of provider to only beta * Changing variable name * Fixing Acceptance test and trademark
* Generate Mmv1 test files to the service packages * Fix test-fixtures * Copy test-fixtures in service packages * Replace test-fixtures path * Fix rebasing errors * Fix function usage * Fix test TestAccBigQueryExternalDataTable_objectTable * Fix test-fixtures * Keep deprecated utility functions * Move tests * Fixing rebasing error * Move more tests to the service packages * Add back resource_resourcemanager_lien_test.go * Change package name * Fix test-fixtures * Fix the test-fixtures
* Made reviewer assignment comment include detected reviewer type Also made it clearly state whether tests will run automatically * Temporarily made it run for core contributors * Revert "Temporarily made it run for core contributors" This reverts commit 18314a0. * Fixed formatting for non-Googler comments * gofmt * Switched back to using the embedded string for the comment template * Fixed conditions for posting new comment
* Build provider before running tests * Exit if build fails * Move pending status after build
…Y instead of deprecated INTERNAL_HTTPS_LOAD_BALANCER (#8571) * Update subnetwork descriptions and tests to use REGIONAL_MANAGED_PROXY instead of deprecated INTERNAL_HTTPS_LOAD_BALANCER. * Update mmv1/products/compute/Subnetwork.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Update mmv1/products/compute/Subnetwork.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Update mmv1/products/compute/Subnetwork.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Update mmv1/products/compute/Subnetwork.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Update mmv1/products/compute/Subnetwork.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Update mmv1/products/compute/Subnetwork.yaml Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com> * Remove remaining references to INTERNAL_HTTPS_LOAD_BALANCER. --------- Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
This reverts commit 63eca84.
…t resource (#8555) * Added support for versionAliases field in google_secret_manager_secret resource * Removed redundant test step from the version_aliases field testcases
…8629) * Add `BRANCH_NAME` parameter to projects. This will be used by the manually-configured VCS root * Update comment above where `BRANCH_NAME` is set
Also added unit tests for labeler and backfill script
… resource (#8625) * Add a new supported value to the scope field in certificate resource * Improve the naming of the examples to avoid concurrency errors while running acceptance tests --------- Co-authored-by: Hamza Hassan <hamzahassan@google.com>
* Look for test files in service packages * Remove TPG_LOCAL_PATH
* Move gcp_sweeper_test.go to the sweeper package * Change the sweeper path
…dentMapping's default value (#8634)
* Remove validation on max_bytes * Test max_bytes less than 1000 * Revert max_bytes to valid value
* Add disk.provisioned_iops to compute_instance_template * Add to region template as well * Add provisioned_iops to disk characteristics that are used for array ordering
* Clarify types of changes that should use release-note:none * Move none release note under other tab * Update docs/content/contribute/release-notes.md Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com> --------- Co-authored-by: Stephen Lewis (Burrows) <stephenrlewis@google.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2137 files changed, 250206 insertions(+), 236185 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_artifact_registry_repository" "primary" {
cleanup_policies {
condition {
newer_than = # value needed
version_name_prefixes = # value needed
}
}
}
Resource: resource "google_compute_target_pool" "primary" {
security_policy = # value needed
}
Resource: resource "google_container_cluster" "primary" {
ip_allocation_policy {
additional_pod_ranges_config {
pod_range_names = # value needed
}
}
}
Resource: resource "google_dataplex_datascan" "primary" {
data_quality_spec {
post_scan_actions {
bigquery_export {
results_table = # value needed
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 129 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccAlloydbCluster_restore|TestAccAlloydbBackup_alloydbBackupFullExample|TestAccAlloydbBackup_usingCMEK|TestAccAlloydbBackup_alloydbBackupBasicExample|TestAccAlloydbBackup_update|TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample|TestAccArtifactRegistryRepository_virtual|TestAccArtifactRegistryRepository_update|TestAccBackupDRManagementServer_backupDrManagementServerExample|TestAccBigQueryExternalDataTable_json|TestAccBigQueryTable_MonthlyTimePartitioning|TestAccBigQueryTable_RangePartitioning|TestAccBigQueryJob_bigqueryJobExtractExample|TestAccBigQueryTable_YearlyTimePartitioning|TestAccBigQueryTableIamBindingGenerated|TestAccBigQueryJob_bigqueryJobExtractTableReferenceExample|TestAccBigQueryTable_HourlyTimePartitioning|TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Update|TestAccBigQueryTable_HivePartitioningCustomSchema|TestAccBigQueryTable_Kms|TestAccBigQueryJob_bigqueryJobCopyExample|TestAccBigQueryJob_bigqueryJobCopyTableReferenceExample|TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTagNames|TestAccBigQueryTable_Update_SchemaWithPolicyTagsToEmptyPolicyTag|TestAccBigQueryTable_Update_SchemaWithPolicyTagsToNoPolicyTag|TestAccBigQueryTable_Update_SchemaWithoutPolicyTagsToWithPolicyTags|TestAccBigQueryExternalDataTable_parquetOptions|TestAccBigQueryTable_Basic|TestAccBigQueryTableIamPolicyGenerated_withCondition|TestAccBigQueryTable_MaterializedView_DailyTimePartioning_Basic|TestAccBigQueryDataTable_jsonEquivalency|TestAccBigQueryDataTable_canReorderParameters|TestAccBigQueryTable_allowDestroy|TestAccBigQueryDataTable_expandArray|TestAccBigQueryDataTable_sheet|TestAccBigQueryExternalDataTable_CSV_WithSchema_UpdateAllowQuotedNewlines|TestAccBigQueryTableIamBindingGenerated_withCondition|TestAccBigQueryExternalDataTable_CSV_WithSchema_UpdateToConnectionID|TestAccBigQueryExternalDataTable_CSV_WithSchemaAndConnectionID_UpdateNoConnectionID|TestAccBigQueryTableIamMemberGenerated_withCondition|TestAccBigQueryTableIamPolicyGenerated|TestAccBigQueryTableIamMemberGenerated|TestAccBigQueryExternalDataTable_CSV|TestAccBigqueryReservationBiReservation_bigqueryReservationBiReservationBasicExample|TestAccBigqueryReservationBiReservation_bigqueryReservationBiReservationFullExample|TestAccBigqueryReservationBiReservation_update|TestAccCertificateManagerTrustConfig_certificateManagerTrustConfigExample|TestAccCertificateManagerTrustConfig_update|TestAccCertificateManagerCertificate_certificateManagerSelfManagedCertificateExample|TestAccCertificateManagerCertificateIssuanceConfig_certificateManagerCertificateIssuanceConfigExample|TestAccCertificateManagerCertificate_certificateManagerGoogleManagedCertificateIssuanceConfigExample|TestAccCloudBuildTrigger_cloudbuildTriggerManualBitbucketServerExample|TestAccCloudBuildTrigger_basic_bitbucket|TestAccCloudBuildTrigger_cloudbuildTriggerAllowFailureExample|TestAccCloudBuildTrigger_cloudbuildTriggerAllowExitCodesExample|TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccDataSourceGoogleCloudFunctionsFunction_basic|TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleNetworkMatchUpdate|TestAccComputeTargetInstance_withSecurityPolicy|TestAccComputeTargetPool_withSecurityPolicy|TestAccComputeRegionSecurityPolicy_regionSecurityPolicyUserDefinedFieldsUpdate|TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleBasicUpdate|TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleMultipleRulesExample|TestAccComputeRegionSecurityPolicyRule_regionSecurityPolicyRuleBasicExample|TestAccComputeRegionSecurityPolicy_regionSecurityPolicyBasicUpdateExample|TestAccComputeInstance_regionBootDisk|TestAccComputeRegionSecurityPolicy_regionSecurityPolicyWithUserDefinedFieldsExample|TestAccComputeNetworkEdgeSecurityService_computeNetworkEdgeSecurityServiceBasicExample|TestAccComputeInstanceTemplate_diskIops|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccComputeSubnetwork_subnetworkInternalL7lbExample|TestAccComputeRegionInstanceTemplate_diskIops|TestAccComputeSecurityPolicy_withAdvancedOptionsConfig|TestAccComputeTargetInstance_targetInstanceWithSecurityPolicyExample|TestAccContainerCluster_additional_pod_ranges_config_on_update|TestAccContainerCluster_additional_pod_ranges_config_on_create|TestAccContainerAwsCluster_BetaBasicEnumHandWritten|TestAccContainerAwsNodePool_BetaBasicEnumHandWritten|TestAccContainerAwsCluster_BasicEnumHandWritten|TestAccContainerAwsNodePool_BasicEnumHandWritten|TestAccContainerAzureCluster_BetaBasicEnumHandWritten|TestAccDatabaseMigrationServiceConnectionProfile_databaseMigrationServiceConnectionProfileCloudsqlExample|TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample|TestAccDataLossPreventionJobTrigger_dlpJobTriggerChangingActions|TestAccDataLossPreventionJobTrigger_dlpJobTriggerDeidentifyUpdate|TestAccDataLossPreventionJobTrigger_dlpJobTriggerDeidentifyExample|TestAccDataplexDatascan_dataplexDatascanFullProfileExample|TestAccDataplexDatascan_dataplexDatascanBasicQualityExample|TestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2ScalingFactorExample|TestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2Example|TestAccDataprocMetastoreService_dataprocMetastoreServiceDpms2ScalingFactorLt1Example|TestAccDNSRecordSet_routingPolicy|TestAccDNSResponsePolicy_update|TestAccFirebaseWebApp_firebaseWebAppCustomApiKeyExample|TestAccFirebaseAndroidApp_firebaseAndroidAppCustomApiKeyExample|TestAccFirebaseAppleApp_firebaseAppleAppFullExample|TestAccFirebaseAndroidApp_update|TestAccFirebaseAppleApp_update|TestAccGKEHub2MembershipRBACRoleBinding_gkehubMembershipRbacRoleBindingBasicExample|TestAccGkeonpremBareMetalAdminCluster_gkeonpremBareMetalAdminClusterBasicExample|TestAccGkeonpremBareMetalAdminCluster_gkeonpremBareMetalAdminClusterFullExample|TestAccMemcacheInstance_memcacheInstanceBasicExample|TestAccMemcacheInstance_update|TestAccPubsubSubscription_pubsubSubscriptionPushBqExample|TestAccRedisInstance_redisInstancePrivateServiceExample|TestAccSecretManagerSecret_versionAliasesUpdate|TestAccSpannerDatabaseIamPolicy|TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject|TestAccSqlDatabaseInstance_withPSCEnabled_withAllowedConsumerProjects|TestAccSqlDatabaseInstance_withPSCEnabled_withEmptyAllowedConsumerProjects|TestAccSqlDatabaseInstance_withPSCEnabled_withoutAllowedConsumerProjects|TestAccSqlDatabaseInstance_withPSCEnabled_withIpV4Enabled|TestAccSqlDatabaseInstance_basicInstance_thenPSCEnabled|TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone|TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica|TestAccSqlDatabaseInstance_ReplicaPromoteSkippedWithNoMasterInstanceNameAndNoReplicaConfigurationPresent|TestAccDataSourceSqlDatabaseInstanceLatestRecoveryTime_basic|TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls|TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica|TestAccSqlDatabaseInstance_ReplicaPromoteSuccessful|TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithMasterInstanceNameAndReplicaConfigurationPresent|TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithReplicaConfigurationPresent|TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithMasterInstanceNamePresent|TestAccWorkstationsWorkstationConfig_workstationConfigContainerExample|TestAccWorkstationsWorkstationConfig_update|TestAccWorkstationsWorkstationConfig_updateHostDetails |
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2137 files changed, 250206 insertions(+), 236185 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_artifact_registry_repository" "primary" {
cleanup_policies {
condition {
newer_than = # value needed
version_name_prefixes = # value needed
}
}
}
Resource: resource "google_compute_target_pool" "primary" {
security_policy = # value needed
}
Resource: resource "google_container_cluster" "primary" {
ip_allocation_policy {
additional_pod_ranges_config {
pod_range_names = # value needed
}
}
}
Resource: resource "google_dataplex_datascan" "primary" {
data_quality_spec {
post_scan_actions {
bigquery_export {
results_table = # value needed
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeTargetInstance_withSecurityPolicy|TestAccComputeInstance_regionBootDisk|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample|TestAccDataplexDatascan_dataplexDatascanFullProfileExample |
|
Rerun these tests in REPLAYING mode to catch issues
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 2137 files changed, 250502 insertions(+), 236185 deletions(-)) Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_artifact_registry_repository" "primary" {
cleanup_policies {
condition {
newer_than = # value needed
version_name_prefixes = # value needed
}
}
}
Resource: resource "google_compute_target_pool" "primary" {
security_policy = # value needed
}
Resource: resource "google_container_cluster" "primary" {
ip_allocation_policy {
additional_pod_ranges_config {
pod_range_names = # value needed
}
}
}
Resource: resource "google_dataplex_datascan" "primary" {
data_profile_spec {
post_scan_actions {
bigquery_export {
results_table = # value needed
}
}
}
data_quality_spec {
post_scan_actions {
bigquery_export {
results_table = # value needed
}
}
}
}
|
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccDataplexDatascan_dataplexDatascanFullProfileExample|TestAccHealthcareDatasetIamPolicy |
|
Rerun these tests in REPLAYING mode to catch issues
|
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)