Bitbucket Trigger support for Manual, Pub/Sub and Webhook triggers#8544
Conversation
|
Hello! I am a robot. It looks like you are a community contributor. @hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 137 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccCloudBuildTrigger_cloudbuildTriggerPubsubWithRepoExample|TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample|TestAccCloudBuildTrigger_cloudbuildTriggerPubsubConfigExample|TestAccCloudBuildTrigger_cloudbuildTriggerManualBitbucketServerExample|TestAccCloudBuildTrigger_cloudbuildTriggerManualExample|TestAccCloudBuildTrigger_basic_bitbucket|TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample |
|
Rerun these tests in REPLAYING mode to catch issues
|
hao-nan-li
left a comment
There was a problem hiding this comment.
Looks like this introduced couple new failing tests, could you take a look into it?
1dccb49 to
c43b0dc
Compare
|
I expect the 2 Bitbucket tests to still fail: Our api has the required feature for these tests behind an experiment. When we are close to launch I will allowlist the test projects and rerun the tests |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 133 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccCloudBuildTrigger_basic_bitbucket|TestAccCloudBuildTrigger_cloudbuildTriggerManualBitbucketServerExample |
|
|
Thanks for the explanation. Do you plan to get your change merged and released anytime soon? Could we wait until these tests can get fixed before merging? |
…gger.source_to_build, supporting manual, pub/sub and webhook triggers. Also fixes TestAccCloudBuildTrigger_basic_bitbucket test.
c43b0dc to
cb5411b
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are. Terraform GA: Diff ( 4 files changed, 133 insertions(+)) |
Tests analyticsTotal tests: Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccCloudBuildTrigger_basic_bitbucket|TestAccCloudBuildTrigger_cloudbuildTriggerManualBitbucketServerExample |
|
Rerun these tests in REPLAYING mode to catch issues
|
…gger.source_to_build, supporting manual, pub/sub and webhook triggers. (GoogleCloudPlatform#8544) Also fixes TestAccCloudBuildTrigger_basic_bitbucket test. Co-authored-by: Mario Machado <mariomachado@google.com>
…gger.source_to_build, supporting manual, pub/sub and webhook triggers. (GoogleCloudPlatform#8544) Also fixes TestAccCloudBuildTrigger_basic_bitbucket test. Co-authored-by: Mario Machado <mariomachado@google.com>
…gger.source_to_build, supporting manual, pub/sub and webhook triggers. (GoogleCloudPlatform#8544) Also fixes TestAccCloudBuildTrigger_basic_bitbucket test. Co-authored-by: Mario Machado <mariomachado@google.com>
…gger.source_to_build, supporting manual, pub/sub and webhook triggers. (GoogleCloudPlatform#8544) Also fixes TestAccCloudBuildTrigger_basic_bitbucket test. Co-authored-by: Mario Machado <mariomachado@google.com>
…gger.source_to_build, supporting manual, pub/sub and webhook triggers. (GoogleCloudPlatform#8544) Also fixes TestAccCloudBuildTrigger_basic_bitbucket test. Co-authored-by: Mario Machado <mariomachado@google.com>
Adds field bitbucket_server_config to Trigger.git_file_source and Trigger.source_to_build, supporting manual, pub/sub and webhook triggers.
Also fixes TestAccCloudBuildTrigger_basic_bitbucket test.
fixes hashicorp/terraform-provider-google#15079
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintin the generated providers to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)