Skip to content

Added notes about ProtoV5ProviderBetaFactories and provider = google-beta to test writing docs#8591

Merged
melinath merged 2 commits into
mainfrom
yaqs-4716615711600934912
Aug 10, 2023
Merged

Added notes about ProtoV5ProviderBetaFactories and provider = google-beta to test writing docs#8591
melinath merged 2 commits into
mainfrom
yaqs-4716615711600934912

Conversation

@melinath

@melinath melinath commented Aug 9, 2023

Copy link
Copy Markdown
Member

yaqs/4716615711600934912. I've left off the new information for the create tests because those are recommended to generate from MMv1 (which will already handle this for users) but added it to the update tests because those are fully handwritten.


@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@melinath
melinath requested review from a team and zli82016 and removed request for a team August 9, 2023 21:49
Comment thread docs/content/develop/resource.md
@melinath
melinath requested a review from zli82016 August 10, 2023 20:44
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@zli82016 zli82016 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@melinath
melinath merged commit be5cd8a into main Aug 10, 2023
@melinath
melinath deleted the yaqs-4716615711600934912 branch August 10, 2023 21:25
@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2939
Passed tests 2637
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 21, 2023
…beta to test writing docs (GoogleCloudPlatform#8591)

* Added notes about ProtoV5ProviderBetaFactories and provider = google-beta to test writing docs

* Added note about replacing import paths
joelkattapuram pushed a commit to joelkattapuram/magic-modules that referenced this pull request Sep 20, 2023
…beta to test writing docs (GoogleCloudPlatform#8591)

* Added notes about ProtoV5ProviderBetaFactories and provider = google-beta to test writing docs

* Added note about replacing import paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants