Move acc tests to service package (mmv1 + related handwritten) by zli82016 · Pull Request #8378 · GoogleCloudPlatform/magic-modules

zli82016 · 2023-07-18T21:32:36Z

As we don't want to move all of the tests in one PR. The PR 8272 is going to be split into two PRs. This is the second PR.

Generate Mmv1 tests to the specific service packages
Move some handwritten tests to the specific service packages. These tests share the same CheckDestroy functions generated in the MMv1 tests.
Copy test-fixtures to the specific service packages
Move function createZIPArchiveForCloudFunctionSource to the acctest package
Move function testBucketName to the acctest package

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

modular-magician · 2023-07-18T21:53:14Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1148 files changed, 143911 insertions(+), 143164 deletions(-))
Terraform Beta: Diff ( 1275 files changed, 176391 insertions(+), 175648 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 14 files changed, 19 insertions(+), 19 deletions(-))

modular-magician · 2023-07-18T22:06:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1148 files changed, 143944 insertions(+), 143197 deletions(-))
Terraform Beta: Diff ( 1275 files changed, 176424 insertions(+), 175681 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 14 files changed, 19 insertions(+), 19 deletions(-))

modular-magician · 2023-07-18T23:41:26Z

Tests analytics

Total tests: 2864
Passed tests 2555
Skipped tests: 299
Affected tests: 10

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules|TestAccServiceAccountKey_fromCertificate|TestAccDataSourceComputeRegionSslCertificate|TestAccDataSourceComputeSslCertificate|TestAccAppEngineServiceNetworkSettings_update|TestAccBigQueryExternalDataTable_objectTable|TestAccBigQueryExternalDataTable_parquetOptions|TestAccComputeInstance_minCpuPlatform|TestAccFirebaseHostingVersion_firebasehostingVersionCloudFunctionsExample

Get to know how VCR tests work

modular-magician · 2023-07-18T23:51:29Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeInstance_minCpuPlatform[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccServiceAccountKey_fromCertificate[Error message] [Debug log]
TestAccDataSourceComputeRegionSslCertificate[Error message] [Debug log]
TestAccDataSourceComputeSslCertificate[Error message] [Debug log]
TestAccAppEngineServiceNetworkSettings_update[Error message] [Debug log]
TestAccBigQueryExternalDataTable_objectTable[Error message] [Debug log]
TestAccBigQueryExternalDataTable_parquetOptions[Error message] [Debug log]
TestAccFirebaseHostingVersion_firebasehostingVersionCloudFunctionsExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-07-19T04:12:23Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1148 files changed, 143944 insertions(+), 143197 deletions(-))
Terraform Beta: Diff ( 1275 files changed, 176424 insertions(+), 175681 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 14 files changed, 19 insertions(+), 19 deletions(-))

modular-magician · 2023-07-19T04:28:16Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1140 files changed, 143926 insertions(+), 143179 deletions(-))
Terraform Beta: Diff ( 1267 files changed, 176406 insertions(+), 175663 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 14 files changed, 19 insertions(+), 19 deletions(-))

modular-magician · 2023-07-19T06:04:03Z

Tests analytics

Total tests: 2864
Passed tests 2563
Skipped tests: 299
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccContainerAwsNodePool_BetaBasicHandWritten|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

modular-magician · 2023-07-19T06:07:01Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-07-19T15:54:37Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1141 files changed, 143938 insertions(+), 143179 deletions(-))
Terraform Beta: Diff ( 1268 files changed, 176418 insertions(+), 175663 deletions(-))
TF Conversion: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 14 files changed, 19 insertions(+), 19 deletions(-))

modular-magician · 2023-07-19T17:25:46Z

Tests analytics

Total tests: 2864
Passed tests 2563
Skipped tests: 299
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeFirewallPolicyRule_multipleRules|TestAccContainerAwsNodePool_BetaBasicHandWritten

Get to know how VCR tests work

modular-magician · 2023-07-19T17:28:27Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccContainerAwsNodePool_BetaBasicHandWritten[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

zli82016 · 2023-08-10T18:22:35Z

Rebased the main branch to resolve the conflicts.

modular-magician · 2023-08-10T20:28:18Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1187 files changed, 150010 insertions(+), 149266 deletions(-))
Terraform Beta: Diff ( 1316 files changed, 183378 insertions(+), 182665 deletions(-))
TF OiCS: Diff ( 14 files changed, 19 insertions(+), 19 deletions(-))

modular-magician · 2023-08-10T20:55:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1281 files changed, 161131 insertions(+), 160499 deletions(-))
Terraform Beta: Diff ( 1410 files changed, 194699 insertions(+), 194098 deletions(-))
TF OiCS: Diff ( 14 files changed, 19 insertions(+), 19 deletions(-))

modular-magician · 2023-08-10T21:30:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1282 files changed, 161245 insertions(+), 160499 deletions(-))
Terraform Beta: Diff ( 1411 files changed, 194813 insertions(+), 194098 deletions(-))
TF OiCS: Diff ( 14 files changed, 19 insertions(+), 19 deletions(-))

modular-magician · 2023-08-10T22:42:00Z

Tests analytics

Total tests: 2939
Passed tests 2629
Skipped tests: 302
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAppEngineServiceNetworkSettings_update|TestAccBigQueryExternalDataTable_parquetFileSetSpecType|TestAccBigQueryExternalDataTable_queryAcceleration|TestAccBigQueryExternalDataTable_iceberg|TestAccCloudfunctions2function_cloudfunctions2CmekExample|TestAccDataSourceComputeSslCertificate|TestAccDataSourceComputeRegionSslCertificate|TestAccServiceAccountKey_fromCertificate

Get to know how VCR tests work

modular-magician · 2023-08-10T22:49:49Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineServiceNetworkSettings_update[Error message] [Debug log]
TestAccBigQueryExternalDataTable_parquetFileSetSpecType[Error message] [Debug log]
TestAccBigQueryExternalDataTable_queryAcceleration[Error message] [Debug log]
TestAccBigQueryExternalDataTable_iceberg[Error message] [Debug log]
TestAccCloudfunctions2function_cloudfunctions2CmekExample[Error message] [Debug log]
TestAccDataSourceComputeSslCertificate[Error message] [Debug log]
TestAccDataSourceComputeRegionSslCertificate[Error message] [Debug log]
TestAccServiceAccountKey_fromCertificate[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

modular-magician · 2023-08-10T23:19:03Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1284 files changed, 161315 insertions(+), 160499 deletions(-))
Terraform Beta: Diff ( 1413 files changed, 194883 insertions(+), 194098 deletions(-))
TF OiCS: Diff ( 14 files changed, 19 insertions(+), 19 deletions(-))

modular-magician · 2023-08-11T00:28:31Z

Tests analytics

Total tests: 2939
Passed tests 2636
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudfunctions2function_cloudfunctions2CmekExample

Get to know how VCR tests work

modular-magician · 2023-08-11T00:29:40Z

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudfunctions2function_cloudfunctions2CmekExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

zli82016 · 2023-08-11T16:52:39Z

Rebased the main branch to resolve the conflicts.

modular-magician · 2023-08-11T17:02:16Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1284 files changed, 161502 insertions(+), 160686 deletions(-))
Terraform Beta: Diff ( 1413 files changed, 195070 insertions(+), 194285 deletions(-))
TF OiCS: Diff ( 14 files changed, 19 insertions(+), 19 deletions(-))

modular-magician · 2023-08-11T18:16:45Z

Tests analytics

Total tests: 2943
Passed tests 2640
Skipped tests: 302
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

modular-magician · 2023-08-11T18:19:28Z

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

…eCloudPlatform#8378) * Generate Mmv1 test files to the service packages * Fix test-fixtures * Copy test-fixtures in service packages * Replace test-fixtures path * Fix rebasing errors * Fix function usage * Fix test TestAccBigQueryExternalDataTable_objectTable * Fix test-fixtures * Keep deprecated utility functions * Move tests * Fixing rebasing error * Move more tests to the service packages * Add back resource_resourcemanager_lien_test.go * Change package name * Fix test-fixtures * Fix the test-fixtures

zli82016 force-pushed the move-acc-tests-to-service-package-mmv1 branch from de5f3e5 to 8e35a37 Compare July 18, 2023 21:33

zli82016 changed the title ~~Move acc tests to service package mmv1~~ Move acc tests to service package (mmv1 + related handwritten) Jul 18, 2023

zli82016 force-pushed the move-acc-tests-to-service-package-mmv1 branch from f6aeb92 to 900c5e3 Compare July 18, 2023 21:54

zli82016 closed this Jul 19, 2023

zli82016 reopened this Jul 19, 2023

zli82016 requested a review from slevenick July 19, 2023 17:37

slevenick approved these changes Jul 20, 2023

View reviewed changes

zli82016 force-pushed the move-acc-tests-to-service-package-mmv1 branch 2 times, most recently from 4c4fb70 to 1e13f5d Compare August 10, 2023 18:22

zli82016 force-pushed the move-acc-tests-to-service-package-mmv1 branch from 895ff54 to bca4958 Compare August 10, 2023 20:19

zli82016 added 14 commits August 11, 2023 09:47

Copy test-fixtures in service packages

5ff59ea

Replace test-fixtures path

5e62728

Fix rebasing errors

1fb68ea

Fix function usage

eb9035e

Fix test TestAccBigQueryExternalDataTable_objectTable

983a6a8

Fix test-fixtures

1381631

Keep deprecated utility functions

de2da86

Move tests

bff06cd

Fixing rebasing error

c663e94

Move more tests to the service packages

69eb7fc

Add back resource_resourcemanager_lien_test.go

aa15cf2

Change package name

c8db3d2

Fix test-fixtures

00ab841

Fix the test-fixtures

9d73c52

zli82016 force-pushed the move-acc-tests-to-service-package-mmv1 branch from de3436b to 9d73c52 Compare August 11, 2023 16:52

zli82016 merged commit dcedf6a into main Aug 11, 2023

zli82016 deleted the move-acc-tests-to-service-package-mmv1 branch August 11, 2023 21:36

shuyama1 mentioned this pull request Aug 16, 2023

Add support for restoring AlloyDB clusters via backup restore and PITR #8575

Merged

5 tasks

Uh oh!

Conversation

zli82016 commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented Jul 18, 2023

Diff report

Uh oh!

modular-magician commented Jul 18, 2023

Diff report

Uh oh!

modular-magician commented Jul 18, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Jul 18, 2023

Rerun these tests in REPLAYING mode to catch issues

Uh oh!

modular-magician commented Jul 19, 2023

Diff report

Uh oh!

modular-magician commented Jul 19, 2023

Diff report

Uh oh!

modular-magician commented Jul 19, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Jul 19, 2023

Uh oh!

modular-magician commented Jul 19, 2023

Diff report

Uh oh!

modular-magician commented Jul 19, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Jul 19, 2023

Uh oh!

zli82016 commented Aug 10, 2023

Uh oh!

modular-magician commented Aug 10, 2023

Diff report

Uh oh!

modular-magician commented Aug 10, 2023

Diff report

Uh oh!

modular-magician commented Aug 10, 2023

Diff report

Uh oh!

modular-magician commented Aug 10, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Aug 10, 2023

Uh oh!

modular-magician commented Aug 10, 2023

Diff report

Uh oh!

modular-magician commented Aug 11, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Aug 11, 2023

Uh oh!

zli82016 commented Aug 11, 2023

Uh oh!

modular-magician commented Aug 11, 2023

Diff report

Uh oh!

modular-magician commented Aug 11, 2023

Tests analytics

Action taken

Uh oh!

modular-magician commented Aug 11, 2023

Rerun these tests in REPLAYING mode to catch issues

Uh oh!

Reviewers

Assignees

Labels

zli82016 commented Jul 18, 2023 •

edited

Loading