Update subnetwork descriptions and tests to use REGIONAL_MANAGED_PROXY instead of deprecated INTERNAL_HTTPS_LOAD_BALANCER

[jlporter]

Update subnetwork descriptions and tests to use REGIONAL_MANAGED_PROXY instead of deprecated INTERNAL_HTTPS_LOAD_BALANCER

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

[modular-magician]

Hello! I am a robot. It looks like you are a community contributor. @melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 18 insertions(+), 17 deletions(-))
Terraform Beta: Diff ( 6 files changed, 21 insertions(+), 20 deletions(-))
TF OiCS: Diff ( 3 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2935
Passed tests 2630
Skipped tests: 302
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeSubnetwork_subnetworkInternalL7lbExample|TestAccComputeForwardingRule_forwardingRuleHttpLbExample|TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeSubnetwork_subnetworkInternalL7lbExample[Debug log]
TestAccComputeForwardingRule_forwardingRuleHttpLbExample[Debug log]
TestAccComputeForwardingRule_internalHttpLbWithMigBackendExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}
View the build log or the debug log for each test

[melinath]

LGTM overall - Looks like the tests work. Some docs suggestions below.

If INTERNAL_HTTPS_LOAD_BALANCER is deprecated and there's a new better way to do the same thing, we can just go ahead and remove it from the docs - since this is a String field, existing configurations will continue to work.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 15 insertions(+), 16 deletions(-))
Terraform Beta: Diff ( 6 files changed, 18 insertions(+), 19 deletions(-))
TF OiCS: Diff ( 3 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2939
Passed tests 2637
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[melinath]

Since you opted to remove INTERNAL_HTTPS_LOAD_BALANCER it would be great to remove it entirely. It looks like there's two more references to INTERNAL_HTTPS_LOAD_BALANCER in this file; one is on a line I can't comment on:

magic-modules/mmv1/products/compute/Subnetwork.yaml

Line 270 in c9fe732

subnetwork is `INTERNAL_HTTPS_LOAD_BALANCER` or `REGIONAL_MANAGED_PROXY` or `GLOBAL_MANAGED_PROXY`

It's a bit odd since the API docs for logConfig don't list this constraint: https://cloud.google.com/compute/docs/reference/rest/v1/subnetworks not sure what the right fix is.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 24 insertions(+), 25 deletions(-))
Terraform Beta: Diff ( 6 files changed, 27 insertions(+), 28 deletions(-))
TF OiCS: Diff ( 3 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2939
Passed tests 2637
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[melinath]

LGTM